Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solving bug in mflike #170

Merged
merged 1 commit into from
Mar 22, 2024
Merged

solving bug in mflike #170

merged 1 commit into from
Mar 22, 2024

Conversation

sgiardie
Copy link
Collaborator

related to Issue #168

@sgiardie sgiardie marked this pull request as draft March 15, 2024 16:25
@sgiardie sgiardie linked an issue Mar 15, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.63%. Comparing base (1b7c793) to head (0c68cb8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   74.61%   74.63%   +0.01%     
==========================================
  Files          33       33              
  Lines        2029     2030       +1     
==========================================
+ Hits         1514     1515       +1     
  Misses        515      515              
Files Coverage Δ
soliket/mflike/mflike.py 80.90% <100.00%> (+0.09%) ⬆️
soliket/mflike/theoryforge_MFLike.py 83.50% <100.00%> (ø)

@sgiardie sgiardie added the bug Something isn't working label Mar 15, 2024
@sgiardie sgiardie self-assigned this Mar 18, 2024
@sgiardie sgiardie requested a review from itrharrison March 18, 2024 09:29
@sgiardie sgiardie marked this pull request as ready for review March 18, 2024 09:29
@sgiardie sgiardie requested a review from mgerbino March 18, 2024 09:29
Copy link
Collaborator

@mgerbino mgerbino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look good to me and in agreement with bug solvers in original mflike

@mgerbino mgerbino merged commit ccc3854 into master Mar 22, 2024
5 checks passed
@mgerbino mgerbino deleted the fix_168 branch March 22, 2024 09:54
itrharrison added a commit that referenced this pull request Jun 7, 2024
* pyccl optional (#153)

* pyccl optional

* oops

* Add simple halo model (#150)

* remove depracated likelihood.theory calls

* codestyle

* sphinx compatability update

* sphinx compatability update 2204

* add build tools

* move rtd python ver

* rtd try different pyver

* rtd try different order

* conda on rtd

* update rtd mock import

* add rtd theme

* add rtd theme correctly

* add rtd theme in setup.cfg

* Testing yaml instead of yml.

* added docs conda env

* add full requirements in docs

* pin tensorflow dep

* started basic halo model

* started basic pyhm implementation and tests

* pkmm computation with z loop

* remove empty functions

* test against precomputed value

* codestyle and fix test

* add missing default files

* added docs

* line length

* remove refernce to bias model in docs

* improve docs

---------

Co-authored-by: Hidde Jense <JenseH@cardiff.ac.uk>

* Deprecations update (#155)

* pyccl optional

* oops

* remove pkg_resources

* str path

* pudate latest

* fix

* py311

* py311

* py311

* typo

* Update docs/soliket-docs.yml

* Update soliket-tests.yml

---------

Co-authored-by: Ian Harrison <itrharrison@gmail.com>

* Pycharm tidies (#161)

* pyccl optional

* oops

* remove pkg_resources

* str path

* added new warnings, fails

* pudate latest

* changes for new reqs

* fix

* py311

* py311

* py311

* update halomodel codestyle

* Mist tidy

* typo

* brackets

---------

Co-authored-by: Ian Harrison <itrharrison@gmail.com>

* Run tests only on PR open, review requests (#159)

* run tests only on PR open, review requests

* added some extra instructions in docs

* reorder on setting

* line break

* reset what is written in docs

* Add more flake8 requirements (#157)

* added new warnings, fails

* changes for new reqs

* update halomodel codestyle

* whitespace warnings

* added zstar to crosscorrelation (#165)

* Implementation of the lensing power spectrum computation with CCL (#166)

* Implementing the lensing power spectrum computation with CCL. Added a flag to choose whether to use CAMB or CCL to compute this power spectrum.

* Adding test to check CCL and CAMB agree to predict the CMB lensing power spectrum

---------

Co-authored-by: Raphaël Kou <raphael.kou@apc.in2p3.fr>

* solving bug in mflike (#170)

* Fix readme (#173)

* stricter indentation

* Update README.rst

* Dev check ell range mflike (#171)

* change to lmax requirements

* removing comments in modified files

* solving style issues

* solving issues in test mflike

* solving codestyle issues

* switched from hard-coded to l_bpws-depndt multipole

* fixed codestyle

---------

Co-authored-by: Martina Gerbino <bradamante@martina.local>
Co-authored-by: Ian Harrison <itrharrison@gmail.com>

* Resolving packages path with cobaya tools (#169)

* Fix extra letter in calibration params

* Use cobaya tools to resolve packages path

* flake

* Revert "flake"

This reverts commit 526acde.

* Update yaml files with correct paramnames and paths

For the `test_multi.py`, I switched from `MFLike` to `TestMFLike`, coherently with `test_mflike.py`

* Update paths in test_multi

* Enable multi and mflike in test_runs

* bug fix

* Avoid overwrite global packages_path

* flake

* Change pathfinding to data with packages path

* Revert to request forcing rootdir

* Point to `tox.ini` directory

---------

Co-authored-by: mgerbino <marti.gerbino@gmail.com>
Co-authored-by: Ian Harrison <itrharrison@gmail.com>

---------

Co-authored-by: Antony Lewis <cmbant@users.noreply.github.com>
Co-authored-by: Hidde Jense <JenseH@cardiff.ac.uk>
Co-authored-by: raphkou <61792335+raphkou@users.noreply.github.com>
Co-authored-by: Raphaël Kou <raphael.kou@apc.in2p3.fr>
Co-authored-by: Serena Giardiello <67148348+sgiardie@users.noreply.github.com>
Co-authored-by: mgerbino <marti.gerbino@gmail.com>
Co-authored-by: Martina Gerbino <bradamante@martina.local>
Co-authored-by: Giacomo Galloni <giacomo.galloni@unife.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calibration keys in theoryforge_MFLike
3 participants