Dev check ell range mflike #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 22, 2024 16:28
Merge remote-tracking branch 'origin/master' into dev-check-ell-range-mflike
sgiardie
previously approved these changes
Mar 25, 2024
|
The bug is fixed, though this PR can be further improved. However, given that I won't be able to do that in the next future, I prefer to merge what has been done so far to fix the bug and resume the activity as soon as I am back |
sgiardie
approved these changes
Apr 19, 2024
itrharrison
added a commit
that referenced
this pull request
Jun 7, 2024
* pyccl optional (#153) * pyccl optional * oops * Add simple halo model (#150) * remove depracated likelihood.theory calls * codestyle * sphinx compatability update * sphinx compatability update 2204 * add build tools * move rtd python ver * rtd try different pyver * rtd try different order * conda on rtd * update rtd mock import * add rtd theme * add rtd theme correctly * add rtd theme in setup.cfg * Testing yaml instead of yml. * added docs conda env * add full requirements in docs * pin tensorflow dep * started basic halo model * started basic pyhm implementation and tests * pkmm computation with z loop * remove empty functions * test against precomputed value * codestyle and fix test * add missing default files * added docs * line length * remove refernce to bias model in docs * improve docs --------- Co-authored-by: Hidde Jense <JenseH@cardiff.ac.uk> * Deprecations update (#155) * pyccl optional * oops * remove pkg_resources * str path * pudate latest * fix * py311 * py311 * py311 * typo * Update docs/soliket-docs.yml * Update soliket-tests.yml --------- Co-authored-by: Ian Harrison <itrharrison@gmail.com> * Pycharm tidies (#161) * pyccl optional * oops * remove pkg_resources * str path * added new warnings, fails * pudate latest * changes for new reqs * fix * py311 * py311 * py311 * update halomodel codestyle * Mist tidy * typo * brackets --------- Co-authored-by: Ian Harrison <itrharrison@gmail.com> * Run tests only on PR open, review requests (#159) * run tests only on PR open, review requests * added some extra instructions in docs * reorder on setting * line break * reset what is written in docs * Add more flake8 requirements (#157) * added new warnings, fails * changes for new reqs * update halomodel codestyle * whitespace warnings * added zstar to crosscorrelation (#165) * Implementation of the lensing power spectrum computation with CCL (#166) * Implementing the lensing power spectrum computation with CCL. Added a flag to choose whether to use CAMB or CCL to compute this power spectrum. * Adding test to check CCL and CAMB agree to predict the CMB lensing power spectrum --------- Co-authored-by: Raphaël Kou <raphael.kou@apc.in2p3.fr> * solving bug in mflike (#170) * Fix readme (#173) * stricter indentation * Update README.rst * Dev check ell range mflike (#171) * change to lmax requirements * removing comments in modified files * solving style issues * solving issues in test mflike * solving codestyle issues * switched from hard-coded to l_bpws-depndt multipole * fixed codestyle --------- Co-authored-by: Martina Gerbino <bradamante@martina.local> Co-authored-by: Ian Harrison <itrharrison@gmail.com> * Resolving packages path with cobaya tools (#169) * Fix extra letter in calibration params * Use cobaya tools to resolve packages path * flake * Revert "flake" This reverts commit 526acde. * Update yaml files with correct paramnames and paths For the `test_multi.py`, I switched from `MFLike` to `TestMFLike`, coherently with `test_mflike.py` * Update paths in test_multi * Enable multi and mflike in test_runs * bug fix * Avoid overwrite global packages_path * flake * Change pathfinding to data with packages path * Revert to request forcing rootdir * Point to `tox.ini` directory --------- Co-authored-by: mgerbino <marti.gerbino@gmail.com> Co-authored-by: Ian Harrison <itrharrison@gmail.com> --------- Co-authored-by: Antony Lewis <cmbant@users.noreply.github.com> Co-authored-by: Hidde Jense <JenseH@cardiff.ac.uk> Co-authored-by: raphkou <61792335+raphkou@users.noreply.github.com> Co-authored-by: Raphaël Kou <raphael.kou@apc.in2p3.fr> Co-authored-by: Serena Giardiello <67148348+sgiardie@users.noreply.github.com> Co-authored-by: mgerbino <marti.gerbino@gmail.com> Co-authored-by: Martina Gerbino <bradamante@martina.local> Co-authored-by: Giacomo Galloni <giacomo.galloni@unife.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve some inconsistencies in the way the ell range was handled in soliket/mflike. In particular, the ell range is now common between cmb and fg spectra and is set via l_bpws read from the sacc file.