release/2.18.0 -> develop (#15103)

* Bump version and update CHANGELOG fore core v2.18.0 Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com> * core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion (#14861) * core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion * .github: CCIP CODEOWNERS (cherry picked from commit cc9bafa) * TXM Configmer logs warning only if the provided chain does not contain finalized block (#14914) (cherry picked from commit 47aaff4) * Update DA oracle config struct members to pointers (#15008) * Update DA oracle config struct members to pointers * Update tests and remake config docs * suggestions and fix docs_test * fix config test (cherry picked from commit b585654) * Consume latest changeset and update changelog (#15036) * Finalize date on changelog for 2.18.0 (#15073) Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com> * Add spacing to comments to appease linter --------- Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com> Co-authored-by: Jordan Krage <jmank88@gmail.com> Co-authored-by: Dmytro Haidashenko <34754799+dhaidashenko@users.noreply.github.com> Co-authored-by: Oliver Townsend <133903322+ogtownsend@users.noreply.github.com>
smartcontractkit · Nov 7, 2024 · 3bcc787 · 3bcc787
1 parent 3b6aace
commit 3bcc787
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 12 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -35,6 +35,10 @@
 /core/services/ccip @smartcontractkit/ccip
 /core/services/ocr2/plugins/ccip @smartcontractkit/ccip
 
+# CCIP
+/core/services/ccip @smartcontractkit/ccip
+/core/services/ocr2/plugins/ccip @smartcontractkit/ccip
+
 # VRF-related services
 /core/services/vrf @smartcontractkit/dev-services @smartcontractkit/core
 /core/services/blockhashstore @smartcontractkit/dev-services @smartcontractkit/core

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,6 @@
 # Changelog Chainlink Core
 
-## 2.18.0 - UNRELEASED
+## 2.18.0 - 2024-11-01
 
 ### Minor Changes
 
@@ -90,12 +90,10 @@
 - [#14693](https://github.com/smartcontractkit/chainlink/pull/14693) [`03df8989e8`](https://github.com/smartcontractkit/chainlink/commit/03df8989e8e7549afb05bb49c765c0c07db8669e) Thanks [@ChrisAmora](https://github.com/ChrisAmora)! - #updated Consume Feeds Manager WSRPC protos from Chainlink Protos Repository.
 - [#14694](https://github.com/smartcontractkit/chainlink/pull/14694) [`e9b3397f46`](https://github.com/smartcontractkit/chainlink/commit/e9b3397f465e26209c8c8ccfed66aa9595f8246b) Thanks [@mateusz-sekara](https://github.com/mateusz-sekara)! - Adjustments for usdc reader tests #internal
 - [#14624](https://github.com/smartcontractkit/chainlink/pull/14624) [`be774f00a9`](https://github.com/smartcontractkit/chainlink/commit/be774f00a961d9a7361d9ae5b10c97996f7ab164) Thanks [@mateusz-sekara](https://github.com/mateusz-sekara)! - Registering USDC/CCTP events in the ChainReader during oracle creation #internal
-- [#14534](https://github.com/smartcontractkit/chainlink/pull/14534) [`de268e98b8`](https://github.com/smartcontractkit/chainlink/commit/de268e98b8d68a284e1260297925b91c5d2411bc) Thanks [@huangzhen1997](https://github.com/huangzhen1997)! - - register polling subscription to avoid subscription leaking when rpc client gets closed.
-
+- [#14534](https://github.com/smartcontractkit/chainlink/pull/14534) [`de268e98b8`](https://github.com/smartcontractkit/chainlink/commit/de268e98b8d68a284e1260297925b91c5d2411bc) Thanks [@huangzhen1997](https://github.com/huangzhen1997)!
+  - register polling subscription to avoid subscription leaking when rpc client gets closed.
   - add a temporary special treatment for SubscribeNewHead before we replace it with SubscribeToHeads. Add a goroutine that forwards new head from poller to caller channel.
-  - fix a deadlock in poller, by using a new lock for subs slice in rpc client.
-    #bugfix
-
+  - fix a deadlock in poller, by using a new lock for subs slice in rpc client. #bugfix
 - [#14656](https://github.com/smartcontractkit/chainlink/pull/14656) [`004a0de233`](https://github.com/smartcontractkit/chainlink/commit/004a0de2337b0312558ae7c045e7fc2fb4a05916) Thanks [@dimkouv](https://github.com/dimkouv)! - #added graceful shutdown for ccip oracles
 - [#14720](https://github.com/smartcontractkit/chainlink/pull/14720) [`4f8c55eb01`](https://github.com/smartcontractkit/chainlink/commit/4f8c55eb01b5823f43f49761344e92dc37ec0114) Thanks [@vyzaldysanchez](https://github.com/vyzaldysanchez)! - #updated Refactors store_db
 - [#14530](https://github.com/smartcontractkit/chainlink/pull/14530) [`2c16f46311`](https://github.com/smartcontractkit/chainlink/commit/2c16f4631184a6e3da7f2f3957173500e2c4837b) Thanks [@Madalosso](https://github.com/Madalosso)! - #updated default config values for FinalityTagEnabled to match CCIP configs
@@ -108,6 +106,7 @@
 - [#14668](https://github.com/smartcontractkit/chainlink/pull/14668) [`dacb6a8c70`](https://github.com/smartcontractkit/chainlink/commit/dacb6a8c708e8d7cb94aa63ae7463f58a38d0e59) Thanks [@winder](https://github.com/winder)! - #internal ccip contract reader config.
 - [#14814](https://github.com/smartcontractkit/chainlink/pull/14814) [`f708ebb094`](https://github.com/smartcontractkit/chainlink/commit/f708ebb094ecd6f4f77e9c480ceacd250fc1fadc) Thanks [@DylanTinianov](https://github.com/DylanTinianov)! - Fix testWSServer issue causing panic in testing #internal
 - [#14635](https://github.com/smartcontractkit/chainlink/pull/14635) [`ee1d6e3b1a`](https://github.com/smartcontractkit/chainlink/commit/ee1d6e3b1a60dc657a5cab869aac0897e33dc76d) Thanks [@dhaidashenko](https://github.com/dhaidashenko)! - Hedera chain type: broadcast transactions only to a single healthy RPC instead of all healthy RPCs to avoid redundant relay fees. #changed
+- [#15031](https://github.com/smartcontractkit/chainlink/pull/15031) [`6951f9e74a`](https://github.com/smartcontractkit/chainlink/commit/6951f9e74ae016fab1548b682d4fd8ed5b818d3c) Thanks [@ogtownsend](https://github.com/ogtownsend)! - #bugfix Update DA oracle config struct members to pointers
 
 ## 2.17.0 - 2024-10-10
 

diff --git a/common/txmgr/confirmer.go b/common/txmgr/confirmer.go
@@ -1078,12 +1078,12 @@ func (ec *Confirmer[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) Ens
 	}
 
 	// Here, we rely on the finalized block provided in the chain instead of the one
-	//provided via a dedicated method to avoid the false warning of the chain being
-	//too short. When `FinalityTagBypass = true,` HeadTracker tracks `finality depth
-	//+ history depth` to prevent excessive CPU usage. Thus, the provided chain may
-	//be shorter than the chain from the latest to the latest finalized, marked with
-	//a tag. A proper fix of this issue and complete switch to finality tag support
-	//will be introduced in BCFR-620
+	// provided via a dedicated method to avoid the false warning of the chain being
+	// too short. When `FinalityTagBypass = true,` HeadTracker tracks `finality depth
+	// + history depth` to prevent excessive CPU usage. Thus, the provided chain may
+	// be shorter than the chain from the latest to the latest finalized, marked with
+	// a tag. A proper fix of this issue and complete switch to finality tag support
+	// will be introduced in BCFR-620
 	latestFinalized := head.LatestFinalizedHead()
 	if latestFinalized == nil || !latestFinalized.IsValid() {
 		if ec.nConsecutiveBlocksChainTooShort > logAfterNConsecutiveBlocksChainTooShort {