Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion #14861

Merged
merged 2 commits into from
Oct 22, 2024
Merged

core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion #14861

merged 2 commits into from
Oct 22, 2024
+7 −0

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Oct 21, 2024 •
edited
Loading 

core/services/ocr2/plugins/ccip/internal/ccipdata/factory/price_registry.go:37:25: ineffectual assignment to err (ineffassign)
	contractType, version, err := versionFinder.TypeAndVersion(priceRegistryAddress, cl)

@jmank88 jmank88 requested a review from a team as a code owner October 21, 2024 12:23
@jmank88 jmank88 requested a review from a team as a code owner October 21, 2024 12:30
@jmank88 jmank88 requested a review from a team October 21, 2024 12:30
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit cc9bafa Oct 22, 2024
146 of 147 checks passed
@jmank88 jmank88 deleted the ccipdata-err-check branch October 22, 2024 19:44
jmank88 added a commit that referenced this pull request Oct 22, 2024
@jmank88
core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check erro…
bbd887e 
…r from TypeAndVersion (#14861)

* core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion

* .github: CCIP CODEOWNERS

(cherry picked from commit cc9bafa)
@jmank88 jmank88 mentioned this pull request Oct 22, 2024
Merged
0xsuryansh pushed a commit that referenced this pull request Oct 23, 2024
@jmank88 @0xsuryansh
core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check erro…
133898a 
…r from TypeAndVersion (#14861)

* core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion

* .github: CCIP CODEOWNERS
momentmaker added a commit that referenced this pull request Oct 23, 2024
@momentmaker
Merge branch 'develop' into re-3123/add-changesetKey-check
5750274 
* develop:
  rm gethwrappers from codeowners offchain (#14919)
  CCIP-3899 fix sender encoding (#14877)
  ccip: use unknown address type. (#14836)
  [chore] Add changeset entry for RequestRoundTracker fix (#14912)
  various Solidity Foundry updates (#14866)
  CCIP-3710 create new custom calldata L1 (DA) gas oracle (#14710)
  CCIP owns smoke test (#14906)
  core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion (#14861)
  CCIP-3730 Misc ccip onchain changes (#14845)
  Chain fee integration tests (#14829)
  release/2.17.0 -> develop (#14721)
  Solana: re-enable disabled test with updated version (#14892)
cedric-cordenier pushed a commit that referenced this pull request Oct 24, 2024
@jmank88 @cedric-cordenier
core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check erro…
cd6dd9f 
…r from TypeAndVersion (#14861)

* core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion

* .github: CCIP CODEOWNERS
@chainchad chainchad mentioned this pull request Nov 1, 2024
Closed
github-merge-queue bot pushed a commit that referenced this pull request Nov 8, 2024
@chainchad @jmank88
@dhaidashenko @ogtownsend
release/2.18.0 -> develop (#15103)
f4565c5 
* Bump version and update CHANGELOG fore core v2.18.0

Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com>

* core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion (#14861)

* core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion

* .github: CCIP CODEOWNERS

(cherry picked from commit cc9bafa)

* TXM Configmer logs warning only if the provided chain does not contain finalized block (#14914)

(cherry picked from commit 47aaff4)

* Update DA oracle config struct members to pointers (#15008)

* Update DA oracle config struct members to pointers

* Update tests and remake config docs

* suggestions and fix docs_test

* fix config test

(cherry picked from commit b585654)

* Consume latest changeset and update changelog (#15036)

* Finalize date on changelog for 2.18.0 (#15073)

Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com>

* Add spacing to comments to appease linter

---------

Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com>
Co-authored-by: Jordan Krage <jmank88@gmail.com>
Co-authored-by: Dmytro Haidashenko <34754799+dhaidashenko@users.noreply.github.com>
Co-authored-by: Oliver Townsend <133903322+ogtownsend@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CL-Andrew CL-Andrew CL-Andrew approved these changes

@chainchad chainchad chainchad approved these changes

@krehermann krehermann krehermann approved these changes

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@andrevmatos andrevmatos andrevmatos approved these changes

@obelisk obelisk Awaiting requested review from obelisk

@securemitchell securemitchell Awaiting requested review from securemitchell

@secureandrew secureandrew Awaiting requested review from secureandrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmank88 @andrevmatos @vyzaldysanchez @krehermann @chainchad @CL-Andrew