Update DA oracle config struct members to pointers #15008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
ogtownsend
force-pushed
the
chore/use-pointers-to-get-daoracle-type
branch
from
51c3d6e
to
a1dadd1
Compare
ogtownsend
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xnogo
and removed request for
dimkouv,
0xnogo,
winder,
rstout,
asoliman92,
makramkd and
mateusz-sekara
jmank88
reviewed
Oct 29, 2024
jmank88
reviewed
Oct 29, 2024
jmank88
reviewed
Oct 29, 2024
ogtownsend
force-pushed
the
chore/use-pointers-to-get-daoracle-type
branch
from
41ffa23
to
34a5bf7
Compare
chainchad
reviewed
Oct 29, 2024
ogtownsend
commented
Oct 29, 2024
jmank88
reviewed
Oct 29, 2024
ogtownsend
force-pushed
the
chore/use-pointers-to-get-daoracle-type
branch
from
e6d8ec3
to
05a76f1
Compare
|
ogtownsend
commented
Oct 29, 2024
jmank88
approved these changes
Oct 29, 2024
chainchad
approved these changes
Oct 30, 2024
mateusz-sekara
approved these changes
Oct 30, 2024
ogtownsend
added a commit
that referenced
this pull request
Oct 30, 2024
* Update DA oracle config struct members to pointers * Update tests and remake config docs * suggestions and fix docs_test * fix config test (cherry picked from commit b585654)
ogtownsend
added a commit
that referenced
this pull request
Oct 30, 2024
* Update DA oracle config struct members to pointers * Update tests and remake config docs * suggestions and fix docs_test * fix config test (cherry picked from commit b585654)
ogtownsend
added a commit
that referenced
this pull request
Oct 30, 2024
* Update DA oracle config struct members to pointers * Update tests and remake config docs * suggestions and fix docs_test * fix config test (cherry picked from commit b585654)
ogtownsend
added a commit
that referenced
this pull request
Oct 30, 2024
…bugfix-da-struct Update DA oracle config struct members to pointers (#15008)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Bump version and update CHANGELOG fore core v2.18.0 Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com> * core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion (#14861) * core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion * .github: CCIP CODEOWNERS (cherry picked from commit cc9bafa) * TXM Configmer logs warning only if the provided chain does not contain finalized block (#14914) (cherry picked from commit 47aaff4) * Update DA oracle config struct members to pointers (#15008) * Update DA oracle config struct members to pointers * Update tests and remake config docs * suggestions and fix docs_test * fix config test (cherry picked from commit b585654) * Consume latest changeset and update changelog (#15036) * Finalize date on changelog for 2.18.0 (#15073) Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com> * Add spacing to comments to appease linter --------- Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com> Co-authored-by: Jordan Krage <jmank88@gmail.com> Co-authored-by: Dmytro Haidashenko <34754799+dhaidashenko@users.noreply.github.com> Co-authored-by: Oliver Townsend <133903322+ogtownsend@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSIA