Update DA oracle config struct members to pointers (#15008) #15031
+99
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ogtownsend
commented
Oct 30, 2024
•
ogtownsend
commented
- Cherry-picking this PR into release/2.18.0: Update DA oracle config struct members to pointers #15008
- Ran into conflicts with this previously merged PR which didn't quite make it into 2.18: CCIP-3710 create new custom calldata L1 (DA) gas oracle #14710
- Decided to NOT include CCIP-3710 create new custom calldata L1 (DA) gas oracle #14710 's changes in this cherry pick and leave it for the next release
ogtownsend
force-pushed
the
chore/release/2.18.0-bugfix-da-struct
branch
from
44b7b5e
to
9764f46
Compare
* Update DA oracle config struct members to pointers * Update tests and remake config docs * suggestions and fix docs_test * fix config test (cherry picked from commit b585654)
ogtownsend
force-pushed
the
chore/release/2.18.0-bugfix-da-struct
branch
from
9764f46
to
6951f9e
Compare
ogtownsend
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xnogo,
ilija42 and
jmank88
and removed request for
a team,
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xnogo and
ilija42
chainchad
approved these changes
Oct 30, 2024
AER Report: CI Core ran successfully ✅ |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.