Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCIP-3710 create new custom calldata L1 (DA) gas oracle #14710

Merged
merged 4 commits into from
Oct 23, 2024
Merged

CCIP-3710 create new custom calldata L1 (DA) gas oracle #14710

merged 4 commits into from
Oct 23, 2024

Conversation

ogtownsend
Copy link
Collaborator

@ogtownsend ogtownsend commented Oct 9, 2024 •
edited
Loading

As a follow up to #14599, this PR adds a separate custom L1 (DA) oracle specifically for fetching gas prices from a custom contract method rather than baking the logic into the existing OP stack DA oracle

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

WF: CI Core#f13e0d7

No errors found in this run. 🎉

@ogtownsend ogtownsend force-pushed the CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles branch from 9cdbf76 to 41b5cb9 Compare October 9, 2024 21:55
@ogtownsend ogtownsend force-pushed the CCIP-3552-refactor-op-stack-oracle-to-accept-generic-op-l-2-config branch 2 times, most recently from e33bf1e to 6ab6540 Compare October 10, 2024 20:36
Base automatically changed from CCIP-3552-refactor-op-stack-oracle-to-accept-generic-op-l-2-config to develop October 11, 2024 19:07
@ogtownsend ogtownsend force-pushed the CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles branch from 41b5cb9 to 6c8b7f5 Compare October 11, 2024 22:52
@ogtownsend ogtownsend changed the base branch from develop to chore/move-da-oracle-config-consts October 11, 2024 22:52
@ogtownsend ogtownsend force-pushed the CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles branch 2 times, most recently from 528e80a to 69ab245 Compare October 11, 2024 23:14
@ogtownsend ogtownsend force-pushed the chore/move-da-oracle-config-consts branch 2 times, most recently from 4acfdef to 26b8299 Compare October 15, 2024 00:41
@ogtownsend ogtownsend force-pushed the CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles branch from 69ab245 to 493c82b Compare October 15, 2024 00:52
@ogtownsend ogtownsend changed the title CCIP-3710 create new custom calldata L1 gas oracle CCIP-3710 create new custom calldata L1 (DA) gas oracle Oct 15, 2024
@ogtownsend ogtownsend force-pushed the CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles branch from 493c82b to e63f1aa Compare October 15, 2024 00:59
@ogtownsend ogtownsend mentioned this pull request Oct 15, 2024
Merged
@ogtownsend ogtownsend marked this pull request as ready for review October 15, 2024 01:01
@ogtownsend ogtownsend requested review from a team as code owners October 15, 2024 01:01
@ogtownsend ogtownsend requested review from patrickhuie19, winder, asoliman92 and amit-momin and removed request for a team October 15, 2024 01:01
@ogtownsend ogtownsend force-pushed the CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles branch from 641cc51 to cf087a9 Compare October 15, 2024 16:42
@ogtownsend ogtownsend requested review from a team as code owners October 15, 2024 16:42
@ogtownsend ogtownsend force-pushed the CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles branch from 919e44a to 26112c3 Compare October 18, 2024 22:01
@ogtownsend ogtownsend force-pushed the CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles branch from 26112c3 to 3014ee4 Compare October 21, 2024 17:24
amit-momin
amit-momin previously approved these changes Oct 21, 2024
View reviewed changes
@ogtownsend ogtownsend force-pushed the CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles branch 2 times, most recently from 66bf39c to 7139964 Compare October 21, 2024 19:09
@ogtownsend ogtownsend force-pushed the CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles branch from 7139964 to 22a3d53 Compare October 21, 2024 20:39
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ogtownsend
Copy link
Collaborator Author

Hey @jmank88 or @patrickhuie19 (or someone else from foundations) would you mind checking out this PR please?

patrickhuie19
patrickhuie19 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@patrickhuie19 patrickhuie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs and config changes lgtm!

@ogtownsend ogtownsend added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit 12174c7 Oct 23, 2024
129 checks passed
@ogtownsend ogtownsend deleted the CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles branch October 23, 2024 00:06
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Draft
0xsuryansh pushed a commit that referenced this pull request Oct 23, 2024
@ogtownsend @0xsuryansh
CCIP-3710 create new custom calldata L1 (DA) gas oracle (#14710)
f4b7c88 
* Add new custom calldata DA oracle

* added more tests

* rename logger

* lint
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Draft
momentmaker added a commit that referenced this pull request Oct 23, 2024
@momentmaker
Merge branch 'develop' into re-3123/add-changesetKey-check
5750274 
* develop:
  rm gethwrappers from codeowners offchain (#14919)
  CCIP-3899 fix sender encoding (#14877)
  ccip: use unknown address type. (#14836)
  [chore] Add changeset entry for RequestRoundTracker fix (#14912)
  various Solidity Foundry updates (#14866)
  CCIP-3710 create new custom calldata L1 (DA) gas oracle (#14710)
  CCIP owns smoke test (#14906)
  core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion (#14861)
  CCIP-3730 Misc ccip onchain changes (#14845)
  Chain fee integration tests (#14829)
  release/2.17.0 -> develop (#14721)
  Solana: re-enable disabled test with updated version (#14892)
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Draft
cedric-cordenier pushed a commit that referenced this pull request Oct 24, 2024
@ogtownsend @cedric-cordenier
CCIP-3710 create new custom calldata L1 (DA) gas oracle (#14710)
3c40e9b 
* Add new custom calldata DA oracle

* added more tests

* rename logger

* lint
@ogtownsend ogtownsend mentioned this pull request Oct 30, 2024
Merged
@chainchad chainchad mentioned this pull request Nov 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request Nov 2, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-momin amit-momin amit-momin approved these changes

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@matYang matYang matYang left review comments

@winder winder Awaiting requested review from winder

@asoliman92 asoliman92 Awaiting requested review from asoliman92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ogtownsend @matYang @patrickhuie19 @amit-momin