CCIP-3710 create new custom calldata L1 (DA) gas oracle #14710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WF: CI Core#f13e0d7No errors found in this run. 🎉 |
ogtownsend
force-pushed
the
CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles
branch
from
9cdbf76 to
41b5cb9
Compare
matYang
reviewed
Oct 10, 2024
matYang
reviewed
Oct 10, 2024
ogtownsend
force-pushed
the
CCIP-3552-refactor-op-stack-oracle-to-accept-generic-op-l-2-config
branch
2 times, most recently
from
e33bf1e to
6ab6540
Compare
Base automatically changed from
CCIP-3552-refactor-op-stack-oracle-to-accept-generic-op-l-2-config
to
develop
October 11, 2024 19:07
ogtownsend
force-pushed
the
CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles
branch
from
41b5cb9 to
6c8b7f5
Compare
ogtownsend
changed the base branch from
develop
to
chore/move-da-oracle-config-consts
ogtownsend
force-pushed
the
CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles
branch
2 times, most recently
from
528e80a to
69ab245
Compare
ogtownsend
force-pushed
the
chore/move-da-oracle-config-consts
branch
2 times, most recently
from
4acfdef to
26b8299
Compare
ogtownsend
force-pushed
the
CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles
branch
from
69ab245 to
493c82b
Compare
ogtownsend
changed the title
ogtownsend
force-pushed
the
CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles
branch
from
493c82b to
e63f1aa
Compare
ogtownsend
requested review from
patrickhuie19,
winder,
asoliman92 and
amit-momin
and removed request for
a team
ogtownsend
force-pushed
the
CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles
branch
from
641cc51 to
cf087a9
Compare
ogtownsend
force-pushed
the
CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles
branch
2 times, most recently
from
66bf39c to
7139964
Compare
ogtownsend
force-pushed
the
CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles
branch
from
7139964 to
22a3d53
Compare
|
amit-momin
approved these changes
Oct 22, 2024
|
Hey @jmank88 or @patrickhuie19 (or someone else from foundations) would you mind checking out this PR please? |
patrickhuie19
approved these changes
Oct 22, 2024
ogtownsend
deleted the
CCIP-3710-create-new-custom-calldata-oracle-separate-from-existing-da-oracles
branch
0xsuryansh
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Add new custom calldata DA oracle * added more tests * rename logger * lint
momentmaker
added a commit
that referenced
this pull request
Oct 23, 2024
* develop: rm gethwrappers from codeowners offchain (#14919) CCIP-3899 fix sender encoding (#14877) ccip: use unknown address type. (#14836) [chore] Add changeset entry for RequestRoundTracker fix (#14912) various Solidity Foundry updates (#14866) CCIP-3710 create new custom calldata L1 (DA) gas oracle (#14710) CCIP owns smoke test (#14906) core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion (#14861) CCIP-3730 Misc ccip onchain changes (#14845) Chain fee integration tests (#14829) release/2.17.0 -> develop (#14721) Solana: re-enable disabled test with updated version (#14892)
cedric-cordenier
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Add new custom calldata DA oracle * added more tests * rename logger * lint
This was referenced Oct 21, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #14599, this PR adds a separate custom L1 (DA) oracle specifically for fetching gas prices from a custom contract method rather than baking the logic into the existing OP stack DA oracle