-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow more characters in model name (and number) #82
Comments
The validators are there to reduce risk of XSS. Laravel does a nice job of escaping data on the way out, but I've run into a few jquery plugins in this project that reversed that escaping, actually re-assembling the HTML encoding and making it vulnerable. There's just no reason to use < or > in this data, so I'm validating against it. I'll find a better balance of characters to filter out - that custom validate was my first stab at writing a custom validator in this framework, so I expect to massage the particulars over time. In general, whitelisting is a better approach than blacklisting, IMHO. Takes longer, but more thorough. |
Fixed in 33f81ab |
I assume the restrictiveness is a side effect of #57. Not sure what the best solution is here. But right now, you can't even edit the seed data because the validation will fail (seed models include
( )
and,
).If it were me, I would validate their presence and that's it, but I don't know what other concerns you already ran into that had you add the validators in the first place.
The text was updated successfully, but these errors were encountered: