Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError Exception when importing dynamic data of Synchronous Machines #23

Closed
martinmoraga opened this issue Oct 10, 2023 · 1 comment
Closed

TypeError Exception when importing dynamic data of Synchronous Machines #23

martinmoraga opened this issue Oct 10, 2023 · 1 comment
Assignees
@martinmoraga
Labels
bug Something isn't working

Comments

@martinmoraga
Copy link
Contributor

martinmoraga commented Oct 10, 2023 •
edited
Loading

The parameter inertia of the class RotatingMachineDynamics is initialized in the contructor as an integer (see here).

When importing dynamic data, cimimport is converting the values of the cim files using the default value of the cimpy classes. That means, that cimimport tries to read the parameter inertia fro the CIM files as an integer and not as a float which traslante into an exception when reading dynamic data of cim topologies (see here)

The same bahaviour can be observed in the class SynchronousMachineTimeConstantReactance. The parameters tpdo, tppdo, tpqo, tppqo, tc should be initialized as floats in the contructor of the class.
@martinmoraga martinmoraga added the bug Something isn't working label Oct 10, 2023
@martinmoraga martinmoraga self-assigned this Oct 10, 2023
@martinmoraga martinmoraga linked a pull request Oct 10, 2023 that will close this issue
Fix typeerror exception when importing dynamic data of synchronous machines #24
Closed
@martinmoraga martinmoraga mentioned this issue Oct 10, 2023
Closed
@martinmoraga martinmoraga mentioned this issue Oct 26, 2023
Open
@tom-hg57 tom-hg57 mentioned this issue Oct 3, 2024
Merged
m-mirz added a commit that referenced this issue Oct 30, 2024
@m-mirz
Add generation of CGMES profile class (#39)
0b78484 
Depends on cimgen pull request:
sogno-platform/cimgen#35, which is already
merged now.

In my repo all workflows run successfully:
tom-hg57#1 (even deploying of
github-pages).

Improve cimexport.py using profile URIs (from new generated
CGMESProfile.py) in model description of exported cim files
- Update generated python files created by cimgen
- Use profile URIs (from new generated CGMESProfile.py) in model
description of exported cim files
- Fix "Package information not found" for EquipmentBoundary and
ToplogyBoundary in cim_import() by using new generated CGMESProfile.py
- Fix export for data read without profile information
- Improve cim_export (activeProfileList is now optional - no
activeProfileList means output to all profile files with data)
- Add function cim_export_to_string_array
- Fix model ID in cim_export (must be unique across all files)
- Use recommended class profile from new generated classes (if data is
read without profile information, or some objects are added after
import)
- Improve .github/workflows/test.yaml
- Update documentation in cimpy/cimexport.py

With the new generated python files created by cimgen the issue
#23 is solved. PR
#24 could be closed if this
PR is merged.

The same applies to issue
#25 and PR
#26.
@m-mirz
Copy link
Contributor

m-mirz commented Oct 30, 2024

solved in #39

@m-mirz m-mirz closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinmoraga martinmoraga

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typeerror exception when importing dynamic data of synchronous machines sogno-platform/cimpy
2 participants
@m-mirz @martinmoraga