Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typeerror exception when importing dynamic data of synchronous machines #24

Conversation

martinmoraga
Copy link
Contributor

Issue #23

@martinmoraga martinmoraga added the bug Something isn't working label Oct 10, 2023
@martinmoraga martinmoraga self-assigned this Oct 10, 2023
@martinmoraga martinmoraga force-pushed the 23-typeerror-exception-when-importing-dynamic-data-of-synchronous-machines branch from 817aeb2 to 8d937f0 Compare October 25, 2023 11:33
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stv0g stv0g changed the title 23 typeerror exception when importing dynamic data of synchronous machines Fix typeerror exception when importing dynamic data of synchronous machines Jun 17, 2024
@m-mirz m-mirz force-pushed the 23-typeerror-exception-when-importing-dynamic-data-of-synchronous-machines branch from 8d937f0 to 26d6b7b Compare June 19, 2024 14:30
@m-mirz
Copy link
Contributor

m-mirz commented Jun 19, 2024

@martinmoraga could you please add the dco sign off? Then this can be merged.

@stv0g
Copy link
Contributor

stv0g commented Jun 20, 2024

Has this been fixed in CIMgen? Fixing it just here wont help anybody in the long run as the changes will get lost when the code gets regenerated.

@m-mirz
Copy link
Contributor

m-mirz commented Jun 20, 2024

Has this been fixed in CIMgen? Fixing it just here wont help anybody in the long run as the changes will get lost when the code gets regenerated.

I agree. My intention was to create an issue in cimgen when merging this so that we don’t forget this issue.

@martinmoraga martinmoraga force-pushed the 23-typeerror-exception-when-importing-dynamic-data-of-synchronous-machines branch from 26d6b7b to bc81cc6 Compare June 21, 2024 09:41
initialize dynamic parameters of class SynchronousMachineTimeConstantReactance as float

Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Signed-off-by: Martin Moraga <martin.moraga@rwth-aachen.de>
initialize parameter 'inertia' of class RotatingMachineDynamics as float

Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Signed-off-by: Martin Moraga <martin.moraga@rwth-aachen.de>
@martinmoraga martinmoraga force-pushed the 23-typeerror-exception-when-importing-dynamic-data-of-synchronous-machines branch from bc81cc6 to 6c33b53 Compare June 21, 2024 09:42
Copy link

sonarcloud bot commented Jun 21, 2024

@martinmoraga
Copy link
Contributor Author

@martinmoraga could you please add the dco sign off? Then this can be merged.

@m-mirz Done!

But the pipeline fails now with the error:

Branch "23-typeerror-exception-when-importing-dynamic-data-of-synchronous-machines" is not allowed to deploy to github-pages due to environment protection rules.

@stv0g
Copy link
Contributor

stv0g commented Jun 21, 2024

But the pipeline fails now with the error

Okay, thats my fault. Sorry I will have a look

m-mirz added a commit that referenced this pull request Oct 30, 2024
Depends on cimgen pull request:
sogno-platform/cimgen#35, which is already
merged now.

In my repo all workflows run successfully:
tom-hg57#1 (even deploying of
github-pages).

Improve cimexport.py using profile URIs (from new generated
CGMESProfile.py) in model description of exported cim files
- Update generated python files created by cimgen
- Use profile URIs (from new generated CGMESProfile.py) in model
description of exported cim files
- Fix "Package information not found" for EquipmentBoundary and
ToplogyBoundary in cim_import() by using new generated CGMESProfile.py
- Fix export for data read without profile information
- Improve cim_export (activeProfileList is now optional - no
activeProfileList means output to all profile files with data)
- Add function cim_export_to_string_array
- Fix model ID in cim_export (must be unique across all files)
- Use recommended class profile from new generated classes (if data is
read without profile information, or some objects are added after
import)
- Improve .github/workflows/test.yaml
- Update documentation in cimpy/cimexport.py

With the new generated python files created by cimgen the issue
#23 is solved. PR
#24 could be closed if this
PR is merged.

The same applies to issue
#25 and PR
#26.
@m-mirz
Copy link
Contributor

m-mirz commented Oct 30, 2024

This is covered in #39 and also fixed in cimgen thanks to @tom-hg57

@m-mirz m-mirz closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError Exception when importing dynamic data of Synchronous Machines
5 participants