-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typeerror exception when importing dynamic data of synchronous machines #24
Fix typeerror exception when importing dynamic data of synchronous machines #24
Conversation
817aeb2
to
8d937f0
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
8d937f0
to
26d6b7b
Compare
@martinmoraga could you please add the dco sign off? Then this can be merged. |
Has this been fixed in CIMgen? Fixing it just here wont help anybody in the long run as the changes will get lost when the code gets regenerated. |
I agree. My intention was to create an issue in cimgen when merging this so that we don’t forget this issue. |
26d6b7b
to
bc81cc6
Compare
initialize dynamic parameters of class SynchronousMachineTimeConstantReactance as float Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de> Signed-off-by: Martin Moraga <martin.moraga@rwth-aachen.de>
initialize parameter 'inertia' of class RotatingMachineDynamics as float Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de> Signed-off-by: Martin Moraga <martin.moraga@rwth-aachen.de>
bc81cc6
to
6c33b53
Compare
Quality Gate passedIssues Measures |
@m-mirz Done! But the pipeline fails now with the error:
|
Okay, thats my fault. Sorry I will have a look |
Depends on cimgen pull request: sogno-platform/cimgen#35, which is already merged now. In my repo all workflows run successfully: tom-hg57#1 (even deploying of github-pages). Improve cimexport.py using profile URIs (from new generated CGMESProfile.py) in model description of exported cim files - Update generated python files created by cimgen - Use profile URIs (from new generated CGMESProfile.py) in model description of exported cim files - Fix "Package information not found" for EquipmentBoundary and ToplogyBoundary in cim_import() by using new generated CGMESProfile.py - Fix export for data read without profile information - Improve cim_export (activeProfileList is now optional - no activeProfileList means output to all profile files with data) - Add function cim_export_to_string_array - Fix model ID in cim_export (must be unique across all files) - Use recommended class profile from new generated classes (if data is read without profile information, or some objects are added after import) - Improve .github/workflows/test.yaml - Update documentation in cimpy/cimexport.py With the new generated python files created by cimgen the issue #23 is solved. PR #24 could be closed if this PR is merged. The same applies to issue #25 and PR #26.
Issue #23