refactor(experimental): make abort signals mandatory in subscriptions

[steveluscher]

Summary

OK listen. We're all adults here. That being said, not having a strategy for cancelling your RPC subscriptions makes everything really complicated and leaves your code prone to leaks.

AbortSignal is now a mandatory argument to subscribe().

If you really want to launch your subscriptions without any cancellation strategy you can still do this:

rpc
  .slotNotifications()
  .subscribe({ abortSignal: new AbortController().signal });

We won't judge you.

Test Plan

pnpm turbo test:typecheck

[steveluscher]

• refactor(experimental): install the subscription coalescing transport by default #1626
• refactor(experimental): a transport that coalesces multiple subscriptions behind a single subscription #1623
• refactor(experimental): drop messages the moment a socket connection is aborted #1641
• refactor(experimental): extract the request cache logic into a base implementation #1622
• refactor(experimental): make abort signals mandatory in subscriptions #1640 👈
• test: fix tests forward for 1.16.x #1655 : 1 other dependent PR (#1306 )
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite

[buffalojoec]

[steveluscher]

Merge Activity

• Sep 29, 8:26 PM: @steveluscher merged this pull request with Graphite.

[github-actions]

🎉 This PR is included in version 1.78.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.