-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix tests forward for 1.16.x #1655
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on Graphite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot getAccountInfo
.
Heads up they call it size
in this one, not space
.
https://docs.solana.com/api/http#getaccountinfo
Oh, hunh. All the tests passed, so I stopped. Looking… |
Oh dear. Those other tests didn't use |
This is what I was afraid of |
Uh, no really. How do you combine |
You just put the value instead of expect right? Or are you saying for the whole object? |
There's a bug in Jest. I'm working through it. Will have a PR in a bit. |
9e008fd
to
d9d004b
Compare
Crap. Missed the legacy test runner. |
e8a1183
to
d838c45
Compare
d838c45
to
c72a627
Compare
K, the tests passed at long last. I'm going to slam this in so that we can see a few more test runs over time. |
🎉 This PR is included in version 1.78.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Summary
1.16 added a
space
param to gPA and changed an error message. This PR updates the web3.js tests to handle that, and a whole lot more fiddling with object shapes and strictness.NOTE
The really bad thing about this is that when the tests break, you get this inscrutable error from Jest:
I think this is because of the presence of
BigInts
and Jest's inability to…I haven't filed a bug with Jest yet, but the workaround I have is to:
toStrictMatch()
totoMatchObject()
Test Plan
Closes #1634.