refactor(experimental): a transport that coalesces multiple subscriptions behind a single subscription #1623

steveluscher · 2023-09-22T20:43:09Z

Summary

This is a transport that, given two identical subscription requests, will issue the subscription request the first time only, and return a the cached iterator for that request each subsequent time, finally tearing the subscription down when the last consumer aborts.

This means that if you slotSubscribe from 10 places in your app, those will only ever produce one subscription over the RPC and will fan the notifications out to the callers.

Test Plan

cd packages/library
pnpm test:unit:browser
pnpm test:unit:node

steveluscher · 2023-09-22T20:43:19Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite

steveluscher · 2023-09-23T05:34:14Z

Oh wow. This whole stack was braindead. You can't do this work at the connection level. You have to do it at the RPC level.

steveluscher · 2023-09-29T01:07:36Z

OK! This is all fixed up, and I fixed a ton of bugs with the socket transport along the way.

This is ready to review!

steveluscher · 2023-09-29T01:08:12Z

packages/library/src/__tests__/rpc-request-deduplication-test.ts

@@ -55,66 +52,3 @@ describe('getSolanaRpcPayloadDeduplicationKey', () => {
        );
    });
 });
-
-describe('getSolanaRpcSubscriptionPayloadDeduplicationKey', () => {


Didn't end up needing this stuff.

steveluscher · 2023-09-29T01:10:03Z

packages/library/src/rpc-subscription-coalescer.ts

+                                try {
+                                    const iterator = iterable[Symbol.asyncIterator]();
+                                    while (true) {
+                                        const iteratorResult = await Promise.race([iterator.next(), abortPromise]);


This whole thing is mega intense, but it all boils down to this.

Create me a new iterable distinct from all the other ones that share this subscription.

Make it so that each one is abortable separately.

Every pass through the iterator, race the iterator and the abort promise; If the user aborts the subscription, it will return right away without waiting for the next message from the subscription.

Thanks, this was a help actually 😅

…is aborted

…ions behind a single subscription

buffalojoec

buffalojoec · 2023-09-30T18:13:19Z

packages/library/src/rpc-subscription-coalescer.ts

+                                try {
+                                    const iterator = iterable[Symbol.asyncIterator]();
+                                    while (true) {
+                                        const iteratorResult = await Promise.race([iterator.next(), abortPromise]);


Thanks, this was a help actually 😅

steveluscher · 2023-10-03T16:13:57Z

Merge Activity

Oct 3, 12:13 PM: @steveluscher started a stack merge that includes this pull request via Graphite.
Oct 3, 12:14 PM: @steveluscher merged this pull request with Graphite.

github-actions · 2023-10-04T13:26:08Z

🎉 This PR is included in version 1.78.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions · 2023-10-19T08:02:45Z

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

steveluscher mentioned this pull request Sep 22, 2023

refactor(experimental): extract the request cache logic into a base implementation #1622

Merged

steveluscher marked this pull request as draft September 23, 2023 05:35

steveluscher force-pushed the 09-22-refactor_experimental_extract_the_request_cache_logic_into_a_base_implementation branch from f541747 to 7b7d498 Compare September 23, 2023 07:58

steveluscher force-pushed the 09-22-refactor_experimental_a_transport_that_coalesces_multiple_subscriptions_behind_a_single_subscription branch from a95a4f6 to b5ebb78 Compare September 23, 2023 07:58

steveluscher force-pushed the 09-22-refactor_experimental_extract_the_request_cache_logic_into_a_base_implementation branch from 7b7d498 to 9df9187 Compare September 29, 2023 01:02

steveluscher force-pushed the 09-22-refactor_experimental_a_transport_that_coalesces_multiple_subscriptions_behind_a_single_subscription branch from b5ebb78 to f68a7a1 Compare September 29, 2023 01:02

This was referenced Sep 29, 2023

refactor(experimental): make abort signals mandatory in subscriptions #1640

Merged

refactor(experimental): drop messages the moment a socket connection is aborted #1641

Merged

steveluscher requested review from buffalojoec and mcintyre94 September 29, 2023 01:07

steveluscher commented Sep 29, 2023

View reviewed changes

steveluscher marked this pull request as ready for review September 29, 2023 01:14

steveluscher force-pushed the 09-22-refactor_experimental_extract_the_request_cache_logic_into_a_base_implementation branch from 9df9187 to 61bc3ba Compare September 29, 2023 18:45

steveluscher force-pushed the 09-22-refactor_experimental_a_transport_that_coalesces_multiple_subscriptions_behind_a_single_subscription branch from f68a7a1 to e2f215f Compare September 29, 2023 18:46

This was referenced Sep 29, 2023

test: fix tests forward for 1.16.x #1655

Merged

fix: update the size of vote accounts after the activation of feature 7axKe5BTYBDD87ftzWbk5DfzWMGyRvqmWTduuo22Yaqy #1306

Merged

steveluscher force-pushed the 09-22-refactor_experimental_extract_the_request_cache_logic_into_a_base_implementation branch from 61bc3ba to ccfbd70 Compare September 29, 2023 21:37

steveluscher force-pushed the 09-22-refactor_experimental_a_transport_that_coalesces_multiple_subscriptions_behind_a_single_subscription branch from e2f215f to 256e002 Compare September 29, 2023 21:37

steveluscher force-pushed the 09-22-refactor_experimental_extract_the_request_cache_logic_into_a_base_implementation branch from ccfbd70 to 7c09215 Compare September 29, 2023 22:45

steveluscher force-pushed the 09-22-refactor_experimental_a_transport_that_coalesces_multiple_subscriptions_behind_a_single_subscription branch from 256e002 to c80a372 Compare September 29, 2023 22:45

steveluscher force-pushed the 09-22-refactor_experimental_extract_the_request_cache_logic_into_a_base_implementation branch from 7c09215 to b072aae Compare September 29, 2023 22:51

steveluscher force-pushed the 09-22-refactor_experimental_a_transport_that_coalesces_multiple_subscriptions_behind_a_single_subscription branch from c80a372 to 0fc0266 Compare September 29, 2023 22:51

steveluscher force-pushed the 09-22-refactor_experimental_extract_the_request_cache_logic_into_a_base_implementation branch from b072aae to ec57cab Compare September 29, 2023 23:13

steveluscher force-pushed the 09-22-refactor_experimental_a_transport_that_coalesces_multiple_subscriptions_behind_a_single_subscription branch from 0fc0266 to 39de3f2 Compare September 29, 2023 23:13

steveluscher force-pushed the 09-22-refactor_experimental_extract_the_request_cache_logic_into_a_base_implementation branch from ec57cab to 38ab0c7 Compare September 29, 2023 23:27

steveluscher force-pushed the 09-22-refactor_experimental_a_transport_that_coalesces_multiple_subscriptions_behind_a_single_subscription branch from 39de3f2 to c913f59 Compare September 29, 2023 23:27

steveluscher force-pushed the 09-22-refactor_experimental_extract_the_request_cache_logic_into_a_base_implementation branch from 38ab0c7 to 31a626e Compare September 29, 2023 23:34

steveluscher force-pushed the 09-22-refactor_experimental_a_transport_that_coalesces_multiple_subscriptions_behind_a_single_subscription branch from c913f59 to 6ccb70f Compare September 29, 2023 23:34

steveluscher force-pushed the 09-22-refactor_experimental_extract_the_request_cache_logic_into_a_base_implementation branch from 31a626e to d6d8690 Compare September 30, 2023 00:22

steveluscher changed the base branch from 09-22-refactor_experimental_extract_the_request_cache_logic_into_a_base_implementation to 09-28-refactor_experimental_drop_messages_the_moment_a_socket_connection_is_aborted September 30, 2023 00:22

steveluscher force-pushed the 09-22-refactor_experimental_a_transport_that_coalesces_multiple_subscriptions_behind_a_single_subscription branch from 6ccb70f to e2bdaf6 Compare September 30, 2023 00:22

refactor(experimental): drop messages the moment a socket connection …

8698f76

…is aborted

steveluscher force-pushed the 09-28-refactor_experimental_drop_messages_the_moment_a_socket_connection_is_aborted branch from 2e69790 to 8698f76 Compare September 30, 2023 00:56

steveluscher force-pushed the 09-22-refactor_experimental_a_transport_that_coalesces_multiple_subscriptions_behind_a_single_subscription branch from e2bdaf6 to 64f33e9 Compare September 30, 2023 00:56

refactor(experimental): a transport that coalesces multiple subscript…

bd8d5b4

…ions behind a single subscription

steveluscher force-pushed the 09-22-refactor_experimental_a_transport_that_coalesces_multiple_subscriptions_behind_a_single_subscription branch from 64f33e9 to bd8d5b4 Compare September 30, 2023 00:58

buffalojoec approved these changes Sep 30, 2023

View reviewed changes

Base automatically changed from 09-28-refactor_experimental_drop_messages_the_moment_a_socket_connection_is_aborted to master October 3, 2023 16:14

steveluscher merged commit 556b856 into master Oct 3, 2023
2 checks passed

steveluscher deleted the 09-22-refactor_experimental_a_transport_that_coalesces_multiple_subscriptions_behind_a_single_subscription branch October 3, 2023 16:14

github-actions bot added the released label Oct 4, 2023

github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(experimental): a transport that coalesces multiple subscriptions behind a single subscription #1623

refactor(experimental): a transport that coalesces multiple subscriptions behind a single subscription #1623

steveluscher commented Sep 22, 2023

steveluscher commented Sep 22, 2023 •

edited

Loading

steveluscher commented Sep 23, 2023

steveluscher commented Sep 29, 2023

steveluscher Sep 29, 2023

steveluscher Sep 29, 2023

buffalojoec Sep 30, 2023

buffalojoec left a comment

buffalojoec Sep 30, 2023

steveluscher commented Oct 3, 2023 •

edited

Loading

github-actions bot commented Oct 4, 2023

github-actions bot commented Oct 19, 2023

refactor(experimental): a transport that coalesces multiple subscriptions behind a single subscription #1623

refactor(experimental): a transport that coalesces multiple subscriptions behind a single subscription #1623

Conversation

steveluscher commented Sep 22, 2023

Summary

Test Plan

steveluscher commented Sep 22, 2023 • edited Loading

steveluscher commented Sep 23, 2023

steveluscher commented Sep 29, 2023

steveluscher Sep 29, 2023

Choose a reason for hiding this comment

steveluscher Sep 29, 2023

Choose a reason for hiding this comment

buffalojoec Sep 30, 2023

Choose a reason for hiding this comment

buffalojoec left a comment

Choose a reason for hiding this comment

buffalojoec Sep 30, 2023

Choose a reason for hiding this comment

steveluscher commented Oct 3, 2023 • edited Loading

Merge Activity

github-actions bot commented Oct 4, 2023

github-actions bot commented Oct 19, 2023

steveluscher commented Sep 22, 2023 •

edited

Loading

steveluscher commented Oct 3, 2023 •

edited

Loading