[bgp] Add design doc for explicitly configuring BGP router id #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blueve
reviewed
Mar 27, 2024
Blueve
reviewed
Mar 27, 2024
Blueve
reviewed
Mar 27, 2024
Blueve
reviewed
Mar 27, 2024
Blueve
reviewed
Mar 27, 2024
Blueve
reviewed
Mar 27, 2024
yaqiangz
force-pushed
the
master_bgp_router_id
branch
5 times, most recently
from
aad6148 to
1824a5e
Compare
yaqiangz
force-pushed
the
master_bgp_router_id
branch
from
1824a5e to
aea7fd2
Compare
yaqiangz
changed the title
Blueve
reviewed
Mar 29, 2024
Blueve
reviewed
Mar 29, 2024
yaqiangz
force-pushed
the
master_bgp_router_id
branch
4 times, most recently
from
851d877 to
5cde85d
Compare
yaqiangz
force-pushed
the
master_bgp_router_id
branch
from
5cde85d to
26cb295
Compare
Blueve
previously approved these changes
Mar 29, 2024
prsunny
reviewed
Mar 29, 2024
qiluo-msft
reviewed
Apr 2, 2024
qiluo-msft
reviewed
Apr 2, 2024
qiluo-msft
reviewed
Apr 2, 2024
yaqiangz
force-pushed
the
master_bgp_router_id
branch
4 times, most recently
from
3d59ad5 to
56c985d
Compare
yaqiangz
force-pushed
the
master_bgp_router_id
branch
from
56c985d to
0fe3009
Compare
Merged
11 tasks
Blueve
previously approved these changes
Apr 17, 2024
Blueve
approved these changes
Apr 23, 2024
Blueve
previously approved these changes
Apr 23, 2024
Blueve
approved these changes
Apr 23, 2024
qiluo-msft
approved these changes
Apr 24, 2024
11 tasks
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
May 13, 2024
…e device (#18727) HLD: sonic-net/SONiC#1643 Add support to explictly specify bgp router id for single asic device Microsoft ADO (number only): 27674485 How I did it 1. When bgp_router_id configured in DEVICE_METADATA, use it as bgp router-id. 2. Remove the hard dependency on loopback0 ipv4 address when adding bgp peer. 3. Add UTs. Behavior of set bgp router-id To be clarified that when bgp router-id hasn't been explicitly set, bgp actions would totally like previous Loopback0 IPv4 address exists Loopback0 IPv4 address doesn't exist bgp_router_id configured Honor bgp_router_id Honor bgp_router_id bgp_router_id not confgd Honor Loopback0 IPv4 address FRR default router ID value is selected as the largest IP address of the device. When router zebra is not enabled bgpd can’t get interface information, so router-id is set to 0.0.0.0 Behavior of add bgp peer To be clarified that when bgp router-id hasn't been explicitly set, bgp actions would totally like previous Loopback0 IPv4 address exists Loopback0 IPv4 address doesn't exist bgp_router_id configured Add BGP peer Add BGP peer bgp_router_id not configured Add BGP peer Do not add BGP peer
StormLiangMS
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
May 16, 2024
Why I did it HLD: sonic-net/SONiC#1643 Remove hard coupling between bgp router-id and IPv4 address of Loopback4096 Add support to explictly specify bgp router id for multi asic device Work item tracking Microsoft ADO (number only): 27801007 How I did it When bgp_router_id configured in DEVICE_METADATA, use it as bgp router-id and originator-id. Remove the hard dependency on loopback4096 ipv4 address when adding ibgp peer. Add UTs. Behavior of set bgp router-id To be clarified that when bgp router-id hasn't been explicitly set, bgp actions would totally like previous Loopback4096 IPv4 address exists Loopback4096 IPv4 address doesn't exist bgp_router_id configured Honor bgp_router_id Honor bgp_router_id bgp_router_id doesn't be configured Honor Loopback4096 IPv4 address FRR default router ID value is selected as the largest IP address of the device. When router zebra is not enabled bgpd can’t get interface information, so router-id is set to 0.0.0.0 Behavior of add bgp peer To be clarified that when bgp router-id hasn't been explicitly set, bgp actions would totally like previous Loopback4096 IPv4 address exists Loopback4096 IPv4 address doesn't exist bgp_router_id configured Add BGP peer Add BGP peer bgp_router_id doesn't be configured Add BGP peer Do not add iBGP peer How to verify it UT passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document describes the design details of explicitly configuring BGP router id in SONiC.