[bgp] Add explictly configure bgp router id for multi-asic #18764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yaqiangz PR: #18764 is conflict with MS internal repo |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yaqiangz
force-pushed
the
master_bgp_router_id_multiasic
branch
from
e97714b
to
c4ce9a8
Compare
This reverts commit f87aefa.
yaqiangz
force-pushed
the
master_bgp_router_id_multiasic
branch
from
c4ce9a8
to
656dd5a
Compare
yaqiangz
force-pushed
the
master_bgp_router_id_multiasic
branch
from
58304af
to
ecdbf44
Compare
|
@StormLiangMS Could you please help to review this PR? |
|
Hi @abdosi could you please help to review this PR? |
abdosi
reviewed
May 11, 2024
yaqiangz
force-pushed
the
master_bgp_router_id_multiasic
branch
from
68f1d81
to
d5e07d4
Compare
abdosi
approved these changes
May 16, 2024
11 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
May 28, 2024
Why I did it These 2 dependencies were removed by #18764 and #18727 for decoupling hard dependency between Loopback IPv4 address and BGP. Actually, these dependencies are to make sure existence of Loopback interface, no need to remove. Work item tracking Microsoft ADO (number only): 28210625 How I did it Add dependency back How to verify it UT passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
HLD: sonic-net/SONiC#1643
Remove hard coupling between bgp router-id and IPv4 address of Loopback4096
Add support to explictly specify bgp router id for multi asic device
Work item tracking
How I did it
When bgp_router_id configured in DEVICE_METADATA, use it as bgp router-id and originator-id.
Remove the hard dependency on loopback4096 ipv4 address when adding ibgp peer.
Add UTs.
Behavior of set bgp router-id
To be clarified that when bgp router-id hasn't been explicitly set, bgp actions would totally like previous
Behavior of add bgp peer
To be clarified that when bgp router-id hasn't been explicitly set, bgp actions would totally like previous
How to verify it
UT passed.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)