You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HLD: sonic-net/SONiC#1643
Add support to explictly specify bgp router id for single asic device
Work item tracking
Microsoft ADO (number only): 27674485
How I did it
When bgp_router_id configured in DEVICE_METADATA, use it as bgp router-id.
Remove the hard dependency on loopback0 ipv4 address when adding bgp peer.
Add UTs.
Behavior of set bgp router-id
To be clarified that when bgp router-id hasn't been explicitly set, bgp actions would totally like previous
Loopback0 IPv4 address exists
Loopback0 IPv4 address doesn't exist
bgp_router_id configured
Honor bgp_router_id
Honor bgp_router_id
bgp_router_id doesn't be configured
Honor Loopback0 IPv4 address
FRR default router ID value is selected as the largest IP address of the device. When router zebra is not enabled bgpd can’t get interface information, so router-id is set to 0.0.0.0
Behavior of add bgp peer
To be clarified that when bgp router-id hasn't been explicitly set, bgp actions would totally like previous
Loopback0 IPv4 address exists
Loopback0 IPv4 address doesn't exist
bgp_router_id configured
Add BGP peer
Add BGP peer
bgp_router_id doesn't be configured
Add BGP peer
Do not add BGP peer
How to verify it
UT passed.
Run bgp related test in sonic-mgmt
Which release branch to backport (provide reason below if selected)
201811
201911
202006
202012
202106
202111
202205
202211
202305
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)
yaqiangz
changed the title
[bgp] Add support to explictly specify bgp router id for single asice device
[bgp] Add support to explicitly specify bgp router id for single asice device
Apr 25, 2024
first one is a question, what's the issue this design is to address? To avoid bgp breakage due to the loopback0 ip is not configured? What's the use case? @yaqiangz Why we assume loopback0 ip is not configured, but bgp_router_id is configured?
first one is a question, what's the issue this design is to address? To avoid bgp breakage due to the loopback0 ip is not configured? What's the use case? @yaqiangz Why we assume loopback0 ip is not configured, but bgp_router_id is configured?
As HLD said, we want to remove the strong coupling of configuring router id and Loopback ipv4 address.
Why I did it
These 2 dependencies were removed by #18764 and #18727 for decoupling hard dependency between Loopback IPv4 address and BGP.
Actually, these dependencies are to make sure existence of Loopback interface, no need to remove.
Work item tracking
Microsoft ADO (number only): 28210625
How I did it
Add dependency back
How to verify it
UT passed.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yaqiangz
force-pushed
the
master_bgp_router_id
branch
from
Why I did it
HLD: sonic-net/SONiC#1643
Add support to explictly specify bgp router id for single asic device
Work item tracking
How I did it
Behavior of set bgp router-id
To be clarified that when bgp router-id hasn't been explicitly set, bgp actions would totally like previous
Behavior of add bgp peer
To be clarified that when bgp router-id hasn't been explicitly set, bgp actions would totally like previous
How to verify it
UT passed.
Run bgp related test in sonic-mgmt
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)