Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acl-loader incremental update overwrites previously loaded ACL rules #2509

Closed
wangxin opened this issue Jan 31, 2019 · 1 comment
Closed

acl-loader incremental update overwrites previously loaded ACL rules #2509

wangxin opened this issue Jan 31, 2019 · 1 comment

Comments

@wangxin
Copy link
Contributor

wangxin commented Jan 31, 2019

Description

If add ACL rules using "config acl update incremental" command, the previously added ACL rules are overwritten.

Adding ACL rules using command "acl-loader update increment" has the same issue.

Steps to reproduce the issue:

  1. Create two json files. File1 conatins ACL rules 1,2,3,4,13,14. File2 contains ACL rules 5-12, 15-26.
  2. Use "config acl update incremental file1.json" to add first part of the ACL rules. Use "show acl rule" to check the added rules.
  3. Use "config acl update incremental file2.json" to add rest of the ACL rules.
  4. Use "show acl rule" to list the added ACL rules. The rules added in step 2 are gone. Only ACL rules added in step 3 are listed.

Describe the results you received:
The incremental update always overwrites all the existing ACL rules.

Describe the results you expected:
I expected the incremental updating to merge the two configurations. In case of conflicts, the later configuration overrides previous configuration.

Additional information you deem important (e.g. issue happens only occasionally):

**Output of `show version`:**

```

$ show version
SONiC Software Version: SONiC.HEAD.868-39b60d2
Distribution: Debian 9.7
Kernel: 4.9.0-8-2-amd64
Build commit: 39b60d2
Build date: Tue Jan 29 19:54:09 UTC 2019
Built by: johnar@jenkins-worker-3
```

**Attach debug file `sudo generate_dump`:**

```
(paste your output here)
```

acl_rules_part1.json.txt
acl_rules_part2.json.txt
syslog_acl-loader.txt
@lguohan
Copy link
Collaborator

lguohan commented Feb 7, 2019

it is by design. https://github.com/Azure/SONiC/wiki/ACL-Configuration-High-Level-Design

@lguohan lguohan closed this as completed Feb 7, 2019
stephenxs added a commit to stephenxs/sonic-buildimage that referenced this issue Nov 22, 2022
@stephenxs
Update submodule sonic-utilities
c416808 
72b9cf9 [psushow & psuutil] Support PSU power threshold checking (sonic-net#2326)
dfdc92e Revert "Support the bandit check by GitHub Action (sonic-net#2358)" (sonic-net#2509)
85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (sonic-net#2481)
da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (#
ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
prgeor pushed a commit that referenced this issue Nov 23, 2022
@stephenxs
[submodule] Advance sonic-utilities and sonic-platform-common pointers (
faef4c6 
#12791)

* Update submodule sonic-utilities

72b9cf9 [psushow & psuutil] Support PSU power threshold checking (#2326)
dfdc92e Revert "Support the bandit check by GitHub Action (#2358)" (#2509)
85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (#2481)
da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (#
ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (#2491)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-daemons

ed818f8 [PSU daemon] Support PSU power threshold checking (#288)
707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (#311)
e8c5657 [ycabled] fix exception-handling logic for ycabled (#306)
905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (#303)
510d330 Fix typo in xcvrd (#313)
9ae551f [ycabled] add support for detach mode in 'active-active' topology (#309)
82fc7a6 Added filtering logic to send filtered fields from DB event (#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (#308)
4ea12cf Fix xcvrd to support 400G ZR optic (#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling (#302)
501abb2 [ycabled] add some exception catching logic to some vendor specific API's (#301)
534f839 [ycabled] add support for getting grpc secerts via shared file (#298)
3622aac Remove shell=True (#300)
143422b add support to execute new ycable API's, add datetime field to mux_info (#297)
6522c46 [ycabled] add notification for gRPC connection state transitions to  IDLE/TRANSIENT_FAILURE (#295)
4b3b238 Install libyang to azure pipeline (#292)
8ff5f37 Use get() to fetch default value from dictionary for port admin_status #286
b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (#287)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-common

7c48be2 Add warning/critical thresholds for PSU power (#304)
f5ba0d0 Add missing PM and VDM related EEPROM read (#326)
02dd597 implement CMIS set_laser_freq to support 100GHz grid space (#294)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Revert "Update submodule sonic-platform-daemons"

This reverts commit aea648b.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
StormLiangMS pushed a commit to StormLiangMS/sonic-buildimage that referenced this issue Dec 8, 2022
@stephenxs @StormLiangMS
[submodule] Advance sonic-utilities and sonic-platform-common pointers (
a87a608 
sonic-net#12791)

* Update submodule sonic-utilities

72b9cf9 [psushow & psuutil] Support PSU power threshold checking (sonic-net#2326)
dfdc92e Revert "Support the bandit check by GitHub Action (sonic-net#2358)" (sonic-net#2509)
85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (sonic-net#2481)
da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (#
ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-daemons

ed818f8 [PSU daemon] Support PSU power threshold checking (sonic-net#288)
707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (sonic-net#311)
e8c5657 [ycabled] fix exception-handling logic for ycabled (sonic-net#306)
905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#303)
510d330 Fix typo in xcvrd (sonic-net#313)
9ae551f [ycabled] add support for detach mode in 'active-active' topology (sonic-net#309)
82fc7a6 Added filtering logic to send filtered fields from DB event (sonic-net#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (sonic-net#308)
4ea12cf Fix xcvrd to support 400G ZR optic (sonic-net#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling (sonic-net#302)
501abb2 [ycabled] add some exception catching logic to some vendor specific API's (sonic-net#301)
534f839 [ycabled] add support for getting grpc secerts via shared file (sonic-net#298)
3622aac Remove shell=True (sonic-net#300)
143422b add support to execute new ycable API's, add datetime field to mux_info (sonic-net#297)
6522c46 [ycabled] add notification for gRPC connection state transitions to  IDLE/TRANSIENT_FAILURE (sonic-net#295)
4b3b238 Install libyang to azure pipeline (sonic-net#292)
8ff5f37 Use get() to fetch default value from dictionary for port admin_status sonic-net#286
b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (sonic-net#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (sonic-net#287)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-common

7c48be2 Add warning/critical thresholds for PSU power (sonic-net#304)
f5ba0d0 Add missing PM and VDM related EEPROM read (sonic-net#326)
02dd597 implement CMIS set_laser_freq to support 100GHz grid space (sonic-net#294)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Revert "Update submodule sonic-platform-daemons"

This reverts commit aea648b.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
StormLiangMS pushed a commit that referenced this issue Dec 10, 2022
@stephenxs @StormLiangMS
[submodule] Advance sonic-utilities and sonic-platform-common pointers (
a338427 
#12791)

* Update submodule sonic-utilities

72b9cf9 [psushow & psuutil] Support PSU power threshold checking (#2326)
dfdc92e Revert "Support the bandit check by GitHub Action (#2358)" (#2509)
85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (#2481)
da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (#
ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (#2491)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-daemons

ed818f8 [PSU daemon] Support PSU power threshold checking (#288)
707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (#311)
e8c5657 [ycabled] fix exception-handling logic for ycabled (#306)
905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (#303)
510d330 Fix typo in xcvrd (#313)
9ae551f [ycabled] add support for detach mode in 'active-active' topology (#309)
82fc7a6 Added filtering logic to send filtered fields from DB event (#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (#308)
4ea12cf Fix xcvrd to support 400G ZR optic (#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling (#302)
501abb2 [ycabled] add some exception catching logic to some vendor specific API's (#301)
534f839 [ycabled] add support for getting grpc secerts via shared file (#298)
3622aac Remove shell=True (#300)
143422b add support to execute new ycable API's, add datetime field to mux_info (#297)
6522c46 [ycabled] add notification for gRPC connection state transitions to  IDLE/TRANSIENT_FAILURE (#295)
4b3b238 Install libyang to azure pipeline (#292)
8ff5f37 Use get() to fetch default value from dictionary for port admin_status #286
b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (#287)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-common

7c48be2 Add warning/critical thresholds for PSU power (#304)
f5ba0d0 Add missing PM and VDM related EEPROM read (#326)
02dd597 implement CMIS set_laser_freq to support 100GHz grid space (#294)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Revert "Update submodule sonic-platform-daemons"

This reverts commit aea648b.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wangxin @lguohan