set cable length to 1m for backplane ports #13572
Conversation
Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
|
@lguohan There is 1 workflow awaiting approval, could you help approve it? |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 13572 in repo sonic-net/sonic-buildimage |
|
@lguohan There is 1 workflow awaiting approval, could you help approve it? |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 13572 in repo sonic-net/sonic-buildimage |
|
The failure is rsyslogd restart error: Change cable length should not have any impact on it. @gechiang Could you help run the pipeline again? |
|
why no unit test added for this case? |
@lguohan To render buffer template, it requires minigraph, device/vendor/platform/hwsku/, there is no such directory and files for vendor cisco, and the change here is for cisco specific backplane interface name "Ethernet-BPxxx", so can't add UT for it. I had verified the change locally, used "sonic-cfggen" to generate buffer config, and verified cable length of backplane ports is 1m, other ports default length. |
Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
|
LGTM. |
|
@rlhui please help merge this. |
Related work items: sonic-net#276, sonic-net#305, sonic-net#332, sonic-net#338, sonic-net#339, sonic-net#1188, sonic-net#1192, sonic-net#1197, sonic-net#1206, sonic-net#1685, sonic-net#1690, sonic-net#1696, sonic-net#1699, sonic-net#1709, sonic-net#1727, sonic-net#1737, sonic-net#1741, sonic-net#1742, sonic-net#2511, sonic-net#2512, sonic-net#2532, sonic-net#2559, sonic-net#2626, sonic-net#2638, sonic-net#2645, sonic-net#2649, sonic-net#2660, sonic-net#2669, sonic-net#2670, sonic-net#2678, sonic-net#10084, sonic-net#11442, sonic-net#11873, sonic-net#12047, sonic-net#12110, sonic-net#12207, sonic-net#12529, sonic-net#12678, sonic-net#13235, sonic-net#13287, sonic-net#13372, sonic-net#13395, sonic-net#13456, sonic-net#13497, sonic-net#13522, sonic-net#13545, sonic-net#13547, sonic-net#13552, sonic-net#13569, sonic-net#13572, sonic-net#13578, sonic-net#13591, sonic-net#13611, sonic-net#13647, sonic-net#13649, sonic-net#13660, sonic-net#13710, sonic-net#13716, sonic-net#13724, sonic-net#13726, sonic-net#13732, sonic-net#13735, sonic-net#13739, sonic-net#13757, sonic-net#13786, sonic-net#13792, sonic-net#13800, sonic-net#13801, sonic-net#13802, sonic-net#13805, sonic-net#13806, sonic-net#13812, sonic-net#13814, sonic-net#13822, sonic-net#13831, sonic-net#13834, sonic-net#13847, sonic-net#13870, sonic-net#13882, sonic-net#13884, sonic-net#13885, sonic-net#13894, sonic-net#13895, sonic-net#13926, sonic-net#13932, sonic-net#13935, sonic-net#13942, sonic-net#13951, sonic-net#13953, sonic-net#13964
Signed-off-by: Zhixin Zhu zhixzhu@cisco.com
Why I did it
backplane ports cable length need to be specified.
How I did it
separated handling for the specific port name.
How to verify it
Used "sonic-cfggen" to generate buffer config, and verified cable length of backplane ports is 1m, other ports default length.
Which release branch to backport (provide reason below if selected)
--> This is required for T2.
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)