Add PYTHON3_SWSSCOMMON as build time dependency to Mellanox platform API #13847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liat-grozovik
approved these changes
Feb 20, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 21, 2023
…API (sonic-net#13847) - Why I did it Add PYTHON3_SWSSCOMMON as build time dependency to Mellanox platform API to avoid issue like: 19:34:11 ImportError while loading conftest '/sonic/platform/mellanox/mlnx-platform-api/tests/conftest.py'. 19:34:11 tests/conftest.py:28: in <module> 19:34:11 from sonic_platform import utils 19:34:11 sonic_platform/__init__.py:18: in <module> 19:34:11 from sonic_platform import * 19:34:11 sonic_platform/platform.py:28: in <module> 19:34:11 raise ImportError(str(e) + "- required module not found") 19:34:11 E ImportError: No module named 'swsscommon'- required module not found- required module not found 19:34:11 [ FAIL LOG END ] [ target/python-wheels/bullseye/mlnx_platform_api-1.0-py3-none-any.whl ] The issue only happens when calling below command: make target/python-wheels/bullseye/mlnx_platform_api-1.0-py3-none-any.whl - How I did it Add PYTHON3_SWSSCOMMON as build time dependency to Mellanox platform API - How to verify it Run build
|
Cherry-pick PR to 202205: #13905 |
mssonicbld
added a commit
that referenced
this pull request
Feb 21, 2023
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 23, 2023
…API (sonic-net#13847) - Why I did it Add PYTHON3_SWSSCOMMON as build time dependency to Mellanox platform API to avoid issue like: 19:34:11 ImportError while loading conftest '/sonic/platform/mellanox/mlnx-platform-api/tests/conftest.py'. 19:34:11 tests/conftest.py:28: in <module> 19:34:11 from sonic_platform import utils 19:34:11 sonic_platform/__init__.py:18: in <module> 19:34:11 from sonic_platform import * 19:34:11 sonic_platform/platform.py:28: in <module> 19:34:11 raise ImportError(str(e) + "- required module not found") 19:34:11 E ImportError: No module named 'swsscommon'- required module not found- required module not found 19:34:11 [ FAIL LOG END ] [ target/python-wheels/bullseye/mlnx_platform_api-1.0-py3-none-any.whl ] The issue only happens when calling below command: make target/python-wheels/bullseye/mlnx_platform_api-1.0-py3-none-any.whl - How I did it Add PYTHON3_SWSSCOMMON as build time dependency to Mellanox platform API - How to verify it Run build
|
Cherry-pick PR to 202211: #13959 |
mssonicbld
added a commit
that referenced
this pull request
Feb 23, 2023
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Mar 28, 2023
Related work items: sonic-net#276, sonic-net#305, sonic-net#332, sonic-net#338, sonic-net#339, sonic-net#1188, sonic-net#1192, sonic-net#1197, sonic-net#1206, sonic-net#1685, sonic-net#1690, sonic-net#1696, sonic-net#1699, sonic-net#1709, sonic-net#1727, sonic-net#1737, sonic-net#1741, sonic-net#1742, sonic-net#2511, sonic-net#2512, sonic-net#2532, sonic-net#2559, sonic-net#2626, sonic-net#2638, sonic-net#2645, sonic-net#2649, sonic-net#2660, sonic-net#2669, sonic-net#2670, sonic-net#2678, sonic-net#10084, sonic-net#11442, sonic-net#11873, sonic-net#12047, sonic-net#12110, sonic-net#12207, sonic-net#12529, sonic-net#12678, sonic-net#13235, sonic-net#13287, sonic-net#13372, sonic-net#13395, sonic-net#13456, sonic-net#13497, sonic-net#13522, sonic-net#13545, sonic-net#13547, sonic-net#13552, sonic-net#13569, sonic-net#13572, sonic-net#13578, sonic-net#13591, sonic-net#13611, sonic-net#13647, sonic-net#13649, sonic-net#13660, sonic-net#13710, sonic-net#13716, sonic-net#13724, sonic-net#13726, sonic-net#13732, sonic-net#13735, sonic-net#13739, sonic-net#13757, sonic-net#13786, sonic-net#13792, sonic-net#13800, sonic-net#13801, sonic-net#13802, sonic-net#13805, sonic-net#13806, sonic-net#13812, sonic-net#13814, sonic-net#13822, sonic-net#13831, sonic-net#13834, sonic-net#13847, sonic-net#13870, sonic-net#13882, sonic-net#13884, sonic-net#13885, sonic-net#13894, sonic-net#13895, sonic-net#13926, sonic-net#13932, sonic-net#13935, sonic-net#13942, sonic-net#13951, sonic-net#13953, sonic-net#13964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add PYTHON3_SWSSCOMMON as build time dependency to Mellanox platform API to avoid issue like:
The issue only happens when calling below command:
How I did it
Add PYTHON3_SWSSCOMMON as build time dependency to Mellanox platform API
How to verify it
Run build
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)