[sonic-cfggen] Remove machine.conf info and add get_system_mac support #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Feb 16, 2018
| # Try to take old configuration saved during installation | ||
| if test_config; then | ||
| rm -f /host/old_config/sonic_version.yml | ||
| mv -f /host/old_config/* /etc/sonic/ | ||
| if [ ! -f /etc/sonic/config_db.json ]; then | ||
| sonic-cfggen -m -j /etc/sonic/init_cfg.json --print-data > /etc/sonic/config_db.json | ||
| sonic-cfggen -H -m -j /etc/sonic/init_cfg.json --print-data > /etc/sonic/config_db.json |
There was a problem hiding this comment.
do we still need init_cfg.json? here, what if init_cfg.json does not exist? will it have issue here?
There was a problem hiding this comment.
Thanks for the catch. Fixed in the 2nd iteration.
Please note that this PR does not intent to make any logic change - I will submit a PR later to remove graph-selecting and config-loading logic from rc.local and unify them in update_graph.
lguohan
approved these changes
Feb 20, 2018
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
Jan 14, 2021
sonic-net#1397) * [201911]Handled both REDIRECT and REDIRECT_ACTION ACL rules in ACL orchagent * Fixed the LGTM failure in test_acl.py script Co-authored-by: Madhan Babu <madhan@arc-build-server.mtr.labs.mlnx>
4 tasks
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
… naming mode "alias" sonic-net#1397 (sonic-net#1411) #### What I did Added fix for Issue in CLI output alignment with shorter alias names in intf naming mode "alias" #### How I did it Added code to remove last few extra characters from string (-------…) using Slicing & Positive Indexing in python, to match the width to alias's name(not interface)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
-Hoption insonic-cfggento read platform info and system mac address intoDEVICE_METADATA.rc.local.machine.confis no longer included insonic-cfggenoutput.