-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[installer]: remove single quotes around the value when create machine.conf #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guohan Lu <gulv@microsoft.com>
lguohan
changed the title
remove single quotes around the value when create machine.conf
[installer]: remove single quotes around the value when create machine.conf
Mar 30, 2018
3 tasks
Sabareesh-Kumar-Anandan
pushed a commit
to Sabareesh-Kumar-Anandan/sonic-buildimage
that referenced
this pull request
Dec 20, 2020
[crm]: Typecast to unit64_t to avoid divide by 0 during overflow (sonic-net#1550) [vxlanmgr] Fix build error when compiling for armhf (32-bit) (sonic-net#1552) [Dynamic buffer calc] Support dynamic buffer calculation (sonic-net#1338) [dvs] Clean-up dvs_database and dvs_common (sonic-net#1541) [VxlanMgr] changes for EVPN VXLAN (sonic-net#1266) Statistics support for Tx and Rx counters of different frame sizes (sonic-net#1536) [orchagent/phy]: Add firmware info propagation (sonic-net#1540) Signed-off-by: Sabareesh Kumar Anandan <sanandan@marvell.com>
jleveque
added a commit
that referenced
this pull request
Dec 24, 2020
* src/sonic-swss c7ee75f...cadf28f (24): > Revert "Add support for headroom pool watermark (#1453)" > [VxlanOrch] pytest for EVPN VXLAN (#1318) > [restore_neighbors] python3 support for restore_neighbors.py (#1542) > [buffermgmt] more build error fixes when compiling for armhf (32-bit) (#1559) > Sflow fix to avoid NULL in field. (#1531) > [fgnhgorch] Fg Nhg link handling (#1537) > [dpb]: make sure port is in admin down state before remove port. (#1513) > [FPMSYNCD/FDBSYNCD] EVPN Type-5 route removing prefix-len for host route and removing junk character present in the mac (#1553) > Added support for EVPN L3 VXLAN as described in the PR sonic-net/SONiC#437 (#1267) > [crm]: Typecast to unit64_t to avoid divide by 0 during overflow (#1550) > [vxlanmgr] Fix build error when compiling for armhf (32-bit) (#1552) > [Dynamic buffer calc] Support dynamic buffer calculation (#1338) > [dvs] Clean-up dvs_database and dvs_common (#1541) > [VxlanMgr] changes for EVPN VXLAN (#1266) > Statistics support for Tx and Rx counters of different frame sizes (#1536) > [orchagent/phy]: Add firmware info propagation (#1540) > [vxlanorch] Use PRI instead of %l to avoid warnings in 32-bit arch (#1539) > [FDBSYNCD] Added support for EVPN as described in the PR sonic-net/SONiC#437 (#1276) > [everflow] Add retry mechanism for mirror sessions and policers (#1486) > Enable ACL table type mirror_v6 for Innovium Platform (#1527) > [fgnhgorch] Change format specifier %lu to %zu for size_t (#1529) > [dvs] Fix issue where concurrent netns operations cause test setup to fail (#1535) > Add support for headroom pool watermark (#1453) > Change gAsicInstance to type string with max length limit (#1526)
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Apr 9, 2021
Utilities: * c96f19d 2021-04-08 | [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (sonic-net#1552) (HEAD -> 201811, github/201811) [Sumukha Tumkur Vani] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Apr 10, 2021
Utilities: * c96f19d 2021-04-08 | [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (#1552) (HEAD -> 201811, github/201811) [Sumukha Tumkur Vani] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
daall
added a commit
to daall/sonic-buildimage
that referenced
this pull request
Apr 13, 2021
sonic-swss * Don't update pools when ingress_lossless_pool is created but the initialization hasn't finished yet (sonic-net#1685) * Fix dynamic buffer bug occuring in rare condition (sonic-net#1678) sonic-utilities * [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (sonic-net#1552) Signed-off-by: Danny Allen <daall@microsoft.com>
4 tasks
daall
added a commit
that referenced
this pull request
Apr 14, 2021
…7313) sonic-swss * Don't update pools when ingress_lossless_pool is created but the initialization hasn't finished yet (#1685) * Fix dynamic buffer bug occuring in rare condition (#1678) sonic-utilities * [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (#1552) Signed-off-by: Danny Allen <daall@microsoft.com>
renukamanavalan
added a commit
to renukamanavalan/sonic-buildimage
that referenced
this pull request
Apr 26, 2021
* 9dba93f disk_check: Check & mount RO as RW using tmpfs (sonic-net#1569) * c3963c5 Fix remove ip rif (sonic-net#1535) * 41d8ddc [config][generic-update] Adding apply-patch, rollback, checkpoints commands (sonic-net#1536) * a3d37f1 [console] Display success message after line cleared (sonic-net#1579) * b10c157 RADIUS Management User Authentication Feature (sonic-net#1521) * 59ed6f3 platform pre-check for reboot in master branch (sonic-net#1556) * f5efe89 [acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1519) * e296a69 No more IP validation as it is more likely a URL (sonic-net#1555) * d5f5382 [CLI][queue counters] add JSON output option for queue counters (sonic-net#1505) * 176cc4a 1) Loopback interfaces with valid nexthop IP are not ignored/treated as loopback. (sonic-net#1565) * 149ccbd [techsupport] Update show ip interface command (sonic-net#1562) * 0e84418 Stop PMON docker before cold and soft reboots (sonic-net#1514) * eba5c04 Fix Multi-ASIC show specific resursive route by using common parsing function (sonic-net#1560) * e57e7f7 cache the bvid to vlan translations (sonic-net#1523) * 38f9f60 sonic-installer: fix py3 issues in bootloader.aboot (sonic-net#1553) * 02b263a [voq/inbandif] Voq inbandif port (sonic-net#1363) * 0539789 [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (sonic-net#1552) * 030293c Use 'importlib' module in lieu of deprecated 'imp' module (sonic-net#1450) * 50e5c61 Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551)
4 tasks
lguohan
pushed a commit
that referenced
this pull request
Apr 27, 2021
* 9dba93f disk_check: Check & mount RO as RW using tmpfs (#1569) * c3963c5 Fix remove ip rif (#1535) * 41d8ddc [config][generic-update] Adding apply-patch, rollback, checkpoints commands (#1536) * a3d37f1 [console] Display success message after line cleared (#1579) * b10c157 RADIUS Management User Authentication Feature (#1521) * 59ed6f3 platform pre-check for reboot in master branch (#1556) * f5efe89 [acl] Use a list instead of a comma-separated string for ACL port list (#1519) * e296a69 No more IP validation as it is more likely a URL (#1555) * d5f5382 [CLI][queue counters] add JSON output option for queue counters (#1505) * 176cc4a 1) Loopback interfaces with valid nexthop IP are not ignored/treated as loopback. (#1565) * 149ccbd [techsupport] Update show ip interface command (#1562) * 0e84418 Stop PMON docker before cold and soft reboots (#1514) * eba5c04 Fix Multi-ASIC show specific resursive route by using common parsing function (#1560) * e57e7f7 cache the bvid to vlan translations (#1523) * 38f9f60 sonic-installer: fix py3 issues in bootloader.aboot (#1553) * 02b263a [voq/inbandif] Voq inbandif port (#1363) * 0539789 [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (#1552) * 030293c Use 'importlib' module in lieu of deprecated 'imp' module (#1450) * 50e5c61 Fixed the possibility of using uninitialized variable in route_check.py (#1551)
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
* 9dba93f disk_check: Check & mount RO as RW using tmpfs (sonic-net#1569) * c3963c5 Fix remove ip rif (sonic-net#1535) * 41d8ddc [config][generic-update] Adding apply-patch, rollback, checkpoints commands (sonic-net#1536) * a3d37f1 [console] Display success message after line cleared (sonic-net#1579) * b10c157 RADIUS Management User Authentication Feature (sonic-net#1521) * 59ed6f3 platform pre-check for reboot in master branch (sonic-net#1556) * f5efe89 [acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1519) * e296a69 No more IP validation as it is more likely a URL (sonic-net#1555) * d5f5382 [CLI][queue counters] add JSON output option for queue counters (sonic-net#1505) * 176cc4a 1) Loopback interfaces with valid nexthop IP are not ignored/treated as loopback. (sonic-net#1565) * 149ccbd [techsupport] Update show ip interface command (sonic-net#1562) * 0e84418 Stop PMON docker before cold and soft reboots (sonic-net#1514) * eba5c04 Fix Multi-ASIC show specific resursive route by using common parsing function (sonic-net#1560) * e57e7f7 cache the bvid to vlan translations (sonic-net#1523) * 38f9f60 sonic-installer: fix py3 issues in bootloader.aboot (sonic-net#1553) * 02b263a [voq/inbandif] Voq inbandif port (sonic-net#1363) * 0539789 [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (sonic-net#1552) * 030293c Use 'importlib' module in lieu of deprecated 'imp' module (sonic-net#1450) * 50e5c61 Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551)
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
* 9dba93f disk_check: Check & mount RO as RW using tmpfs (sonic-net#1569) * c3963c5 Fix remove ip rif (sonic-net#1535) * 41d8ddc [config][generic-update] Adding apply-patch, rollback, checkpoints commands (sonic-net#1536) * a3d37f1 [console] Display success message after line cleared (sonic-net#1579) * b10c157 RADIUS Management User Authentication Feature (sonic-net#1521) * 59ed6f3 platform pre-check for reboot in master branch (sonic-net#1556) * f5efe89 [acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1519) * e296a69 No more IP validation as it is more likely a URL (sonic-net#1555) * d5f5382 [CLI][queue counters] add JSON output option for queue counters (sonic-net#1505) * 176cc4a 1) Loopback interfaces with valid nexthop IP are not ignored/treated as loopback. (sonic-net#1565) * 149ccbd [techsupport] Update show ip interface command (sonic-net#1562) * 0e84418 Stop PMON docker before cold and soft reboots (sonic-net#1514) * eba5c04 Fix Multi-ASIC show specific resursive route by using common parsing function (sonic-net#1560) * e57e7f7 cache the bvid to vlan translations (sonic-net#1523) * 38f9f60 sonic-installer: fix py3 issues in bootloader.aboot (sonic-net#1553) * 02b263a [voq/inbandif] Voq inbandif port (sonic-net#1363) * 0539789 [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (sonic-net#1552) * 030293c Use 'importlib' module in lieu of deprecated 'imp' module (sonic-net#1450) * 50e5c61 Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551)
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
…et#1552) Changed format specifiers from %lu to %zu for size_t to avoid compilation errors in arm 32-bit
7 tasks
richardyu-ms
added a commit
to richardyu-ms/sonic-buildimage
that referenced
this pull request
Aug 29, 2022
update sai module with commit - 566d4a8ef2 2022-08-11 | [SAI-PTF] Enable saiserverv2 with syncd-rpc and fix saithriftv2 build (sonic-net#1552) (sonic-net#1533) (sonic-net#1514) (sonic-net#1492) (sonic-net#1558) (sonic-net#1557) [Richard.Yu] - a1796a53cc 2022-08-11 | Add support of mdio IPC server class using sai switch api and unix socket Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
richardyu-ms
added a commit
that referenced
this pull request
Aug 31, 2022
update sai module with commit - 566d4a8ef2 2022-08-11 | [SAI-PTF] Enable saiserverv2 with syncd-rpc and fix saithriftv2 build (#1552) (#1533) (#1514) (#1492) (#1558) (#1557) [Richard.Yu] - a1796a53cc 2022-08-11 | Add support of mdio IPC server class using sai switch api and unix socket Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guohan Lu gulv@microsoft.com
- What I did
remove single quotes around the value when create machine.conf
- How I did it
- How to verify it
verified by alphanetwork
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)