Fix buffer configurations for 7170 #2972

zzhiyuan · 2019-06-05T18:43:34Z

- What I did
Request from Barefoot to change the buffer configuration for 7170.

- How I did it

- How to verify it
Load 7170 with new image with this change. Interfaces are up.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

lguohan · 2019-06-06T23:19:49Z

device/arista/x86_64-arista_7170_64c/Arista-7170-64C/buffers_defaults_t0.j2

            "pool":"[BUFFER_POOL|ingress_lossless_pool]",
-            "size":"0",
-            "static_th":"11075584"
+            "size":"4096",


why do we change it so small?

ingress lossless profile should have no limit.

When threshold mode dynamic is configured, the above size value is ignored by the barefoot SDK. Buffers are carved out dynamically for the ingress buffers. Same comment applies for egress. So this size value should be ok.

the size here is the reserved buffer for the pg, for lossless traffic, it should be zero.

@zzhiyuan can you change size to 0 and give it a shot? I believe that should work with the SDE. You can reach out to me if you face any issues changing this value to 0

I've changed all the lossless buffer sizes to 0. Thanks

lguohan · 2019-06-06T23:20:15Z

need high level description of why such change.

zzhiyuan · 2019-06-06T23:26:16Z

need high level description of why such change.

The previous buffer configuration was copied from a Broadcom platform. This configuration is for Barefoot, just like in: https://github.com/Azure/sonic-buildimage/blob/master/device/barefoot/x86_64-accton_wedge100bf_65x-r0/mavericks/buffers_defaults_t0.j2

lguohan · 2019-06-06T23:46:32Z

the egress_lossless_profile does not seem to be correct.

NStetskovych-zz · 2019-06-18T13:01:22Z

@lguohan for t1 qos config is missed in the current image. What actually wrong with egress_lossless_profile?

lguohan · 2019-06-19T08:31:10Z

device/arista/x86_64-arista_7170_64c/Arista-7170-64C/buffers_defaults_t0.j2

@@ -10,37 +14,70 @@
 {%- macro generate_buffer_pool_and_profiles() %}
    "BUFFER_POOL": {
        "ingress_lossless_pool": {
-            "size": "33329088",
+            "size": "{{ ingress_lossless_pool_size }}",


the ingress lossless pool size is changed from 32M -> 4M, why such change. I do not understand the rationale behind this change.

lguohan · 2019-06-19T08:37:33Z

device/arista/x86_64-arista_7170_64c/Arista-7170-64C/buffers_defaults_t0.j2

-            "size":"0",
-            "static_th":"10587408"
+            "size":"4096",
+            "dynamic_th":"7"


we should avoid any egress packet drop for lossless traffic. previously configuration was to avoid any packet drop at egress. I do not think current configuration can guarantee no packet drop at egress for lossless traffic.

lguohan · 2019-06-19T08:37:59Z

@NStetskovych , check my comments.

NStetskovych-zz · 2019-07-17T08:26:41Z

@lguohan is it ok to merge now?

zzhiyuan · 2019-07-23T22:06:21Z

@lguohan

Are there any additional problems with this PR?

Thanks

lguohan · 2019-09-06T18:07:05Z

device/arista/x86_64-arista_7170_64c/Arista-7170-64C/buffers_defaults_t0.j2

            "pool":"[BUFFER_POOL|ingress_lossless_pool]",
            "size":"0",
-            "static_th":"11075584"
+            "dynamic_th":"0"


the dynamic threshold definating is alpha = 2^dynamic_th. If the dynamic_th is zero, then alpha is 1. it does not guarantee lossless behavior by SAI definition.

device/arista/x86_64-arista_7170_64c/Arista-7170-Q59S20/buffers_defaults_t0.j2

device/arista/x86_64-arista_7170_64c/Arista-7170-Q59S20/buffers_defaults_t1.j2

prsunny · 2019-10-01T00:55:57Z

retest vs please

prsunny · 2019-10-01T00:56:13Z

retest vsimage please

zzhiyuan · 2019-10-03T22:12:49Z

retest vsimage please

Hi Sunny, I don't have access to msft jenkins to retrigger the build. Can someone from msft do it please? Thanks

wendani · 2019-10-03T22:51:52Z

retest vsimage please

* Update sonic-utilities to master branch version sonic-utilities was (intentionally) pointing to a commit on a fork, since merging sonic-utilities's changes for Bookworm first onto the master branch would result in PR checker failures. Now that sonic-buildimage is on master branch and the Bookworm changes in sonic-utilities have been merged into master, sonic-utilties can now point to master. 17e77fe2 Revert "Run yang validation in unit test (#3025)" (#3055) 96dd5559 [dhcp_relay] Fix dhcp_relay counter display issue (#3054) 6dfeee69 [sflow][db_migrator] Egress Sflow support (#3020) 02a588b7 Don't collect /proc/sched_debug d7ec3251 Fix error about having a mutable default for field headers in dataclass 0ab3ab91 Fix test execution on Bookworm (#3041) ef8f6f83 Specify test dependencies under extra_requires 61c44e80 Update python packages 1e813105 [wol] Implement wol command line utility (#3048) 8ebc56a0 [sonic_installer]: Improve exception handling: introduce notes. (#3029) 3610ce93 [sonic-package-manager] Fix YANG validation failure on upgrade when feature has constraints in YANG model on FEATURE table (#2933) cfd2dd39 Add container rsyslog.conf to the sys dump (#3039) c4b07828 Support new platform in generic configuration update (#3038) a8d236c8 [fast-reboot-filter-routes.py] Remove click and improve error reporting (#3030) 75199c0f [sonic-package-manager] insert newline in /etc/sonic/generated_services.conf (#3040) cd855698 [VOQ][saidump] Modify generate_dump: replace save_saidump with save_saidump_by_route_size (#2972) f1e24ae5 GCU support for Cisco-8000 features (#3010) 67e1c3dc Update GCU rsyslog validator (#3012) 253b7975 [sonic-package-manager] do not modify config_db.json (#3032) 177dd8e8 [sonic-package-manager] add generated service to /etc/sonic/generated_services.conf (#3037) 62fcd77a Configure NTP according to extended configuration (#2835) ced09404 [dualtor_neighbor_check] Adjust zero-mac check condition (#3034) a4eeb698 [config] config reload should generate sysinfo if missing (#3031) e01fc891 Run yang validation in unit test (#3025) Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

…atically (#17457) src/sonic-utilities * 1b1402f5 - (HEAD -> 202311, origin/202311) [hash]: Add ECMP/LAG hash algorithm CLI (#3036) (9 days ago) [Nazarii Hnydyn] * 71514ea3 - Revert "Run yang validation in unit test (#3025)" (#3055) (9 days ago) [Ying Xie] * b5daf5d4 - [dhcp_relay] Fix dhcp_relay counter display issue (#3054) (9 days ago) [Yaqiang Zhu] * b3172505 - [sflow][db_migrator] Egress Sflow support (#3020) (9 days ago) [Rajkumar-Marvell] * 1e813105 - [wol] Implement wol command line utility (#3048) (3 weeks ago) [Zhijian Li] * 8ebc56a0 - [sonic_installer]: Improve exception handling: introduce notes. (#3029) (3 weeks ago) [Nazarii Hnydyn] * 3610ce93 - [sonic-package-manager] Fix YANG validation failure on upgrade when feature has constraints in YANG model on FEATURE table (#2933) (3 weeks ago) [Stepan Blyshchak] * cfd2dd39 - Add container rsyslog.conf to the sys dump (#3039) (4 weeks ago) [Vivek] * c4b07828 - Support new platform in generic configuration update (#3038) (4 weeks ago) [Stephen Sun] * a8d236c8 - [fast-reboot-filter-routes.py] Remove click and improve error reporting (#3030) (4 weeks ago) [Stepan Blyshchak] * 75199c0f - [sonic-package-manager] insert newline in /etc/sonic/generated_services.conf (#3040) (4 weeks ago) [Stepan Blyshchak] * cd855698 - [VOQ][saidump] Modify generate_dump: replace save_saidump with save_saidump_by_route_size (#2972) (4 weeks ago) [JunhongMao] * f1e24ae5 - GCU support for Cisco-8000 features (#3010) (4 weeks ago) [rbpittman] * 67e1c3dc - Update GCU rsyslog validator (#3012) (4 weeks ago) [jingwenxie] * 253b7975 - [sonic-package-manager] do not modify config_db.json (#3032) (5 weeks ago) [Stepan Blyshchak] * 177dd8e8 - [sonic-package-manager] add generated service to /etc/sonic/generated_services.conf (#3037) (5 weeks ago) [Stepan Blyshchak] * 62fcd77a - Configure NTP according to extended configuration (#2835) (5 weeks ago) [Yevhen Fastiuk] * ced09404 - [dualtor_neighbor_check] Adjust zero-mac check condition (#3034) (5 weeks ago) [Longxiang Lyu] * a4eeb698 - [config] config reload should generate sysinfo if missing (#3031) (6 weeks ago) [jingwenxie] * e01fc891 - Run yang validation in unit test (#3025) (6 weeks ago) [ganglv]

…lly (#17501) #### Why I did it src/sonic-swss ``` * ff524e6d - (HEAD -> master, origin/master, origin/HEAD) [dash] add a retry for an ACL rule creation if a tag is not created yet (#2972) (7 hours ago) [Yakiv Huryk] * 620db3da - [ci] Allow partially success build artifact in PR checker pipeline. #2986 (3 days ago) [Liu Shilong] * d357e6f1 - [copporch] Add safeguard during policer attribute update (#2977) (4 days ago) [Vivek] * cb460394 - [fpmsyncd][WR] Relax the static schema constraint for ROUTE_TABLE (#2981) (5 days ago) [Vivek] * a1ce21f6 - Change base directory referenced in coverage.xml (#2976) (6 days ago) [Lawrence Lee] * 920959cf - [Dash] [UT] Add ZMQ test case for dash (#2967) (6 days ago) [Hua Liu] ``` #### How I did it #### How to verify it #### Description for the changelog

jleveque added Enhancement ➕ Platform: Arista Platform: Barefoot labels Jun 5, 2019

lguohan reviewed Jun 6, 2019

View reviewed changes

lguohan reviewed Jun 19, 2019

View reviewed changes

zzhiyuan force-pushed the 7170bufferfix branch from 4079641 to c5a1316 Compare July 4, 2019 20:09

Fix buffer configurations for 7170

0254d50

zzhiyuan force-pushed the 7170bufferfix branch from c5a1316 to 0254d50 Compare July 8, 2019 17:04

lguohan reviewed Sep 6, 2019

View reviewed changes

Adjust buffer configurations for 7170

29237b1

wendani reviewed Sep 24, 2019

View reviewed changes

device/arista/x86_64-arista_7170_64c/Arista-7170-Q59S20/buffers_defaults_t0.j2 Outdated Show resolved Hide resolved

device/arista/x86_64-arista_7170_64c/Arista-7170-Q59S20/buffers_defaults_t1.j2 Outdated Show resolved Hide resolved

Remove ingress lossless profiles for Arista 7170

8466bfb

zzhiyuan force-pushed the 7170bufferfix branch from e790331 to 8466bfb Compare September 25, 2019 17:45

wendani approved these changes Sep 25, 2019

View reviewed changes

Merge branch 'master' into 7170bufferfix

899b4df

yxieca merged commit f3cfa8f into sonic-net:master Oct 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix buffer configurations for 7170 #2972

Fix buffer configurations for 7170 #2972

zzhiyuan commented Jun 5, 2019

lguohan Jun 6, 2019

lguohan Jun 6, 2019

mkbalani Jun 10, 2019

lguohan Jun 19, 2019

mkbalani Jun 26, 2019

zzhiyuan Jul 4, 2019

lguohan commented Jun 6, 2019

zzhiyuan commented Jun 6, 2019

lguohan commented Jun 6, 2019

NStetskovych-zz commented Jun 18, 2019

lguohan Jun 19, 2019

lguohan Jun 19, 2019

lguohan commented Jun 19, 2019

NStetskovych-zz commented Jul 17, 2019

zzhiyuan commented Jul 23, 2019

lguohan Sep 6, 2019

prsunny commented Oct 1, 2019

prsunny commented Oct 1, 2019

zzhiyuan commented Oct 3, 2019

wendani commented Oct 3, 2019

Fix buffer configurations for 7170 #2972

Fix buffer configurations for 7170 #2972

Conversation

zzhiyuan commented Jun 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan commented Jun 6, 2019

zzhiyuan commented Jun 6, 2019

lguohan commented Jun 6, 2019

NStetskovych-zz commented Jun 18, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan commented Jun 19, 2019

NStetskovych-zz commented Jul 17, 2019

zzhiyuan commented Jul 23, 2019

Choose a reason for hiding this comment

prsunny commented Oct 1, 2019

prsunny commented Oct 1, 2019

zzhiyuan commented Oct 3, 2019

wendani commented Oct 3, 2019