Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[device/celestica]: libsensors configuration file for Seastone-DX010 #3664

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

mudsut4ke
Copy link
Contributor

- What I did

  • Update sensor configuration file follow thermal specification document

- How I did it

  1. Update lm75b sensor threshold

- How to verify it

  • Run command sensors under sonic and check lm75b sensor threshold

Signed-off-by: Wirut Getbamrung wgetbumr@celestica.com

@mudsut4ke
Copy link
Contributor Author

@yxieca , this PR refer to sensor alarm issue on Seastone-DX010

@yxieca
Copy link
Contributor

yxieca commented Oct 25, 2019

@mudsut4ke While your change might be addressing other issues. It didn't address the test failure fully. Looks like the ASIC max_hyst is default set to 28 and the temperature reading is 37, which is higher than the max_hyst. Can you propose another change and test it before posting it?

        "temp_reasons": [
            "Alarm on lm75b-i2c-7-4a/ASIC temp sensor/temp1_input"
        ]
        "lm75b-i2c-7-4a": {
            "ASIC temp sensor": {
                "temp1_input": "37.000", 
                "temp1_max": "70.000", 
                "temp1_max_hyst": "28.000"
            }
        }

Copy link
Contributor

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't fully address the observed test failure.

@mudsut4ke
Copy link
Contributor Author

mudsut4ke commented Oct 28, 2019

@yxieca , temp1_max_hyst was set to 28 because of old sensor config,
Anyway I have added 5 °C hysteresis temperature follow default value in lm75 datasheet to avoid the issue.

admin@sonic:~$ sensors -u lm75b-*
lm75b-i2c-14-48
Adapter: i2c-0-mux (chan_id 4)
Rear-panel temp sensor 1:
  temp1_input: 33.250
  temp1_max: 50.000
  temp1_max_hyst: 45.000

lm75b-i2c-6-49
Adapter: i2c-0-mux (chan_id 4)
Front-panel temp1 sensor 2:
  temp1_input: 36.500
  temp1_max: 50.000
  temp1_max_hyst: 45.000

lm75b-i2c-15-4e
Adapter: i2c-0-mux (chan_id 5)
Rear-panel temp1 sensor 2:
  temp1_input: 32.000
  temp1_max: 70.000
  temp1_max_hyst: 65.000

lm75b-i2c-7-4a
Adapter: i2c-0-mux (chan_id 5)
ASIC temp1 sensor:
  temp1_input: 42.875
  temp1_max: 70.000
  temp1_max_hyst: 65.000

lm75b-i2c-5-48
Adapter: i2c-0-mux (chan_id 3)
Rear-panel temp sensor 1:
  temp1_input: 34.000
  temp1_max: 50.000
  temp1_max_hyst: 45.000

admin@sonic:~$ 

@yxieca yxieca merged commit 6eb18ee into sonic-net:201811 Oct 28, 2019
mssonicbld added a commit that referenced this pull request Dec 10, 2024
…atically (#20573)

#### Why I did it
src/sonic-utilities
```
* 32e6de7f - (HEAD -> master, origin/master, origin/HEAD) Update DB migrator script to next branch 202505 (#3664) (3 days ago) [Kumaresh Perumal]
* 8d00aba7 - (origin/test_202411_20, origin/test_202411_100, origin/kperumal_202411, origin/202411) Fix save_file command in generate_dump (#3647) (4 days ago) [DavidZagury]
* 038aaa5f - Revert "Speed up route_check script" (#3653) (4 days ago) [xwjiang-ms]
* 032a0e03 - [config]Restrict YANG validation to Golden Config (#3656) (4 days ago) [jingwenxie]
* 47b79bea - Update gcu_field_operation_validators.conf.json with Arista-7260CX3-D108C10 (#3650) (4 days ago) [Dev Ojha]
* 845f46ef - Update PR checker pipeline to point to bookworm (#3651) (4 days ago) [bingwang-ms]
* 28e645f4 - [show_tech] Filter out a list of commands in generate_dump script which are not applicable to Supervisor (#3646) (5 days ago) [Marty Y. Lok]
* b767cb86 - [cisco|express-boot]: Add support for cisco express boot in sonic-utilities (#3056) (6 days ago) [jhli-cisco]
* f6b9912c - Fix show command column change issue (#3645) (8 days ago) [Feng-msft]
* 9cd6c8de - Debug dump utility dash objects update (#3387) (8 days ago) [Gagan Punathil Ellath]
* f705c456 - Validate interface name length in CLI (#3580) (8 days ago) [Stepan Blyshchak]
* 3d78cb16 - [Mellanox] Update the save_file command in generate_dump to handle folders (#3631) (13 days ago) [DavidZagury]
* 5086a43b - Fix counterpoll show for ENI Counters (#3618) (13 days ago) [Vivek]
* 70f81397 - Extra delay between running firmware and updating firmware version (#3610) (2 weeks ago) [Stephen Sun]
* 636f7f1d - Add port FEC BER show changes (#3607) (2 weeks ago) [vincentpcng]
* 5e60031b - Supports FRR-VRRP configuration (#2949) (3 weeks ago) [Philo]
* 9bd37dc6 - [ARM64][Warm-Reboot]: Get boot arguments from uboot environment (#3613) (3 weeks ago) [Parthiv Shah]
* 171b16c2 - platform/innovium renaming to platform/marvell-teralynx (#3474) (3 weeks ago) [krismarvell]
* 2cbfcc91 - [Mellanox] Add Mellanox-SN5600-C224O8 to gcu_field.json (#3612) (4 weeks ago) [noaOrMlnx]
* a8f7bde0 - PVST Feature commit (#3567) (4 weeks ago) [Divya Kumaran Chandralekha]
* 0e188076 - Refresh dump file modify timestamp before cleanup call (#3595) (4 weeks ago) [anamehra]
* 8f3c5ef5 - [warm-reboot] Add support to pass extra kernel cmdline parameters (#3192) (4 weeks ago) [Pavan Naregundi]
* 96774477 - Run yang validation in db migrator (#3102) (4 weeks ago) [ganglv]
* 9708f52b - [Mellanox] Update C256X1 SKU to be C256S1 in gcu_field.json (#3611) (4 weeks ago) [noaOrMlnx]
* 093ed4aa - [SPM] Add logic to disable the feature before stopping it and enabling it before starting (#3344) (4 weeks ago) [Vadym Hlushko]
* 7d013dff - Fix slash in path. (#3573) (5 weeks ago) [Xincun Li]
* 0af4386e - Consolidate the get running config way. (#3585) (5 weeks ago) [Xincun Li]
* 964b4895 - Fix for integer overflow of counter value if its too large (#3596) (5 weeks ago) [harjotsinghpawra]
* 3354d08a - [config] Bypass standard input for reload (#3597) (5 weeks ago) [jingwenxie]
* 7cbcfda5 - Speed up route_check script (#3544) (5 weeks ago) [Deepak Singhal]
* 329fc223 - Add support of the pensando-dpu platform to generate-dump utility. (#3557) (6 weeks ago) [BHUKYA SIDDHU]
* 0ae2ec1e - Add CLI for bmp configdb entity Enable/Disable (#3286) (6 weeks ago) [Feng-msft]
* 5b37ee6c - Vnet_route_check TCP socket for DB connection. (#3578) (6 weeks ago) [siqbal1986]
* d64a90a0 - Adds logic to get default disk and check disk type (#3399) (6 weeks ago) [Ashwin Srinivasan]
* b2b97340 - [Banner] Added CLI commands to configure Banner and display current configuration (#3021) (6 weeks ago) [Sviatoslav Boichuk]
* d0aa94a1 - Revert "Record and warn tables which not covered by YANG (#3583)" (#3588) (7 weeks ago) [jingwenxie]
* aeda86a1 - Record and warn tables which not covered by YANG (#3583) (7 weeks ago) [jingwenxie]
* dd34d7c4 - Revert "Skip default lanes dup check (#3489)" (#3572) (7 weeks ago) [Xincun Li]
* 6c8007fa - [Mellanox]Remove deprecated sdk sniffer cli and collect sdk dump in show techsupport (#3491) (7 weeks ago) [Yuanzhe]
* 89bb87ad - Add YANG validation for config reload if file is given (#3576) (7 weeks ago) [jingwenxie]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants