[docker-syncd-brcm] [docker-syncd-mlnx]: Properly manage syncd with supervisord #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
May 11, 2017
| [ -e /dev/linux-kernel-bde ] || mknod /dev/linux-kernel-bde c 127 0 | ||
| } | ||
|
|
||
| start_mlnx() |
There was a problem hiding this comment.
this is for mellanox platform. can we consider to still put this syncd.sh into the sairedis repo?
There was a problem hiding this comment.
Is it also possible to take common parts to separate script so that it will be easier to maintain init.d and supervisord all at once?
marian-pritsak
suggested changes
May 11, 2017
| CMD=$CMD_SYNCD | ||
| fi | ||
|
|
||
| parse_yaml() { |
There was a problem hiding this comment.
Is it possible to use sonic-cfggen instead?
There was a problem hiding this comment.
It would be better, however, the syncd dockers are currently built from docker-base, not docker-config-engine, so they don't have sonic-cfggen available. I plan to create a new PR that will do this.
There was a problem hiding this comment.
i think we could replace the docker-base with docker-config-engine.
| [ -e /dev/linux-kernel-bde ] || mknod /dev/linux-kernel-bde c 127 0 | ||
| } | ||
|
|
||
| start_mlnx() |
There was a problem hiding this comment.
Is it also possible to take common parts to separate script so that it will be easier to maintain init.d and supervisord all at once?
|
Closing in favor of PR #617. |
lguohan
pushed a commit
that referenced
this pull request
Sep 5, 2019
Submodule src/sonic-utilities 4024019: [doc/command-reference.md] dos2unix & remove trailing spaces (#591) [show] Add BGP neighbor info to 'show ip/ipv6 interfaces' command output (#598) [config]: fix the runtime error of the 'show line' command (#595) (#596) Revert "Removed 'show interfaces alias'. (#412)" (#603) [debug][undebug] Rework of CLI for BGP (#583) Changing "show runningconfiguration interface" to "show runningconfiguration ports" (#600) [config] Add commands to add/remove DHCP server address from a VLAN (#585) [neighbor_advertiser] Use full vlan name for vxlan tunnel map programming (#604) [neighbor_advertise]: Use the existing MIRROR ACL table (#605) Read config DB for running interface(s) and display per port/interface (#594) [fast/warm reboot] kill radv docker before stopping BGP (#608) [config] Add commands for adding/removing syslog servers (#609) [config] Call 'systemctl reset-failed' before 'systemctl restart' when restarting services (#607) [Command Reference] Add config commands for DHCP relay destination address (#610) [config] Add commands for adding/removing NTP servers (#611) [neighbor_advertiser]: Add V6 support to mirror ICMPV6 packets (#612) [neighbor advertiser] try getting vlan addresses from o.s first (#613) [show] Add command 'show runningconfiguration syslog' (#617) [show] Add command 'show runningconfig ntp' (#620) Added check to config syslog del to verify if ip address was configured. (#622) [fast-reboot] Check if ASIC config has changed before warm reboot (#621) Signed-off-by: Danny Allen daall@microsoft.com
sridhar-ravindran
pushed a commit
to sridhar-ravindran/sonic-buildimage
that referenced
this pull request
Sep 6, 2019
Submodule src/sonic-utilities 4024019: [doc/command-reference.md] dos2unix & remove trailing spaces (sonic-net#591) [show] Add BGP neighbor info to 'show ip/ipv6 interfaces' command output (sonic-net#598) [config]: fix the runtime error of the 'show line' command (sonic-net#595) (sonic-net#596) Revert "Removed 'show interfaces alias'. (sonic-net#412)" (sonic-net#603) [debug][undebug] Rework of CLI for BGP (sonic-net#583) Changing "show runningconfiguration interface" to "show runningconfiguration ports" (sonic-net#600) [config] Add commands to add/remove DHCP server address from a VLAN (sonic-net#585) [neighbor_advertiser] Use full vlan name for vxlan tunnel map programming (sonic-net#604) [neighbor_advertise]: Use the existing MIRROR ACL table (sonic-net#605) Read config DB for running interface(s) and display per port/interface (sonic-net#594) [fast/warm reboot] kill radv docker before stopping BGP (sonic-net#608) [config] Add commands for adding/removing syslog servers (sonic-net#609) [config] Call 'systemctl reset-failed' before 'systemctl restart' when restarting services (sonic-net#607) [Command Reference] Add config commands for DHCP relay destination address (sonic-net#610) [config] Add commands for adding/removing NTP servers (sonic-net#611) [neighbor_advertiser]: Add V6 support to mirror ICMPV6 packets (sonic-net#612) [neighbor advertiser] try getting vlan addresses from o.s first (sonic-net#613) [show] Add command 'show runningconfiguration syslog' (sonic-net#617) [show] Add command 'show runningconfig ntp' (sonic-net#620) Added check to config syslog del to verify if ip address was configured. (sonic-net#622) [fast-reboot] Check if ASIC config has changed before warm reboot (sonic-net#621) Signed-off-by: Danny Allen daall@microsoft.com
Kalimuthu-Velappan
pushed a commit
to Kalimuthu-Velappan/sonic-buildimage
that referenced
this pull request
Sep 12, 2019
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
* support to use python docker 3.5.0 start from docker 3.0.0, results from exec_run changed to dict(outout, code) Signed-off-by: Guohan Lu <gulv@microsoft.com> * limit the scope of exception Signed-off-by: Guohan Lu <gulv@microsoft.com> * modify runcmd output to include exitcode Signed-off-by: Guohan Lu <gulv@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows supervisord to log syncd exit events to syslog.