[Mellanox]: Use iproute2 package distributed with SX SDK. #598

oleksandrivantsiv · 2017-05-12T08:21:21Z

Use iproute2 package with Mellanox patch to support SX netdevs in base image and all
docker images.

lguohan · 2017-05-15T06:02:31Z

files/build_templates/sonic_debian_extension.j2

@@ -77,6 +77,12 @@ sudo cp {{swsssdk_py2_wheel_path}} $FILESYSTEM_ROOT/$SWSSSDK_PY2_WHEEL_NAME
 sudo LANG=C chroot $FILESYSTEM_ROOT pip install $SWSSSDK_PY2_WHEEL_NAME
 sudo rm -rf $FILESYSTEM_ROOT/$SWSSSDK_PY2_WHEEL_NAME

+{% if sonic_asic_platform == 'mellanox' %}


can you use installer_deb for this? check line 158 in this file.

lguohan · 2017-05-18T07:57:49Z

@qiluo-msft, any concerns on build docker-base differently on different platform as melllanox is adding iproute2 on the docker-based for their platform?

qiluo-msft

@oleksandrivantsiv Could you clarify which specific docker images need patched iproute2? I suggest install it just in those images. Or derive images like: docker-base <= docker-iproute2 <= others.

Patched iproute2 does not fit into docker-base, because

It is a dev package, it is updated more frequently then official debian package. We update docker-base mainly for security purpose and significant bug fixes.
It is not used by all the images derived from docker-base, for example, docker-database
It is not used by all platforms. In our internal docker registry server, docker-base is shared by all platform.

msftclas · 2017-06-12T05:52:04Z

@oleksandrivantsiv, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

Submodule src/sonic-utilities 4024019: [doc/command-reference.md] dos2unix & remove trailing spaces (#591) [show] Add BGP neighbor info to 'show ip/ipv6 interfaces' command output (#598) [config]: fix the runtime error of the 'show line' command (#595) (#596) Revert "Removed 'show interfaces alias'. (#412)" (#603) [debug][undebug] Rework of CLI for BGP (#583) Changing "show runningconfiguration interface" to "show runningconfiguration ports" (#600) [config] Add commands to add/remove DHCP server address from a VLAN (#585) [neighbor_advertiser] Use full vlan name for vxlan tunnel map programming (#604) [neighbor_advertise]: Use the existing MIRROR ACL table (#605) Read config DB for running interface(s) and display per port/interface (#594) [fast/warm reboot] kill radv docker before stopping BGP (#608) [config] Add commands for adding/removing syslog servers (#609) [config] Call 'systemctl reset-failed' before 'systemctl restart' when restarting services (#607) [Command Reference] Add config commands for DHCP relay destination address (#610) [config] Add commands for adding/removing NTP servers (#611) [neighbor_advertiser]: Add V6 support to mirror ICMPV6 packets (#612) [neighbor advertiser] try getting vlan addresses from o.s first (#613) [show] Add command 'show runningconfiguration syslog' (#617) [show] Add command 'show runningconfig ntp' (#620) Added check to config syslog del to verify if ip address was configured. (#622) [fast-reboot] Check if ASIC config has changed before warm reboot (#621) Signed-off-by: Danny Allen daall@microsoft.com

Submodule src/sonic-utilities 4024019: [doc/command-reference.md] dos2unix & remove trailing spaces (sonic-net#591) [show] Add BGP neighbor info to 'show ip/ipv6 interfaces' command output (sonic-net#598) [config]: fix the runtime error of the 'show line' command (sonic-net#595) (sonic-net#596) Revert "Removed 'show interfaces alias'. (sonic-net#412)" (sonic-net#603) [debug][undebug] Rework of CLI for BGP (sonic-net#583) Changing "show runningconfiguration interface" to "show runningconfiguration ports" (sonic-net#600) [config] Add commands to add/remove DHCP server address from a VLAN (sonic-net#585) [neighbor_advertiser] Use full vlan name for vxlan tunnel map programming (sonic-net#604) [neighbor_advertise]: Use the existing MIRROR ACL table (sonic-net#605) Read config DB for running interface(s) and display per port/interface (sonic-net#594) [fast/warm reboot] kill radv docker before stopping BGP (sonic-net#608) [config] Add commands for adding/removing syslog servers (sonic-net#609) [config] Call 'systemctl reset-failed' before 'systemctl restart' when restarting services (sonic-net#607) [Command Reference] Add config commands for DHCP relay destination address (sonic-net#610) [config] Add commands for adding/removing NTP servers (sonic-net#611) [neighbor_advertiser]: Add V6 support to mirror ICMPV6 packets (sonic-net#612) [neighbor advertiser] try getting vlan addresses from o.s first (sonic-net#613) [show] Add command 'show runningconfiguration syslog' (sonic-net#617) [show] Add command 'show runningconfig ntp' (sonic-net#620) Added check to config syslog del to verify if ip address was configured. (sonic-net#622) [fast-reboot] Check if ASIC config has changed before warm reboot (sonic-net#621) Signed-off-by: Danny Allen daall@microsoft.com

…put (sonic-net#598)

- Add IN_PORTS and OUT_PORTS match fields - Add VS unit test - Remove deprecated toUpper() function - Add space between if and ( Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

* f972073 2020-04-12 | [vs]: set mtu only on the physical port (sonic-net#601) (HEAD, origin/master, origin/HEAD) [lguohan] * e566f7a 2020-04-10 | [saiplayer] Convert saiplayer to static library (sonic-net#600) [Kamil Cudnik] * fc3a413 2020-04-09 | [syncd] Convert syncd_request_shutdown to static library (sonic-net#599) [Kamil Cudnik] * 027de8f 2020-04-09 | Do not translateVidToRid for processBulkQuadEvent in InitViewMode (sonic-net#598) [Qi Luo] * b0ee63d 2020-04-08 | [syncd] [vs] [sairedis] Add support for bulk api in init view (sonic-net#591) [Kamil Cudnik] * 48ef314 2020-04-08 | [sairedis] Add pragma once to lib header (sonic-net#597) [Kamil Cudnik] * 74af900 2020-04-08 | [build]: allow to use extra inc/lib location to build the package (sonic-net#595) [lguohan] * 9b8c63e 2020-04-07 | Update README.txt: add LGTM badges (sonic-net#596) [Qi Luo] * fdd79e6 2020-04-07 | [tests] Update lib order (sonic-net#594) [Kamil Cudnik] * d89eb59 2020-04-07 | [syncd] Change order of libs in Makefile.am (sonic-net#593) [Kamil Cudnik] Signed-off-by: Guohan Lu <lguohan@gmail.com>

* f972073 2020-04-12 | [vs]: set mtu only on the physical port (#601) (HEAD, origin/master, origin/HEAD) [lguohan] * e566f7a 2020-04-10 | [saiplayer] Convert saiplayer to static library (#600) [Kamil Cudnik] * fc3a413 2020-04-09 | [syncd] Convert syncd_request_shutdown to static library (#599) [Kamil Cudnik] * 027de8f 2020-04-09 | Do not translateVidToRid for processBulkQuadEvent in InitViewMode (#598) [Qi Luo] * b0ee63d 2020-04-08 | [syncd] [vs] [sairedis] Add support for bulk api in init view (#591) [Kamil Cudnik] * 48ef314 2020-04-08 | [sairedis] Add pragma once to lib header (#597) [Kamil Cudnik] * 74af900 2020-04-08 | [build]: allow to use extra inc/lib location to build the package (#595) [lguohan] * 9b8c63e 2020-04-07 | Update README.txt: add LGTM badges (#596) [Qi Luo] * fdd79e6 2020-04-07 | [tests] Update lib order (#594) [Kamil Cudnik] * d89eb59 2020-04-07 | [syncd] Change order of libs in Makefile.am (#593) [Kamil Cudnik] Signed-off-by: Guohan Lu <lguohan@gmail.com>

…nic-net#598)

msftclas added the cla-required label May 12, 2017

marian-pritsak approved these changes May 12, 2017

View reviewed changes

stcheng added the Enhancement ➕ label May 12, 2017

lguohan reviewed May 15, 2017

View reviewed changes

qiluo-msft requested changes May 18, 2017

View reviewed changes

msftclas added cla-signed and removed cla-required labels Jun 12, 2017

[mlnx-sai]: Update SAI version.

6a1fa78

oleksandrivantsiv closed this Jun 22, 2017

daall mentioned this pull request Sep 3, 2019

[src/sonic-utilities] Advance sonic-utilities submodule #3405

Merged

Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019

[show] Add BGP neighbor info to 'show ip/ipv6 interfaces' command out…

7982a32

…put (sonic-net#598)

lguohan mentioned this pull request Apr 12, 2020

[submodule]: update sonic-sairedis #4416

Merged

dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020

Do not translateVidToRid for processBulkQuadEvent in InitViewMode (so…

027de8f

…nic-net#598)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mellanox]: Use iproute2 package distributed with SX SDK. #598

[Mellanox]: Use iproute2 package distributed with SX SDK. #598

oleksandrivantsiv commented May 12, 2017

lguohan May 15, 2017 •

edited

Loading

oleksandrivantsiv May 15, 2017

lguohan commented May 18, 2017

qiluo-msft left a comment •

edited

Loading

msftclas commented Jun 12, 2017

[Mellanox]: Use iproute2 package distributed with SX SDK. #598

[Mellanox]: Use iproute2 package distributed with SX SDK. #598

Conversation

oleksandrivantsiv commented May 12, 2017

lguohan May 15, 2017 • edited Loading

Choose a reason for hiding this comment

oleksandrivantsiv May 15, 2017

Choose a reason for hiding this comment

lguohan commented May 18, 2017

qiluo-msft left a comment • edited Loading

Choose a reason for hiding this comment

msftclas commented Jun 12, 2017

lguohan May 15, 2017 •

edited

Loading

qiluo-msft left a comment •

edited

Loading