[docker-base]: Add less into docker-base. Add strace in docker_base_dbg. Add configuration for vim #591

pavel-shirshov · 2017-05-11T00:49:16Z

No description provided.

qiluo-msft · 2017-05-11T00:59:51Z

dockers/docker-base/Dockerfile.j2

@@ -25,12 +25,14 @@ RUN apt-get clean && apt-get update
 RUN apt-get -y install \
    rsyslog            \
    supervisor         \
-    vim-tiny           \
+    vim                \


1.5M~~400k~~ vs 28M, do you have some strong requirement for a complete vim?

We are installing N 200MB dockers anyway :)

With the help of layer reuse and docker squash (https://docs.docker.com/engine/reference/commandline/build/), the total disk size of the docker images and containers in a production switches is about 570M. Currently we are still deploying images for small disk switches.

is it 2M or 28M?

The largest component for vim is vim-runtime 25.5M: https://packages.debian.org/jessie/vim-runtime. The total size of vim packages is ~28M.

given the smallest disk we have to deal with is still 1.5GB, i recommend to keep vim in the debug build.

Keep vim.tiny for docker-base. But put .vimrc and make link from vim.tiny to vim.

…file

Submodule src/sonic-utilities 4024019: [doc/command-reference.md] dos2unix & remove trailing spaces (#591) [show] Add BGP neighbor info to 'show ip/ipv6 interfaces' command output (#598) [config]: fix the runtime error of the 'show line' command (#595) (#596) Revert "Removed 'show interfaces alias'. (#412)" (#603) [debug][undebug] Rework of CLI for BGP (#583) Changing "show runningconfiguration interface" to "show runningconfiguration ports" (#600) [config] Add commands to add/remove DHCP server address from a VLAN (#585) [neighbor_advertiser] Use full vlan name for vxlan tunnel map programming (#604) [neighbor_advertise]: Use the existing MIRROR ACL table (#605) Read config DB for running interface(s) and display per port/interface (#594) [fast/warm reboot] kill radv docker before stopping BGP (#608) [config] Add commands for adding/removing syslog servers (#609) [config] Call 'systemctl reset-failed' before 'systemctl restart' when restarting services (#607) [Command Reference] Add config commands for DHCP relay destination address (#610) [config] Add commands for adding/removing NTP servers (#611) [neighbor_advertiser]: Add V6 support to mirror ICMPV6 packets (#612) [neighbor advertiser] try getting vlan addresses from o.s first (#613) [show] Add command 'show runningconfiguration syslog' (#617) [show] Add command 'show runningconfig ntp' (#620) Added check to config syslog del to verify if ip address was configured. (#622) [fast-reboot] Check if ASIC config has changed before warm reboot (#621) Signed-off-by: Danny Allen daall@microsoft.com

Submodule src/sonic-utilities 4024019: [doc/command-reference.md] dos2unix & remove trailing spaces (sonic-net#591) [show] Add BGP neighbor info to 'show ip/ipv6 interfaces' command output (sonic-net#598) [config]: fix the runtime error of the 'show line' command (sonic-net#595) (sonic-net#596) Revert "Removed 'show interfaces alias'. (sonic-net#412)" (sonic-net#603) [debug][undebug] Rework of CLI for BGP (sonic-net#583) Changing "show runningconfiguration interface" to "show runningconfiguration ports" (sonic-net#600) [config] Add commands to add/remove DHCP server address from a VLAN (sonic-net#585) [neighbor_advertiser] Use full vlan name for vxlan tunnel map programming (sonic-net#604) [neighbor_advertise]: Use the existing MIRROR ACL table (sonic-net#605) Read config DB for running interface(s) and display per port/interface (sonic-net#594) [fast/warm reboot] kill radv docker before stopping BGP (sonic-net#608) [config] Add commands for adding/removing syslog servers (sonic-net#609) [config] Call 'systemctl reset-failed' before 'systemctl restart' when restarting services (sonic-net#607) [Command Reference] Add config commands for DHCP relay destination address (sonic-net#610) [config] Add commands for adding/removing NTP servers (sonic-net#611) [neighbor_advertiser]: Add V6 support to mirror ICMPV6 packets (sonic-net#612) [neighbor advertiser] try getting vlan addresses from o.s first (sonic-net#613) [show] Add command 'show runningconfiguration syslog' (sonic-net#617) [show] Add command 'show runningconfig ntp' (sonic-net#620) Added check to config syslog del to verify if ip address was configured. (sonic-net#622) [fast-reboot] Check if ASIC config has changed before warm reboot (sonic-net#621) Signed-off-by: Danny Allen daall@microsoft.com

…et#591) Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>

* Remove useless initialization of m_port_ready_list_ref

* f972073 2020-04-12 | [vs]: set mtu only on the physical port (sonic-net#601) (HEAD, origin/master, origin/HEAD) [lguohan] * e566f7a 2020-04-10 | [saiplayer] Convert saiplayer to static library (sonic-net#600) [Kamil Cudnik] * fc3a413 2020-04-09 | [syncd] Convert syncd_request_shutdown to static library (sonic-net#599) [Kamil Cudnik] * 027de8f 2020-04-09 | Do not translateVidToRid for processBulkQuadEvent in InitViewMode (sonic-net#598) [Qi Luo] * b0ee63d 2020-04-08 | [syncd] [vs] [sairedis] Add support for bulk api in init view (sonic-net#591) [Kamil Cudnik] * 48ef314 2020-04-08 | [sairedis] Add pragma once to lib header (sonic-net#597) [Kamil Cudnik] * 74af900 2020-04-08 | [build]: allow to use extra inc/lib location to build the package (sonic-net#595) [lguohan] * 9b8c63e 2020-04-07 | Update README.txt: add LGTM badges (sonic-net#596) [Qi Luo] * fdd79e6 2020-04-07 | [tests] Update lib order (sonic-net#594) [Kamil Cudnik] * d89eb59 2020-04-07 | [syncd] Change order of libs in Makefile.am (sonic-net#593) [Kamil Cudnik] Signed-off-by: Guohan Lu <lguohan@gmail.com>

* f972073 2020-04-12 | [vs]: set mtu only on the physical port (#601) (HEAD, origin/master, origin/HEAD) [lguohan] * e566f7a 2020-04-10 | [saiplayer] Convert saiplayer to static library (#600) [Kamil Cudnik] * fc3a413 2020-04-09 | [syncd] Convert syncd_request_shutdown to static library (#599) [Kamil Cudnik] * 027de8f 2020-04-09 | Do not translateVidToRid for processBulkQuadEvent in InitViewMode (#598) [Qi Luo] * b0ee63d 2020-04-08 | [syncd] [vs] [sairedis] Add support for bulk api in init view (#591) [Kamil Cudnik] * 48ef314 2020-04-08 | [sairedis] Add pragma once to lib header (#597) [Kamil Cudnik] * 74af900 2020-04-08 | [build]: allow to use extra inc/lib location to build the package (#595) [lguohan] * 9b8c63e 2020-04-07 | Update README.txt: add LGTM badges (#596) [Qi Luo] * fdd79e6 2020-04-07 | [tests] Update lib order (#594) [Kamil Cudnik] * d89eb59 2020-04-07 | [syncd] Change order of libs in Makefile.am (#593) [Kamil Cudnik] Signed-off-by: Guohan Lu <lguohan@gmail.com>

…net#591) * [syncd] [vs] [sairedis] Add support for bulk api in init view * Fix spelling

…10406) #### Why I did it To take the following into sonic-buildimage 36e1f61 API endpoints to ConfigDBConnector to support pre-loading data without blackout (#587) [sonic-swss-common](https://github.com/Azure/sonic-swss-common) ``` 36e1f61 API endpoints to ConfigDBConnector to support pre-loading data without blackout (#587) 556f4ad Add SAI copy action to ACL schema (#591) db18c3a Fix bitwidth of mac address in SAI ACL schema (#590) e9442bb [ConfigDBPipeConnector]: Added set_entry API (#586) 6c007c0 Update README for gmock (#562) ``` [sonic-linkmgrd](https://github.com/Azure/sonic-linkmgrd) ``` 83dfc99 Enforce uniform file/class naming convention (#52) 83004bf Shutdown ICMP heartbeats when default route state is missing and ToR is in `auto` mode (#44) b81ea31 Add `LinkProberStateMachineActiveActive` (#47) c43cf7a Decrease link probing interval after switchover to better determine the overhead of a toggle (#43) 2239fbe Enhance clang format (#46) ``` #### How I did it * Advanced submodules pointers #### How to verify it 1. make configure PLATFORM=mellanox 2. make target/sonic-mellanox.bin

Add less and vim in docker-base. Add strace in docker_base_dbg

25748b6

qiluo-msft reviewed May 11, 2017

View reviewed changes

Don't install vim, but make link vim to vim.tiny and have vim config …

29a228f

…file

pavel-shirshov changed the title ~~[docker-base]: Add less and vim in docker-base. Add strace in docker_base_dbg~~ [docker-base]: Add less into docker-base. Add strace in docker_base_dbg. Add configuration for vim May 11, 2017

qiluo-msft approved these changes May 12, 2017

View reviewed changes

stcheng approved these changes May 12, 2017

View reviewed changes

stcheng merged commit b26ec86 into sonic-net:master May 12, 2017

daall mentioned this pull request Sep 3, 2019

[src/sonic-utilities] Advance sonic-utilities submodule #3405

Merged

Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019

[doc/command-reference.md] dos2unix & remove trailing spaces (sonic-n…

765b27d

…et#591) Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020

Remove useless initialization of m_port_ready_list_ref (sonic-net#591)

bff03e9

* Remove useless initialization of m_port_ready_list_ref

lguohan mentioned this pull request Apr 12, 2020

[submodule]: update sonic-sairedis #4416

Merged

dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020

[syncd] [vs] [sairedis] Add support for bulk api in init view (sonic-…

b0ee63d

…net#591) * [syncd] [vs] [sairedis] Add support for bulk api in init view * Fix spelling

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docker-base]: Add less into docker-base. Add strace in docker_base_dbg. Add configuration for vim #591

[docker-base]: Add less into docker-base. Add strace in docker_base_dbg. Add configuration for vim #591

pavel-shirshov commented May 11, 2017

qiluo-msft May 11, 2017 •

edited

Loading

kcudnik May 11, 2017

qiluo-msft May 11, 2017

lguohan May 11, 2017

qiluo-msft May 11, 2017 •

edited

Loading

lguohan May 11, 2017

pavel-shirshov May 11, 2017

[docker-base]: Add less into docker-base. Add strace in docker_base_dbg. Add configuration for vim #591

[docker-base]: Add less into docker-base. Add strace in docker_base_dbg. Add configuration for vim #591

Conversation

pavel-shirshov commented May 11, 2017

qiluo-msft May 11, 2017 • edited Loading

Choose a reason for hiding this comment

kcudnik May 11, 2017

Choose a reason for hiding this comment

qiluo-msft May 11, 2017

Choose a reason for hiding this comment

lguohan May 11, 2017

Choose a reason for hiding this comment

qiluo-msft May 11, 2017 • edited Loading

Choose a reason for hiding this comment

lguohan May 11, 2017

Choose a reason for hiding this comment

pavel-shirshov May 11, 2017

Choose a reason for hiding this comment

qiluo-msft May 11, 2017 •

edited

Loading

qiluo-msft May 11, 2017 •

edited

Loading