Get rid of chef_gem. #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chef_gem fails because build-essential isn't installed at compile time. The Chef guys are recommending that complex things like replicaset and mongos become LWRPs, which is probably in progress but this fixes the chef_gem issue quickly.
|
Not sure if this is the best idea… it works as a quick fix I'd address the issue with compile time with Check: https://github.com/chef-brigade/mongodb-cookbook/pull/14/files |
|
LGTM so long as it gets a comment explaining when we can rip it out |
| @@ -24,7 +24,15 @@ | |||
| node.override['mongodb']['instance_name'] = 'mongos' | |||
|
|
|||
| include_recipe 'mongodb::install' | |||
| include_recipe 'mongodb::mongo_gem' | |||
|
|
|||
| ruby_block 'chef_gem_at_converge_time' do· | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Merged
|
Closing in favor of #39 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source: edelight/chef-mongodb#370