Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of chef_gem #39

Merged
merged 3 commits into from
Jul 8, 2015
Merged

Get rid of chef_gem #39

merged 3 commits into from
Jul 8, 2015

Conversation

josephholsten
Copy link
Contributor

fix the middle dot in #21

gswallow and others added 2 commits February 27, 2015 10:47
chef_gem fails because build-essential isn't installed at compile time.
The Chef guys are recommending that complex things like replicaset and
mongos become LWRPs, which is probably in progress but this fixes the
chef_gem issue quickly.
@josephholsten josephholsten mentioned this pull request Jun 8, 2015
@josephholsten josephholsten added bug and removed wontfix labels Jun 8, 2015
@josephholsten josephholsten changed the title Pr/21 Get rid of chef_gem Jun 8, 2015
@@ -21,7 +21,15 @@
node.set['mongodb']['cluster_name'] = node['mongodb']['cluster_name']

include_recipe 'mongodb::install'
include_recipe 'mongodb::mongo_gem'

ruby_block 'chef_gem_at_converge_time' do·

This comment was marked as outdated.

This comment was marked as outdated.

@luishdez
Copy link
Contributor

luishdez commented Jun 9, 2015

wt… another dot

@josephholsten all PRs are branches within this repo, you can checkout pr/370 and commit there to avoid duplicated PRs. I'm closing the original PR

@zarry
Copy link
Contributor

zarry commented Jul 7, 2015

Aside from the slight duplication anything else stopping a merge on this?

@thomas-riccardi
Copy link

I thought the middle dot should break everything, I don't understand why CI raises no issue.

The code duplication is minor and should not be blocking.

remove dot
@zarry
Copy link
Contributor

zarry commented Jul 8, 2015

I removed the dot, once travis gives us the OK I will merge.

zarry added a commit that referenced this pull request Jul 8, 2015
@zarry zarry merged commit 642a7cd into master Jul 8, 2015
@josephholsten josephholsten deleted the pr/21 branch July 13, 2015 22:34
@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants