Update from upstream #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add winurl support * update tests for winurl * fixed location winurl is handled * update to test winurl by accessing by direct obj property access * updated test for bidderid object property name * update to remove g from regex for property name test * update to optimize length test * updated with requested changes from pull request * removed local dev test page * updated to remove extra reference created for regex * updated to remove extra reference for test for bidid in winurl * updated with pr changes * updated tests with triggerPixel spy
Did some testing on #75 and found that we're going to need to encode the hb_winurl or GAM won't pass it through. So adding a level of unencoding.
* update gulp V3 to gulp v4 * replace depracated package gulp-clean with recommended package del * update docs to add additional instruction when upgrading gulp v3 -> gulp v4 * add line space to increase readability * update karma v^3.0.0 -> v^4.2.0 and remove unused package open to address vulns * add instruction for minimum supported Node version * update instructions for checking gulp version * replace vuln package gulp-webserver with gulp-connect and open * update lodash version to fix vulnerabilities * update minimum node supported version in README.md
…led once per adElement (#71)
* fix gulp commands to test and view code coverage * fix gulp e2e command * bump up node version to support spread operator used in some dev deps * delete dist/load-cookie.html * change https to http * update browsers * change tasks to functions to adhere to gulp v4 standards * update gulp e2e command * remove mobile_app test page * added build info to browserstack object
* mobile native rendering * Adding missing files * check for undefined
…olders (#86) * Use a global regex replace instead of string replace on native placeholders * PR feedback
* change permission to load-cookie.html file * remove dot * change permison to 666 * change file permission to 766
* add winurl support * update tests for winurl * fixed location winurl is handled * update to test winurl by accessing by direct obj property access * updated test for bidderid object property name * update to remove g from regex for property name test * update to optimize length test * updated with requested changes from pull request * removed local dev test page * updated to remove extra reference created for regex * updated to remove extra reference for test for bidid in winurl * updated with pr changes * updated tests with triggerPixel spy * update to check for prebid cache wurl value, and if defined creates a tracking pixel using the value. * restored package-lock.json * updated node version support to 8.7, which corrects an "opn" npm package error from aysnc await usage in opn index.js * removed support for wurl hb_winurl * fix revert test change * addition to revert * addition to revert * removed unused tag params * removed unused param
* not relying on hard coded google iframe domain * minor - made renderingManager being consistent about using "win" rather than "window" Co-authored-by: Eric Harper <eharper@rubiconproject.com>
…html element inside <a> tag (#103)
* Created alternate to load-cookie.html named load-cookie-with-consent.html. This will load the cookieSyncWithConsent.js script which will postMessage the parent window for GDPR consent data. * Fixed comment error
* temp progress * add winurl support * fix for amp cached div not sizing same as on resize * jsdoc formatting change * update with requested changes
…ong as new data property to sync endpoint (#115)
* PUC update to include Native Phase 2 spec: 1) Added renderNativeAd function to nativeTrackerManager.js 2) renderNativeAd checks for existence of adId and performs the following: - Checks for rendererUrl and preloads if exists - Uses prexisting loadAssets function with new callback - Fires Impression tracker and loads click tracker 3) LoadAssets update: - Checks for existence of assetsToReplace and adds each asset to placeholder - If no placeholders exist, checks for requestAllAssets flag to fire new requestAllAssets function 4) requestAllAssets will postmessage Prebid using the action allAssetRequest instead of assetRequest 5) Replace assets will now use added logic: - If rendererUrl existence. If exists in adServer (preloaded) then check for renderAd availability on the window. If none exists, set load event on the script tag using the id 'pb-native-renderer'. If url sent as asset from Prebid, append script to window and attach load event. When script loaded and renderAd available, fire function to retrieve HTML. This inserted into innerHtml - Else if adTemplate exists, replace assets and insert into innerHtml - Else run existing replace method 6) replace function updated to include check for new native to replace keys which are in the format of ##KEY## nativeAssetManager_spec and nativeTrackerManager_spec both updated to include additional tests nativeTracker.js updated to include renderNativeAd function definition on window object * Update to separate renderNative method into new class called nativeRenderManager. Removed repetitive publisherDomain definitions * Updates to fix lint errors and remove commented code * Revert package-lock * Remove DS_Store * Update to separate new native functionality into new native-render.js file to avoid loading unused code lib * Added line to message event listener to validate that if new nativeRenderer exists then adId in message must match adId in creative window, before replacing assets * Added test for mismatch adId in replaceAsset response * Minor fixes * Addition to inlcude replace of macros in CSS in head of document * Update to lookup macros in CSS not defined in BODY * Updating asset logic to first see if request all is set then fallback to see if placeholders are found * Update to include post message to resize safeframe * Fix for render URL Co-authored-by: Michael Moschovas <mmoschovas@NY-Moschovas.local> Co-authored-by: Michael Moschovas <mmoschovas@NY-Moschovas.fios-router.home>
Co-authored-by: Mike Mullin <mike.mullin@indexexchange.com>
* added support for GAM macro %%CLICK_URL_UNESC%% * add tests for %%CLICK_URL_UNESC%% * add info about clickUrlUnesc in readme Co-authored-by: Michele Nasti <michele@rtk.io>
* Replace all placeholders with the corresponding ortb assets * Add test for replacing all placeholders * Use gulp in test script --------- Co-authored-by: anita.schiller <anita.schiller@gutefrage.net>
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.32 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.32...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [minimist](https://github.com/minimistjs/minimist) to 1.2.8 and updates ancestor dependencies [minimist](https://github.com/minimistjs/minimist), [mkdirp](https://github.com/isaacs/node-mkdirp), [handlebars](https://github.com/wycats/handlebars.js), [karma-mocha](https://github.com/karma-runner/karma-mocha) and [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together. Updates `minimist` from 1.2.0 to 1.2.8 - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.0...v1.2.8) Updates `mkdirp` from 0.5.1 to 0.5.6 - [Release notes](https://github.com/isaacs/node-mkdirp/releases) - [Changelog](https://github.com/isaacs/node-mkdirp/blob/main/CHANGELOG.md) - [Commits](isaacs/node-mkdirp@0.5.1...v0.5.6) Updates `handlebars` from 4.4.3 to 4.7.7 - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.4.3...v4.7.7) Updates `karma-mocha` from 1.3.0 to 2.0.1 - [Release notes](https://github.com/karma-runner/karma-mocha/releases) - [Changelog](https://github.com/karma-runner/karma-mocha/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma-mocha@v1.3.0...v2.0.1) Updates `mocha` from 5.2.0 to 10.2.0 - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](mochajs/mocha@v5.2.0...v10.2.0) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect - dependency-name: mkdirp dependency-type: indirect - dependency-name: handlebars dependency-type: indirect - dependency-name: karma-mocha dependency-type: direct:development - dependency-name: mocha dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.2.1 to 4.2.4. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io-parser@4.2.1...4.2.4) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Emit AD_RENDER_SUCCEEDED and AD_RENDER_FAILED for native ads * Merge master
Bumps [fsevents](https://github.com/fsevents/fsevents) from 1.2.9 to 1.2.13. - [Release notes](https://github.com/fsevents/fsevents/releases) - [Commits](fsevents/fsevents@v1.2.9...v1.2.13) --- updated-dependencies: - dependency-name: fsevents dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Updating Prebid documentation links in README.md * Updating "Add Creatives" URL
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.6.3 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.0.4 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.0.4...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ejs](https://github.com/mde/ejs) from 3.1.8 to 3.1.10. - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.8...v3.1.10) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Adding some comments to nativeAssetManager.js Thought these might help the next poor soul who has to try to figure this thing out * Update src/nativeAssetManager.js Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
Bumps [body-parser](https://github.com/expressjs/body-parser) from 1.20.1 to 1.20.3. - [Release notes](https://github.com/expressjs/body-parser/releases) - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md) - [Commits](expressjs/body-parser@1.20.1...1.20.3) --- updated-dependencies: - dependency-name: body-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Resolves the issue of no error when prebid global is defined but not renderAd.
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.4 to 6.6.0. - [Commits](indutny/elliptic@v6.5.4...v6.6.0) --- updated-dependencies: - dependency-name: elliptic dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove deprecated postscribe * Fix mobile-app rendering when admarkup contains lowercase DOCTYPE tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.