Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updating the input for tweakreg #89

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

catherine-martlin
Copy link
Contributor

Changed list input for tweakreg to be hardcoded list instead of using glob as different systems can end up with files in different orders.

@pllim
Copy link
Contributor

pllim commented Mar 26, 2019

Might need a squash so that the uncleared notebook doesn't make it into master history.

@catherine-martlin catherine-martlin force-pushed the fix_align_multiple_visits branch from 698c641 to ff61a96 Compare March 26, 2019 17:20
@pllim
Copy link
Contributor

pllim commented Mar 26, 2019

@catherine-martlin , try rebase to use the longer timeout limit that Josh implemented earlier.

theresadower and others added 15 commits April 2, 2019 15:35
- Added code to list available tables
- Decreased search radius for KQ UMa to 1 arcsec (was 1 arcmin)
Co-Authored-By: theresadower <dower@stsci.edu>
Had originally avoided astroquery.mast dependencies, but the notebook is already dependent on astroquery.utils, and this change removed some other dependencies the inline function had used.
From Greg Snyder, MASTVO-293 in JIRA
* Copy from DA5 notebooks

* Clean up NIRCam notebook, add requirements

* Address review comment

* Use logo added in spacetelescope#86
@astro-josh astro-josh requested a review from pllim April 8, 2019 16:32
@pllim
Copy link
Contributor

pllim commented Apr 8, 2019

Something isn't right with the commit history...

Try this:

git fetch upstream master
git rebase upstream/master

@catherine-martlin
Copy link
Contributor Author

catherine-martlin commented Apr 8, 2019

@pllim - Thank you! Definitely still figuring out how to properly rebase all the different ways when working on my fork and branch. Do you think that cleared it up appropriately?

Edit: The checks just finished though, and it looks like one of the TESS notebooks failed this time - could I have missed some needed updates when I just rebased with upstream/master?

@pllim
Copy link
Contributor

pllim commented Apr 8, 2019

@catherine-martlin , the history still doesn't look quite right. Ideally, you should only see your own relevant commits as part of this PR in the commit history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants