This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
0.7.0 preview rc #1426
Merged
0.7.0 preview rc #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Queue RPCs by Worker_EntityId * Apply suggestions from code review Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Changed Worker_EntityId to Worker_EntityId_Key for Linux compilation. Fixed function signature * Moved initialisation inside if statements
* Prevent creating alternate channel * Add guards for correct NetConnection
Merge 0.6.0 release into master
* Initial commit * Cleaned outdated code * Iterate through an Actor's children when its ownership changes. * Update SpatialActorChannel.h * Update SpatialActorChannel.cpp * Changed Schema_GetBool -> GetBoolFromSchema * Update SpatialGDK/Source/SpatialGDK/Public/Schema/ServerRPCEndpoint.h Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Use 0 NetGuid for Actors that are not replicated
* Added TEST macro * Moved a TEST definition macro to TestDefinitions.h. Updated test names to follow the suggested convention * Removed Timer-related tests * Removed some tests. Added test for RPC queueing logic. * Fixed compilation errors * Moved RPCContainerTest to a separate SpatialGDKTests module * Fixed the build * Applied suggestions * Moved MockObject to DummyObject * Fixed compilation errors * Added SpyObject. Added test object explanation to TestDefinitions.h * Updated test names, updated includes * Moved and renamed test object files * Fixed build * Removed misleading conditions, use checks instead. Removed WITH_DEV_AUTOMATION_TESTS macro, since tests are in a separate module anyway * Small changes to address feedback. Changed all includes to use quotes * Moved assert to the top of the file * Fixed character case * Codestyle fix * Added anonymous namespace comment * Added namespace comment * Changed one of includes from Core to CoreMinimal * Updated error message * Renamed SpyUtils helper functions
* VS 2019 work Updated FindMSBuild.bat a bit Fixed some implicit int->bool conversions that 2019 picked up
* Initial change to route PlayerController spawning on non-auth server through the client path, in order to get it calling BeginPlay with the correct authority. This change likely needs more work, but committing/pushing now to share it. * Cleaning up the PlayerController change a bit * Fix problem with PlayerController not replicating unless the server that spawned it has authority over it * In tandem with the incoming engine branch change to disable creation of the PlayerState on non-auth servers, we no longer need to cleanup the player state here * Name out parameter correctly * Update changelog * Report failure to create the SpatialNetConnection * Now it even compiles * Fix bitwise operator * Update SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp Co-Authored-By: Giray Ozil <giray@improbable.io> * Addressing some PR comments * Addressing PR comments
* Refactor util functions * Order imporrts * Fix tabs * Fix typo in bPasingSuccess * Fix weird spacing * Fix log category * Remove unused imports * Remove unused project name
* Remove queuing properties on the sending side * Use class path to resolve singleton actors if the entity is not checked out * Address PR comments * Add explanatory comment * Apply suggestions from code review Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Address PR comments * Rename variable * Fix singleton class ref resolution * Use GetTypedOuter
* Initial commit * Added Error codes. Moved logging to RPCContainer * Every RPC goes through RPCContainer now * Test fix * Added SchemaType to FPendingRPCParams. Removed ReliableRPCIndex from FPendingRPCParams. Cleaned up some code in Sender/Receiver * FPendingRPCParams is now constructed inside RPCContainer. Use FPendingRPCParams by value instead of TUniquePtr * Dropping RPC after 5 sec. Surrounded strings with TEXT. * Use WeakPtrs instead of raw ptrs. Wrapped RPC logging in !UE_BUILD_SHIPPING macro * Added ERPCError::Uknown. Updated RPC logging function * Updated LogRPCError function * Added information about queue type and if it's client or server to logging * Removed some code duplication in FRPCErrorInfo creation in SpatialSender/SpatialReceiver. * Updated includes in RPCContainer.h * Included UObject to RPCContainer.h * Included Class.h to RPCContainer.h * Updated RPCContainer.h includes * Added error for case, when no processing function has been bound to the RPCContainer * Fixed one of unit tests for RPCContainer * Updated CHANGELOG.md * Disabled RPC dropping * Suspended expected warnings for RPCContainer tests * Update SpatialGDK/Source/SpatialGDK/Private/Utils/RPCContainer.cpp Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Added default values for FRPCErrorInfo. Sorted includes * Changed ERPCError to ERPCResult * Cleaned up BindProcessingFunction code * Update SpatialGDK/Source/SpatialGDK/Public/Utils/RPCContainer.h Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Update SpatialGDK/Source/SpatialGDK/Private/Utils/RPCContainer.cpp Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Removed bDropRPC argument since it's not used * Update SpatialGDK/Source/SpatialGDK/Private/Utils/RPCContainer.cpp Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Renamed Error to Result in ERPCResultToString * Renamed ErrorCode to Result in multiple places. Moved return statement to a proper line. * CreateRPCCommandRequest, CreateRPCEvenUpdate, AddPendingRPC in SpatialSender don't return UnresolvedTargetObject anymore. They use `ensure` internally instead * Removed NoProcessingFunctionBound error, using `ensure` instead * Update SpatialGDK/Source/SpatialGDKTests/Private/RPCContainer/ObjectStub.cpp Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Update SpatialGDK/Source/SpatialGDKTests/Private/RPCContainer/ObjectSpy.cpp Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
* Moved GenerateDefaultLaunchConfig to a separate file in SpatialGDKEditor * Moved GenerateDefaultWorkerJson to SpatialGDKEditor * Renamed bRedeployRequired -> bOutRedeployRequired * Update SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKDefaultLaunchConfigGenerator.cpp Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Update SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKDefaultLaunchConfigGenerator.cpp Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Update SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKDefaultLaunchConfigGenerator.cpp Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Update SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKDefaultLaunchConfigGenerator.cpp Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Updated tabbing, changed the severity of one of logs
* Fix SpatialGDKSchema to return false if schema compiler fails * Update changelog * Add error message if schema gen cannot create directory
0.6.1 hotfix
#1301) * Fix crash with generate schema commandlet * Update changelog * Update CHANGELOG.md Co-Authored-By: Joshua Huburn <31517089+joshuahuburn@users.noreply.github.com>
…her process (#1308) * Added flags to SavePackage() to avert editor crash, updated user feedback * Updated changelog
* UNR-1857 Unresolved RPC parameters can cause permanent queue blocking (#1277) * Apply RPC with unresolved refs after it's been queued for a while. * Updated Changelog.md * Moved logic to process RPCs with unresolved references to ApplyRPC function. Added SecondsToProcessRPCWithUnresolvedRefs setting with 1.0 as default value * Update SpatialGDK/Source/SpatialGDK/Public/Utils/RPCContainer.h Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Added logging for RPCs processed with unresolved parameters. * Updated CHANGELOG.md * Updated CHANGELOG.md * Fixed a couple of typos * Update SpatialGDK/Source/SpatialGDK/Public/SpatialGDKSettings.h Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Changed SecondsToProcessRPCWithUnresolvedRefs to WaitTimeBeforeProcessingReceivedRPCWithUnresolveRefs, exposed it GDK settings. * Fixed UI issue for a new setting * Update CHANGELOG.md Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Renamed Timestamp -> QueuedTimestamp * Renamed WaitTimeBeforeProcessingReceivedRPC_WithUnresolvedRefs -> QueuedIncomingRPCWaitTime, but kept the same DisplayName * Update CHANGELOG.md * IsListening and ownership fix (#1246) (#1284) * Initial commit * Cleaned outdated code * Iterate through an Actor's children when its ownership changes. * Update SpatialActorChannel.h * Update SpatialActorChannel.cpp * Changed Schema_GetBool -> GetBoolFromSchema * Update SpatialGDK/Source/SpatialGDK/Public/Schema/ServerRPCEndpoint.h Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Use 0 NetGuid for Actors that are not replicated * UNR-1864 Use GetPlugin helper method to resolve sim player laun… (#1278) * Used GetPlugin helper method to resolve sim player launch config * Updated changelog * DOC-1255 Clarify elements of the GDK in readme (#1287) * Clarify elements of the GDK * Apply suggestions from code review Co-Authored-By: Laura <36853437+ElleEss@users.noreply.github.com> * Updates from review * Update CHANGELOG.md * Switch validity checks to use whats defaulted (#1300) * Update CHANGELOG.md * Update CHANGELOG.md
* Updated logging for RPC processing * Slightly modified warning message * Fixed brokent RPCContainer tests. Added test for Warning logging * Use constant value in test
* Update release-process.md * Update release-process.md * Update release-process.md * Update release-process.md * Add known issues audit * Update SpatialGDK/Extras/internal-documentation/release-process.md Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * fix merge order which, should have been preview>release>master * WIP Xbone DLLs * Update release-process.md * Update release-process.md * Update SpatialGDK/Extras/internal-documentation/release-process.md Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Update SpatialGDK/Extras/internal-documentation/release-process.md Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com> * Update SpatialGDK/Extras/internal-documentation/release-process.md Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
* Add server interest in all entities when running offloading * Fix launch config validity checks * Refactor worker interest into interest factory * Update error message
* Check for entity in view before erroring in create response * Update SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialActorChannel.cpp Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
* Created Local Deployment test * Added jira ticket numbers. Added automation macro for cleaner code. Now worker json name can be specified. Passing LaunchConfigDescription to GenerateDefaultLaunchConfig * Trying to fix indentations * Update SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKDefaultLaunchConfigGenerator.cpp * Update SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKDefaultLaunchConfigGenerator.cpp Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Update SpatialGDK/Source/SpatialGDKEditor/Private/SpatialGDKDefaultWorkerJsonGenerator.cpp Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Renamed GenerateWorkerPB -> GenerateWorkerAssemblies. Added FSpatialLaunchConfigDescription constructor with worker name. Removed unused code. * Made the whole StartDeployment function in LocalDeploymentManagerTest async * Apply suggestions from code review Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io> * Update SpatialGDK/Source/SpatialGDKTests/Private/LocalDeploymentManager/LocalDeploymentManagerTest.cpp Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
* Use spot service health-check instead of spatial service status * Updated spot version
* Added downstream compression.
* Initialize internal SpatialActorChannel state in Init function to clean reused channels from pool * Remove whitespace
* Fixed an issue with multicast RPCs being called close to entity creation * Updated Changelog.md
…#1403) * Only use Owner's Spatial position if it is replicated * Updated changelog * Update CHANGELOG.md
#1402) * Create SpatialActorChannel on a dormant actor when receiving component update * Address PR feedback, refactor dormancy wakeup channel creation into a function * Further PR feedback, mostly cosmetic * Apply suggestions from code review * Update SpatialGDK/Source/SpatialGDK/Private/Interop/SpatialReceiver.cpp * Apply suggestions from code review
…o 0.7.0-preview-rc
* Create SpatialActorChannel on a dormant actor when receiving component update * Address PR feedback, refactor dormancy wakeup channel creation into a function * Further PR feedback, mostly cosmetic * Make refactored function actually return a channel
…1410) * Force SpatialNetworking in CookAndGenerateSchemaCommandlet * Add docs to CookAndGenerateSchemaCommandlet * Add -SkipSchema switch to GenerateSchemaAndSnapshots (so that you can generate snapshots only)
…ending dormancy has a deleted actor (#1413)
Recent changes might have invalidated an old assumption about having a valid GUID in `PreReceiveSpatialUpdate`. Removing the check for now and adding a warning log to have more context in case this causes a crash further down the line.
…subobject (#1423) * Fix a crash when applying component data for deleted static subobject * Update CHANGELOG.md * Update SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialActorChannel.cpp
improbable-prow-robot
added
jira/no-ticket
improbable-valy
approved these changes
Oct 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Release
0.7.0-previewto thepreviewbranch.Release note
See CHANGELOG.md
Tests
Executed the full release test process.
Documentation
See CHANGELOG.md