-
Notifications
You must be signed in to change notification settings - Fork 3
feat: issue a warning when assigned profile is missing #162
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #162 +/- ##
===========================================
- Coverage 47.45% 47.34% -0.12%
===========================================
Files 22 22
Lines 1239 1242 +3
===========================================
Hits 588 588
- Misses 651 654 +3
Continue to review full report at Codecov.
|
@@ -173,6 +173,12 @@ def is_conf_changed(self, entry_key, ir, old_conf): | |||
) | |||
|
|||
def process_new_job(self, entry_key, ir, profiles): | |||
if ir.profile not in profiles.get("profiles"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if profiles will not be in profiles get will return None and it will throw TypeError, so the safe choice would be to
acquired_profiles = profiles.get("profiles") if acquired_profiles is not None and ir.profile not in acquired_profiles
Expected release notes (by @weliasz) features: fixes: others (will not be included in Semantic-Release notes):
|
🎉 This PR is included in version 1.5.0-develop.24 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
If non existing profile is assigned to device, no scheduler record is created and warning is issued.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I added entry with missing profile and verified that warning was issued
Checklist