Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 6443 fix #6592

Closed
wants to merge 4 commits into from
Closed

Gh 6443 fix #6592

wants to merge 4 commits into from

Conversation

vishalvrv9
Copy link
Contributor

This pull request is in reference to #6443 and #6514

Previously, the OidcIdTokenValidator.setClockSkew() asserted the clockSkew is not null.
This is a new PR created to mitigate problems being faced in #6514 consists of:

  1. checks to ensure clockSkew >=0
  2. relevant test cases for both clockSkew=null (was missing as was pointed out in the discussion at OidcIdTokenValidator ensures clockSkew is positive number #6443) along with assertion tests for clockSkew >=0

@vishalvrv9 vishalvrv9 mentioned this pull request Mar 5, 2019
Closed
@jgrandja
Copy link
Contributor

jgrandja commented Mar 5, 2019

Closing this PR - see comment

@jgrandja jgrandja closed this Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalvrv9 @jgrandja