New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mellanox]Resolve chassis broken due to inconsistent with latest sonic_platform_common #13

Closed

stephenxs wants to merge 8 commits into master from update_firmware_version

Owner

stephenxs commented Sep 30, 2019

- What I did
Resolve chassis broken by supporting the latest component API (get_firmware_version)
Currently get_firmware_version implemented by using chassis.get_firmware_version and chassis._component_name_list which are not supported in the latest sonic_platform_common, causing chassis broken.
Update this part so that it aligns to the latest sonic_platform_common

- How I did it
Originally get_firmware_version is a member function of chassis but recently it is moved to component.py. In this case mlnx-platform-api should be updated accordingly otherwise chassis is broken.

- How to verify it
test

whether firmware versions can be fetch
whether chassis can be loaded successfully

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)


          [sonic_platform]Support component API (get_firmware_version).

501df93

Currently get_firmware_version implementated by using chassis.get_firmware_version and chassis._component_name_list which are not supported in the latest sonic_platform_common, causing chassis broken.
Update this part so that it aligns to the latest sonic_platform_common
Support component API

Collaborator

keboliu commented Sep 30, 2019

in PEP8, usually, it requires two lines between functions definition or classes, would you please go through the files? I would like to suggest to stick with PEP8 formats.


          [sonic_platform]follow the PEP8 standard

3dcb488

keboliu approved these changes

View reviewed changes

liat-grozovik suggested changes

View reviewed changes

liat-grozovik left a comment

Why do we have asic fw part of platform API
IMO asic fw is not part of the platform and it requires SDK bundle.

nazariig reviewed

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved

nazariig reviewed

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved

nazariig reviewed

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/platform.py Outdated Show resolved Hide resolved

nazariig reviewed

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Show resolved Hide resolved

nazariig suggested changes

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved

Stephen added 3 commits

October 1, 2019 12:16


          [sonic_platform]Address comments

92ddc77

1. rename initialize_components
2. replace cpld?_version with cpld[0-9]_version in order to be more accurate


          [sonic_platform]Remove ASIC_FW from components list

013b3a3


          [sonic_platform]Add description of components

151f895

Owner Author

stephenxs commented Oct 1, 2019

Why do we have asic fw part of platform API
IMO asic fw is not part of the platform and it requires SDK bundle.

ASIC FW part has been removed.

nazariig reviewed

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Show resolved Hide resolved

Owner Author

stephenxs commented Oct 1, 2019 via email

Do you mean something like “cpld_version” or other name? IMO, hw-management should make sure the symbol link names follow the correct name convention.

nazariig reviewed

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved


          [sonic_platform] Raise an exception if CPLD version files not found.

ea23de2

nazariig commented Oct 1, 2019

Do you mean something like “cpld_version” or other name? IMO, hw-management should make sure the symbol link names follow the correct name convention.

@stephenxs yes. This may be a case.

nazariig suggested changes

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved


          [sonic_platform]Address comments

cf723d2

1. implement file reading by with statment
2. adjust statement which testing whether list is empty

nazariig reviewed

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Show resolved Hide resolved

Owner Author

stephenxs commented Oct 2, 2019 via email

Yes. But this is out of the scope of this PR. We have a backlog in which all common functions will be extracted and shared by all of platform APIs.

nazariig reviewed

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved

nazariig reviewed

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved

nazariig commented Oct 2, 2019

Yes. But this is out of the scope of this PR. We have a backlog in which all common functions will be extracted and shared by all of platform APIs.

nazariig reviewed

View reviewed changes

platform/mellanox/mlnx-platform-api/sonic_platform/component.py Outdated Show resolved Hide resolved


          [sonic_platform]Raise exception if any error occurs

47b3e6e

nazariig approved these changes

View reviewed changes

Owner Author

stephenxs commented Oct 9, 2019

Community PR opened [Mellanox]Resolve chassis broken due to inconsistent with latest sonic_platform_common #3569

stephenxs closed this

stephenxs deleted the update_firmware_version branch

October 10, 2019 00:31

stephenxs pushed a commit that referenced this pull request


          [sonic-utilities][sonic-ztp] Update submodules (sonic-net#4501)

46161ca

* src/sonic-utilities 7ce5b62...3471926 (4):
  > Make `config` command support abbreviation. (sonic-net#893)
  > [fwutil]: Fix firmware update command. (sonic-net#895)
  > [doc]: ZTP configuration and show commands (sonic-net#866)
  > Allow show ztp to display non-sensitive information visible to
  > non-root user (sonic-net#872)

* src/sonic-ztp 374c9e8...c959371 (2):
  > Fix ztp profile unit test (#14)
  > Create a shadow ZTP data json file accessible to non-root user (#13)

stephenxs pushed a commit that referenced this pull request


          [sonic-telemetry][sonic-mgmt-common] Update submodules (sonic-net#4986)

* src/sonic-telemetry fa8d498...3bd7ca3 (4):
  > Update gnmi deps (#40)
  > [testdata] Update SFP keys to align with new standard (#39)
  > Fixed the parameters for subscribe APIs (#38)
  > Azure ro mode (#34)

* src/sonic-mgmt-common 444aa9a...cc01ce4 (4):
  > Make gnmi dep version the same as in telemetry repo (#17)
  > Cleanup translib and cvl go test cases (#13)
  > Package update and enhancements/fixes in YGOT, and Request Binder (#12)
  > Translib phase I changes (#11)

Note: sonic-telemetry submodule update is dependent upon sonic-mgmt-common submodule update, thus updating both in this patch

stephenxs pushed a commit that referenced this pull request


          [BFN] Updated platform plugins (sonic-net#9540)

* [BFN] Updated platform APIs impl

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* Extended BFN platform SFP APIs implementation

* Update sfp.py

* [BFN] Extended SFP platform plugin implementation

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* [BFN] Extended Fans platform plugin implementation

* [BFN] divided classes Fan and  FanDrawer into 2 files

* Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

What I did
	Add get_model() function
	Add get_low_critical_threshold() function
	Change __get(...) function.
How I did it
	Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API

* Add get_presence() function and revised __get() function

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

* [BFN] Updated PSU platform APIs impl

Signed-off-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com>

* Added BFN PSU cache (#9)

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* [BFN]  Fans and Fantray platform APIs update (#7)

* [BFN] Updated SFP platform APIs (#10)

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>

* [BFN] Updated platform API for thermal (#8)

* Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

* Revert "[BFN]  Fans and Fantray platform APIs update (#7)" (#11)

This reverts commit c62a733.

* Add support health monitor system (#15)

Signed-off-by: Petro Bratash <petrox.bratash@intel.com>

* Update chassis.py

* [BFN] Updated FANs and FAN Tray platform API (#14)

* Fix fix_alignment (#17)

Signed-off-by: Petro Bratash <petrox.bratash@intel.com>

* [BFN] Improvement show environment (#16)

* Added PSU temperature skip into platform.json (#18)

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* Do not skip psud on Newport

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* [BFN] fix fan status from Not OK to Ok (#19)

* [BFN] Updated SFP platform plugin (#13)

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>

* [DPB] Fix typo for Ethernet0 2x200G[100G,40G] breakout mode (#21)

Signed-off-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com>

* [barefoot] Tmp fix vendor_rev (#22)

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>

* Fixed python issues in sonic_platform/fan_drawer.py

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* Updated fan_drawer.py

* Fixing trailing white spaces in fan_drawer.py

* [BFN] Fix thrift for SFPs API

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>

* In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* [Newport] Thermal manager  (#23)

* Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

* Revert "In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue"

This reverts commit 1e73127.

* Removed 'controllable' options from platform.json to fix factory default config generation

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

* Update thermal_manager.py

* Migrated SFP plugin to sonic_xcvr API (#30)

Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com>

Co-authored-by: KostiantynYarovyiBf <kostiantynx.yarovyi@intel.com>
Co-authored-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>
Co-authored-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com>
Co-authored-by: Volodymyr Boiko <volodymyrx.boiko@intel.com>
Co-authored-by: Petro Bratash <petrox.bratash@intel.com>
Co-authored-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com>

stephenxs pushed a commit that referenced this pull request


          [sonic-linkmgrd][master] submodule update sonic-net#9808

22e4b9b

[sonic-linkmgrd][master] submodule update

Commits added:
0c23756 Jing Zhang      2022-01-19      Linkmgrd subscribing State DB route event  (#13)
12b9951 Longxiang Lyu   2021-12-13      Add TLV support to ICMP payload (#11)
3eedda3 Longxiang Lyu   2022-01-06      Add missing intermediate states (#16)
8da4982 Ying Xie        2022-01-04      [linkmgrd] update README, set coding style guidance (#15)
a897cf8 Longxiang Lyu   2021-12-13      Improve PR template (#16)
6fec701 Jing Zhang      2021-12-06      Add pull request template for linkmgrd repo (#9)


signed-off-by: Jing Zhang zhangjing@microsoft.com

stephenxs pushed a commit that referenced this pull request


          [sonic-linkmgrd][202012] submodule update sonic-net#9807

b450cd1

[sonic-linkmgrd][master] submodule update

Commits added:
0c23756 Jing Zhang      2022-01-19      Linkmgrd subscribing State DB route event  (#13)
12b9951 Longxiang Lyu   2021-12-13      Add TLV support to ICMP payload (#11)
3eedda3 Longxiang Lyu   2022-01-06      Add missing intermediate states (#16)
8da4982 Ying Xie        2022-01-04      [linkmgrd] update README, set coding style guidance (#15)
a897cf8 Longxiang Lyu   2021-12-13      Improve PR template (#16)
6fec701 Jing Zhang      2021-12-06      Add pull request template for linkmgrd repo (#9)


signed-off-by: Jing Zhang zhangjing@microsoft.com

stephenxs pushed a commit that referenced this pull request


          [sonic-host-services]: Advance submodule (sonic-net#12195)

a0661e2

#### Why I did it
Update sonic-host-services submodule to include below commits:
```
bc8698d Merge pull request #21 from abdosi/feature
557a110 Fix the issue where if dest port is not specified in ACL rule than for multi-asic where we create NAT rule to forward traffic from Namespace to host fail with exception.
6e45acc (master) Merge pull request #14 from abdosi/feature
4d6cad7 Merge remote-tracking branch 'upstream/master' into feature
bceb13e Install libyang to azure pipeline (#20)
82299f5 Merge pull request #13 from SuvarnaMeenakshi/cacl_fabricns
15d3bf4 Merge branch 'master' into cacl_fabricns
de54082 Merge pull request #16 from ZhaohuiS/feature/caclmgrd_external_client_warning_log
b4b368d Add warning log if destination port is not defined
d4bb96d Merge branch 'master' into cacl_fabricns
35c76cb Add unit-test and fix typo.
17d44c2 Made Changes to be Python 3.7 compatible
978afb5 Aligning Code
1fbf8fb Merge remote-tracking branch 'upstream/master' into feature
7b8c7d1 Added UT for the changes
91c4c42 Merge pull request #9 from ZhaohuiS/feature/caclmgrd_external_client
7c0b56a Add 4 test cases for external_client_acl, including single port and port range for ipv4 and ipv6
b71e507 Merge remote-tracking branch 'origin/master' into HEAD
d992dc0 Merge branch 'master' into feature/caclmgrd_external_client
bd7b172 DST_PORT is configuralbe in json config file for EXTERNAL_CLIENT_ACL
f9af7ae [CLI] Move hostname, mgmt interface/vrf config to hostcfgd (#2)
70ce6a3 Merge pull request #10 from sujinmkang/cold_reset
29be8d2 Added Support to render Feature Table using Device running metadata. Also added support to render 'has_asic_scope' field of Feature Table.
3437e35 [caclmgrd][chassis]: Add ip tables rules to accept internal docker traffic from fabric asic namespaces.
8720561 Fix and add hardware reboot cause determination tests
0dcc7fe remove the empty bracket if no hardware reboot cause minor
e47d831 fix the wrong expected result comparision
ef86b53 Fix startswith Attribute error
8a630bb fix mock patch
8543ddf update the reboot cause logic and update the unit test
53ad7cd fix the mock patch function
7c8003d fix the reboot-cause regix for test
1ba611f fix typo
25379d3 Add unit test case
a56133b Add hardware reboot cause as actual reboot cause for soft reboot failed
c7d3833 Support Restapi/gnmi control plane acls
f6ea036 caclmgrd: Don't block traffic to mgmt by default
a712fc4 Update test cases
adc058b caclmgrd: Don't block traffic to mgmt by default
06ff918 Merge pull request #7 from bluecmd/patch-1
e3e23bc ci: Rename sonic-buildimage repository
e83a858 Merge pull request #4 from kamelnetworks/acl-ip2me-test
f5a2e50 [caclmgrd]: Tests for IP2ME rules generation
```

stephenxs pushed a commit that referenced this pull request


          [submodule] Update submodule dhcpmon to the latest HEAD automatically (…

cc6a9b6

…sonic-net#16550)

#### Why I did it
src/dhcpmon
```
* 7c55e50 - (HEAD -> master, origin/master, origin/HEAD) Merge pull request #13 from jcaiMR/dev/jcai_master_interface_counter (7 days ago) [StormLiangMS]
* 085a087 - refine counting logic (10 days ago) [jcaiMR]
* de96a98 - Merge branch 'master' into dev/jcai_master_interface_counter (11 days ago) [jcaiMR]
* 5cb4468 - dhcp per-interface counter init commit (12 days ago) [jcaiMR]
```
#### How I did it
#### How to verify it
#### Description for the changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet