Segfault in cmd_resize

[stromnet]

Please fill out the following:

• Sway Version:
  -sway version 1.6-a23cdbbe (Nov 23 2021, branch 'master')

• Debug Log:
  Unfortunately do not have debug log.

• Configuration File:
  The relevant command, as of my knowledge:

for_window [app_id="qalculate-gtk"] move to scratchpad
bindsym $mod+c exec pidof qalculate-gtk || qalculate-gtk ; [app_id="qalculate-gtk"] scratchpad show, resize set 1440 810, move position center

• Stack Trace:

* thread #1, name = 'sway', stop reason = signal SIGSEGV
  * frame #0: 0x000055d49fe66077 sway`cmd_resize(argc=<unavailable>, argv=<unavailable>) at resize.c:291:51
    frame #1: 0x000055d49fe36310 sway`execute_command(_exec=<unavailable>, seat=0x000055d4a22f6e00, con=0x0000000000000000) at commands.c:305:31
    frame #2: 0x000055d49fe596c6 sway`seat_execute_command(seat=0x000055d4a22f6e00, binding=0x000055d4a303f900) at bind.c:631:21
    frame #3: 0x000055d49fe4aa94 sway`handle_key_event(keyboard=0x000055d4a2c71970, event=0x00007ffe083f18f0) at keyboard.c:491:3
    frame #4: 0x00007fc36d4a9f9e libwlroots.so.10`wlr_signal_emit_safe(signal=0x000055d4a2fc6538, data=0x00007ffe083f18f0) at signal.c:29:3
    frame #5: 0x00007fc36d48b975 libwlroots.so.10`wlr_keyboard_notify_key(keyboard=0x000055d4a2fc6430, event=0x00007ffe083f18f0) at wlr_keyboard.c:96:2
    frame #6: 0x00007fc36d4a9f9e libwlroots.so.10`wlr_signal_emit_safe(signal=0x000055d4a24508e8, data=0x00007ffe083f18f0) at signal.c:29:3
    frame #7: 0x00007fc36d48b975 libwlroots.so.10`wlr_keyboard_notify_key(keyboard=0x000055d4a24507e0, event=0x00007ffe083f18f0) at wlr_keyboard.c:96:2
    frame #8: 0x00007fc36d469986 libwlroots.so.10`handle_libinput_readable(fd=<unavailable>, mask=<unavailable>, _backend=<unavailable>) at keyboard.c:82:2
    frame #9: 0x00007fc36d50104a libwayland-server.so.0`wl_event_loop_dispatch + 202
    frame #10: 0x00007fc36d4febc7 libwayland-server.so.0`wl_display_run + 39
    frame #11: 0x000055d49fe2fa03 sway`main [inlined] server_run(server=<unavailable>) at server.c:297:2
    frame #12: 0x000055d49fe2f9d4 sway`main(argc=<unavailable>, argv=<unavailable>) at main.c:428:2
    frame #13: 0x00007fc36d1fbb25 libc.so.6`__libc_start_main + 213
    frame #14: 0x000055d49fe2fdce sway`_start + 46
(lldb) up
frame #1: 0x000055d49fe36310 sway`execute_command(_exec=<unavailable>, seat=0x000055d4a22f6e00, con=0x0000000000000000) at commands.c:305:31
   302 				for (int i = 0; i < containers->length; ++i) {
   303 					struct sway_container *container = containers->items[i];
   304 					set_config_node(&container->node, true);
-> 305 					struct cmd_results *res = handler->handle(argc-1, argv+1);
   306 					if (res->status == CMD_SUCCESS) {
   307 						free_cmd_results(res);
   308 					} else {
(lldb) down
frame #0: 0x000055d49fe66077 sway`cmd_resize(argc=<unavailable>, argv=<unavailable>) at resize.c:291:51
   288 				if (parent) {
   289 					width->amount = parent->pending.width * width->amount / 100;
   290 				} else {
-> 291 					width->amount = con->pending.workspace->width * width->amount / 100;
   292 				}
   293 				width->unit = MOVEMENT_UNIT_PX;
   294 			}

• Description:
  This has happened a few times now, but very random. On $mod-c I have calculator app showing floating, $mod-c again to hide it. Normally works perfectly fine, but some times, it crashes just after disappearing. Now running with sway-git-aur, so managed to get useful stacktrace.
  Have not had opportunity to try to reproduce it.

[donnex]

I'm experiencing the exact same issue. Seems to be random and happens a few times every month.

I'm using binds like bindsym $mod+o [app_id="..."] scratchpad show, resize set 1600 900, move position center. The move and resize directives makes sure that my applications has the correct position and size when moving between different displays.

I've got a dump file saved if/when anyone wants to take a closer look at this issue.

[stromnet]

This is still a problem, happened yesterday and today while frequently jumping in and out of calculator juggling around numbers, resulting in shitload of workspaces going down and time to get back up running 😭

(lldb) bt
* thread #1, name = 'sway', stop reason = signal SIGSEGV
  * frame #0: 0x0000559b91559d17 sway`cmd_resize at resize.c:291:51
    frame #1: 0x0000559b91559c1a sway`cmd_resize at resize.c:449:9
    frame #2: 0x0000559b915598aa sway`cmd_resize at resize.c:557:10
    frame #3: 0x0000559b915595d4 sway`cmd_resize(argc=<unavailable>, argv=0x0000559b93b00f88) at resize.c:541:21
    frame #4: 0x0000559b91521e23 sway`execute_command(_exec=<unavailable>, seat=0x0000559b93423d40, con=0x0000000000000000) at commands.c:309:31
    frame #5: 0x0000559b9154d186 sway`seat_execute_command(seat=0x0000559b93423d40, binding=0x0000559b93428b80) at bind.c:632:21
    frame #6: 0x0000559b9153884b sway`handle_key_event(keyboard=0x0000559b934f4fd0, event=0x00007fff7420b8a0) at keyboard.c:489:3
    frame #7: 0x00007fc3af171f6e libwayland-server.so.0`wl_signal_emit_mutable + 126
    frame #8: 0x00007fc3af0d8b35 libwlroots.so.12`wlr_keyboard_notify_key(keyboard=0x0000559b934dad40, event=0x00007fff7420b8a0) at wlr_keyboard.c:102:2
    frame #9: 0x00007fc3af171f6e libwayland-server.so.0`wl_signal_emit_mutable + 126
    frame #10: 0x00007fc3af0d8b35 libwlroots.so.12`wlr_keyboard_notify_key(keyboard=0x0000559b937b92b8, event=0x00007fff7420b8a0) at wlr_keyboard.c:102:2
    frame #11: 0x00007fc3af0ae3de libwlroots.so.12`handle_libinput_readable at keyboard.c:54:2
    frame #12: 0x00007fc3af0ae36c libwlroots.so.12`handle_libinput_readable at events.c:165:3
    frame #13: 0x00007fc3af0ae2fb libwlroots.so.12`handle_libinput_readable at backend.c:58:3
    frame #14: 0x00007fc3af0ae2e0 libwlroots.so.12`handle_libinput_readable(fd=<unavailable>, mask=<unavailable>, _backend=0x0000559b92addda0) at backend.c:48:12
    frame #15: 0x00007fc3af1739e2 libwayland-server.so.0`wl_event_loop_dispatch + 162
    frame #16: 0x00007fc3af174197 libwayland-server.so.0`wl_display_run + 39
    frame #17: 0x0000559b9151ab81 sway`main [inlined] server_run(server=<unavailable>) at server.c:332:2
    frame #18: 0x0000559b9151ab4e sway`main(argc=<unavailable>, argv=0x00007fff7420bd68) at main.c:415:2
    frame #19: 0x00007fc3aee10790 libc.so.6`___lldb_unnamed_symbol3140 + 128
    frame #20: 0x00007fc3aee1084a libc.so.6`__libc_start_main + 138
    frame #21: 0x0000559b9151b055 sway`_start + 37

sway version 1.9-dev-7d0351b4 (Feb 6 2023, branch 'master')

edit: updated original post to include for_window [app_id="qalculate-gtk"] move to scratchpad

[bretello]

I've been encountering the issue as well, and I've been able to narrow it down to the following minimal configuration plus reproduction script.

Basically under these conditions, splitting a (visible) scratchpad window and then hiding it results in a segfault (tested on 1.8 and master).

Sway Configuration:

include /etc/sway/config

# define hotkey window criteria
# note that the crash happens on the resize set command, move does not really matter
for_window [app_id="hotkey-terminal"] move to scratchpad, scratchpad show, resize set width 100 ppt height 45 ppt, move position 0 0

Reproduction script:

#!/bin/sh
swaymsg exec -- alacritty --class "hotkey-terminal"

# let alacritty start
sleep 0.5

# split the newly created container
swaymsg split toggle

# try to hide it
swaymsg '[app_id="hotkey-terminal"] scratchpad show, resize set width 100 ppt height 45 ppt'

See the above PR for a fix proposal.