[gui] Force GGUI to go through host memory (nuking interops) #7218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bobcao3
force-pushed
the
ggui-features
branch
from
dde614c to
960e93c
Compare
bobcao3
force-pushed
the
ggui-features
branch
2 times, most recently
from
4521243 to
8fa7db0
Compare
|
nit: Do you plan to break this PR down? |
I will put all the RHI changes / bug fixes in their own PR, and then the GGUI changes kind of have to be a big blob to pass all tests. I think that change set would be around +750 lines. I can seperate them through ghstack perhaps but individual ones won't pass CI. |
bobcao3
added a commit
that referenced
this pull request
Jan 24, 2023
Related: #7218 Without this GGUI will mess with the OpenGL backend because both tries to initialize & destroy GLFW. There is an issue tho with dependency. Which target should `rhi/window_system` belong to? Maybe we need a device API target that collects all the specific backends and generate a static lib with all backends and optional dependencies like GLFW? (Anyways, that will be a TODO for another PR) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
bobcao3
force-pushed
the
ggui-features
branch
2 times, most recently
from
59af181 to
ef5c547
Compare
This was referenced Jan 25, 2023
bobcao3
force-pushed
the
ggui-features
branch
2 times, most recently
from
7496337 to
c890284
Compare
bobcao3
force-pushed
the
ggui-features
branch
2 times, most recently
from
eb839a2 to
f39bdef
Compare
k-ye
pushed a commit
that referenced
this pull request
Jan 26, 2023
bobcao3
added a commit
that referenced
this pull request
Jan 26, 2023
bobcao3
force-pushed
the
ggui-features
branch
from
6f6a02d to
de65271
Compare
PENGUINLIONG
approved these changes
Jan 28, 2023
There was a problem hiding this comment.
lgtm, @ailzhang and @AmesingFlank might wanna double check this huge pr.
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Related: taichi-dev#7218 Without this GGUI will mess with the OpenGL backend because both tries to initialize & destroy GLFW. There is an issue tho with dependency. Which target should `rhi/window_system` belong to? Maybe we need a device API target that collects all the specific backends and generate a static lib with all backends and optional dependencies like GLFW? (Anyways, that will be a TODO for another PR) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…#7234) Part of taichi-dev#7218 Related (ndarray meta-programming): taichi-dev#7231 I would certainly like to share this code between the field vesion and NDArray version Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…dev#7218) Issue: # Contains: - [x] taichi-dev#7230 - [x] taichi-dev#7232 - [x] taichi-dev#7233 - [x] taichi-dev#7234 Merge those before this PR (to reduce the size of the change set) ### Brief Summary Nuking all interops, in order to reduce code complexity of GGUI & provide path ways to other rendering frontends (e.g. metal) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
Contains:
Merge those before this PR (to reduce the size of the change set)
Brief Summary
Nuking all interops, in order to reduce code complexity of GGUI & provide path ways to other rendering frontends (e.g. metal)