Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] Use templated bulk copy to simplify VBO preperation #7234

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Jan 25, 2023

Part of #7218

Related (ndarray meta-programming): #7231
I would certainly like to share this code between the field vesion and NDArray version

@bobcao3 bobcao3 requested review from k-ye and AmesingFlank January 25, 2023 20:12
@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit acae144
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63d18d69205922000930636a
😎 Deploy Preview https://deploy-preview-7234--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bobcao3 bobcao3 requested a review from ailzhang January 25, 2023 20:12
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobcao3 bobcao3 merged commit 73d1186 into taichi-dev:master Jan 26, 2023
ailzhang pushed a commit that referenced this pull request Jan 29, 2023
Issue: #

Contains:
- [x] #7230
- [x] #7232
- [x] #7233
- [x] #7234
Merge those before this PR (to reduce the size of the change set)

### Brief Summary

Nuking all interops, in order to reduce code complexity of GGUI &
provide path ways to other rendering frontends (e.g. metal)

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
…#7234)

Part of taichi-dev#7218

Related (ndarray meta-programming): taichi-dev#7231
I would certainly like to share this code between the field vesion and
NDArray version

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
…dev#7218)

Issue: #

Contains:
- [x] taichi-dev#7230
- [x] taichi-dev#7232
- [x] taichi-dev#7233
- [x] taichi-dev#7234
Merge those before this PR (to reduce the size of the change set)

### Brief Summary

Nuking all interops, in order to reduce code complexity of GGUI &
provide path ways to other rendering frontends (e.g. metal)

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants