-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gui] Use templated bulk copy to simplify VBO preperation #7234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
4 tasks
k-ye
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
k-ye
reviewed
Jan 26, 2023
ailzhang
pushed a commit
that referenced
this pull request
Jan 29, 2023
Issue: # Contains: - [x] #7230 - [x] #7232 - [x] #7233 - [x] #7234 Merge those before this PR (to reduce the size of the change set) ### Brief Summary Nuking all interops, in order to reduce code complexity of GGUI & provide path ways to other rendering frontends (e.g. metal) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…#7234) Part of taichi-dev#7218 Related (ndarray meta-programming): taichi-dev#7231 I would certainly like to share this code between the field vesion and NDArray version Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…dev#7218) Issue: # Contains: - [x] taichi-dev#7230 - [x] taichi-dev#7232 - [x] taichi-dev#7233 - [x] taichi-dev#7234 Merge those before this PR (to reduce the size of the change set) ### Brief Summary Nuking all interops, in order to reduce code complexity of GGUI & provide path ways to other rendering frontends (e.g. metal) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7218
Related (ndarray meta-programming): #7231
I would certainly like to share this code between the field vesion and NDArray version