[opengl] Fix GLFW global context issue #7230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
for more information, see https://pre-commit.ci
✅ Deploy Preview for docsite-preview canceled.
|
✅ Deploy Preview for docsite-preview canceled.
|
k-ye
reviewed
Jan 23, 2023
k-ye
approved these changes
Jan 24, 2023
ailzhang
pushed a commit
that referenced
this pull request
Jan 29, 2023
Issue: # Contains: - [x] #7230 - [x] #7232 - [x] #7233 - [x] #7234 Merge those before this PR (to reduce the size of the change set) ### Brief Summary Nuking all interops, in order to reduce code complexity of GGUI & provide path ways to other rendering frontends (e.g. metal) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Related: taichi-dev#7218 Without this GGUI will mess with the OpenGL backend because both tries to initialize & destroy GLFW. There is an issue tho with dependency. Which target should `rhi/window_system` belong to? Maybe we need a device API target that collects all the specific backends and generate a static lib with all backends and optional dependencies like GLFW? (Anyways, that will be a TODO for another PR) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…dev#7218) Issue: # Contains: - [x] taichi-dev#7230 - [x] taichi-dev#7232 - [x] taichi-dev#7233 - [x] taichi-dev#7234 Merge those before this PR (to reduce the size of the change set) ### Brief Summary Nuking all interops, in order to reduce code complexity of GGUI & provide path ways to other rendering frontends (e.g. metal) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #7218
Without this GGUI will mess with the OpenGL backend because both tries to initialize & destroy GLFW.
There is an issue tho with dependency. Which target should
rhi/window_systembelong to? Maybe we need a device API target that collects all the specific backends and generate a static lib with all backends and optional dependencies like GLFW? (Anyways, that will be a TODO for another PR)