-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat behavior velocity occlusion spot more efficient #15
Feat behavior velocity occlusion spot more efficient #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
} | ||
imageToOccupancyGrid(cv_image, &occupancy_grid); | ||
imageToOccupancyGrid(border_image, &occupancy_grid); | ||
grid_map::GridMapRosConverter::fromOccupancyGrid(occupancy_grid, "layer", grid_map); | ||
} | ||
} // namespace grid_utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nested namespaces can be concatenated
} // namespace grid_utils | |
} |
planning/behavior_velocity_planner/src/scene_module/occlusion_spot/grid_utils.cpp
Show resolved
Hide resolved
planning/behavior_velocity_planner/src/scene_module/occlusion_spot/grid_utils.cpp
Show resolved
Hide resolved
planning/behavior_velocity_planner/src/scene_module/occlusion_spot/grid_utils.cpp
Show resolved
Hide resolved
planning/behavior_velocity_planner/test/src/test_grid_utils.cpp
Outdated
Show resolved
Hide resolved
7d697a5
to
cc9cf59
Compare
@@ -80,77 +80,21 @@ void addObjectsToGridMap(const std::vector<PredictedObject> & objs, grid_map::Gr | |||
} | |||
} | |||
|
|||
bool isOcclusionSpotSquare( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is already alll the occlusion candiate created from eroded occlusion image so no need to find
3729130
to
e70e41c
Compare
} | ||
//!< @brief erode occlusion to make sure occlusion candidates are big enough | ||
cv::Mat kernel(2, 2, CV_8UC1, cv::Scalar(1)); | ||
cv::erode(occlusion_image, occlusion_image, kernel, cv::Point(-1, -1), num_iter); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
control occlusion spot size by the number of iteration
cv::moveWindow("morph", 0, 300); | ||
} | ||
|
||
border_image += occlusion_image; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge eroded occlision image and free space + occupied image here
…ndation#760) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…arefoundation#755) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…undation#756) * fix(behavior_path_planner): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…owarefoundation#757) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…arefoundation#761) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…tion#758) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…towarefoundation#774) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
@@ -97,6 +98,7 @@ struct PlannerData | |||
// additional parameters | |||
double max_stop_acceleration_threshold; | |||
double max_stop_jerk_threshold; | |||
double system_delay; | |||
double delay_response_time; | |||
double stop_line_extend_length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constructor does not initialize these fields: stop_line_extend_length, accel_lowpass_gain_
double stop_line_extend_length; | |
double stop_line_extend_length{}; |
cv::waitKey(1); | ||
} | ||
//!< @brief erode occlusion to make sure occlusion candidates are big enough | ||
cv::Mat kernel(2, 2, CV_8UC1, cv::Scalar(1)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of a signed integer operand with a binary bitwise operator
@@ -215,3 +148,30 @@ TEST(compareTime, polygon_vs_line_iterator) | |||
count = 0; | |||
} | |||
} | |||
|
|||
TEST(test, erode_with_custom_kernel) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class test_erode_with_custom_kernel_Test
defines a copy constructor and a copy assignment operator but does not define a destructor, a move constructor or a move assignment operator
TEST(test, erode_with_custom_kernel) | ||
{ | ||
cv::Mat image; | ||
cv::Mat cv_image(100, 100, CV_8UC1, cv::Scalar(0)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of a signed integer operand with a binary bitwise operator
// cv::namedWindow("original", cv::WINDOW_NORMAL); | ||
// cv::imshow("original", cv_image); | ||
// cv::waitKey(100); | ||
cv::Mat kernel(2, 2, CV_8UC1, cv::Scalar(1)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of a signed integer operand with a binary bitwise operator
…arefoundation#759) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…tion#718) * fix(autoware_auto_common): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix(autoware_auto_tf2): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix(autoware_auto_geometry): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix(simple_planning_simulator): add compile definition for geometry2 Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix(motion_common): add compile definition for geometry2 Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix(motion_testing): add compile definition for geometry2 Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix(simple_planning_simulator): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…efoundation#716) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…towarefoundation#775) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…on#762) * fix(fault_injection): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…ndation#785) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…ndation#784) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…tion#781) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…ndation#780) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…tion#783) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…ion#778) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…n#776) * fix(osqp_interface): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add comment about find_package order Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…utowarefoundation#789) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…undation#787) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…ctory (autowarefoundation#729) * Add unit test showcasing the issue Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> * Fix filterPointCloudByTrajectory Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> * Add NOLINT for direct include of .cpp file Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…utowarefoundation#806) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…warefoundation#808) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
* fix(stop_filter): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
…refoundation#799) * fix(behavior_velocity_planner): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* ci(pre-commit): autoupdate updates: - [github.com/tier4/pre-commit-hooks-ros: v0.6.0 → v0.7.0](tier4/pre-commit-hooks-ros@v0.6.0...v0.7.0) - [github.com/pre-commit/mirrors-clang-format: v13.0.1 → v14.0.1](pre-commit/mirrors-clang-format@v13.0.1...v14.0.1) * Update .pre-commit-config.yaml Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
…eriod parameter (autowarefoundation#763) * perf(trajectory_follower_nodes): change longitudinal control to use period parameter Signed-off-by: Shark Liu <shark.liu@autocore.ai> * perf(trajectory_follower_nodes): remove duplicate ros parameters in 'control.launch.py' Signed-off-by: Shark Liu <shark.liu@autocore.ai> * doc(trajectory_follower_nodes): update design doc according to code update Signed-off-by: Shark Liu <shark.liu@autocore.ai> * ci(pre-commit): autofix Co-authored-by: Shark Liu <shark.liu@autocore.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…towarefoundation#811) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…utowarefoundation#769) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* feat(default_ad_api): add interface version Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): add http server Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): add message readme Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): modify message readme Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): fix message type Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): fix message type Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): remove unused message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(component_interface_utils): use full path Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(component_interface_utils): rename package Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(autoware_ad_api_msgs): remove unused message Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(component_interface_utils): add readme and comments Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat(default_ad_api): fix api name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Update common/autoware_ad_api_msgs/README.md Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * add test Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix server name Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * Add comment Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix typo * rename version api * Update system/default_ad_api/package.xml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update common/component_interface_utils/include/component_interface_utils/rclcpp/create_interface.hpp Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Update system/default_ad_api/launch/default_ad_api.launch.py Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Fix for renaming web server script * Fix test script for readability * Fix test script for readability * Add comment Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
…autowarefoundation#764) * chore(behavior_velocity): add system delay parameter and minor update Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * doc(behavior_velocity): add system delay discription Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
…utowarefoundation#818) this is happens whenever intersection is involved. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…autowarefoundation#728) * fix(behavior_path_planner): fix the condition of turn signal lighting Signed-off-by: k-obitsu <koichi.obitsu@tier4.jp> * fix(behavior_path_planner): fix the condition of turn signal lighting Signed-off-by: k-obitsu <koichi.obitsu@tier4.jp> * ci(pre-commit): autofix * Update planning/behavior_path_planner/src/turn_signal_decider.cpp Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
…utowarefoundation#807) * feat(obstacle_avoidance_planner): parameterize bounds search widths Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update bounds search widths Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update tier4_planning_launch Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Added parameter description of README.md Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…efoundation#767) * feat(map_based_prediction): upgrade yaw difference tolerance Signed-off-by: yutaka <purewater0901@gmail.com> * Update perception/map_based_prediction/src/map_based_prediction_node.cpp Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * fix format Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
…undation#804) * fix(pointcloud_preprocessor): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix(ground_segmentation): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix(compare_map_segmentation): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix(occupancy_grid_map_outlier_filter): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix(euclidean_cluster): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix(detection_by_tracker): modify build error in rolling Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix(component_interface_utils): add USE_DEPRECATED_TO_YAML Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix(lidar_apollo_instance_segmentation): add USE_TF2_GEOMETRY_MSGS_DEPRECATED_HEADER Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add rclcpp_components to package.xml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…foundation#823) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
…owarefoundation#694) * feat(behavior_path_planner): debug message for avoidance Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix: make_shared for the pointers Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * chore: pre-commit Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix: remove related DEBUG_PRINT Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * chore: naming, add debug to the variable name This is so that people can infer mutable to debug, therefore reducing the amount of time for debugging other things Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix: object id is written as string instead of uint8x16 Also fix getUuidStr function to reflect the actual hex value. the function is moved to avoidance_util as it better served as helper function. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * chore: fix spelling Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix: display all 32 uuid characters Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * chore: remove unnecessary header Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * feat: support more debug message Note: need further refactoring, due to multiple similar code, plus duplicate printing. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix mutiplication by introducing global variables Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * header stamp to get the clock Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix: renaming the type to show clearer intent of the type Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
* Activate by location Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp> * Fix markdown Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
e70e41c
to
511510f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
@@ -98,7 +98,7 @@ TEST(calcSlowDownPointsForPossibleCollision, ConsiderSignedOffset) | |||
std::cout << "v : " << path.points[i].point.longitudinal_velocity_mps << "\t"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use range-based for loop instead
std::cout << "v : " << path.points[i].point.longitudinal_velocity_mps << "\t"; | |
std::cout << "v : " << point.point.longitudinal_velocity_mps << "\t"; |
OccupnacyGrid is divided to freespace+occupied image & occlusion image(eroded)
this can remove grid map occlusion size search and remove sensing noise