feat: turn off node metrics by default #6073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)1 264 tests 1 264 ✅ 11m 3s ⏱️ Results for commit 6dbe3a0. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
brianp
changed the title
It is strange we need to leave metrics on in the integration tests. This is mostly because clippy is often run with `--all-features` which means metrics would be on in the node, and then required in the integration configuration.
brianp
force-pushed
the
feat-node-metrics-opt-in
branch
from
50bd771 to
6dbe3a0
Compare
SWvheerden
reviewed
Jan 12, 2024
| @@ -52,7 +52,7 @@ tonic = { version = "0.6.2", features = ["tls", "tls-roots" ] } | |||
| tari_metrics = { path = "../../infrastructure/metrics", optional = true, features = ["server"] } | |||
|
|
|||
| [features] | |||
| default = ["metrics", "libtor"] | |||
| default = ["libtor"] | |||
There was a problem hiding this comment.
With this PR, we need to ensure that the seed nodes turn this on
SWvheerden
approved these changes
Feb 8, 2024
ghpbot-tari-project
removed
the
P-reviews_required
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Feb 15, 2024
* development: (120 commits) chore: use log4rs 1.3 (tari-project#6148) fix: balanced binary merkle tree merged proof (tari-project#6144) chore(deps): bump libgit2-sys from 0.16.1+1.7.1 to 0.16.2+1.7.2 (tari-project#6145) feat: allow ffi to see lock height (tari-project#6140) chore(ci): add metrics targeted build, remove miner artifacts, misc clean ups (tari-project#6141) chore: suppress error (tari-project#6137) chore: fix versions to correct version (tari-project#6135) chore: add stringhandler gpg (tari-project#6134) chore: add pgp public key (tari-project#6139) feat: turn off node metrics by default (tari-project#6073) feat: add import tx method (tari-project#6132) chore: update pgp public key (tari-project#6129) chore: new testnet release (tari-project#6127) chore: update pgp key (tari-project#6128) fix(libtor): prevent metrics port conflict (tari-project#6125) fix(comms): correctly initialize hidden service (tari-project#6124) chore: make MAC equality check more idiomatic (tari-project#6123) chore: new release (tari-project#6120) fix: restart tx fix (tari-project#6119) chore: suppress warn log (tari-project#6118) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This make the node metrics opt-in instead of opt-out at compile time.
It is strange we need to leave metrics on in the integration tests. This
is mostly because clippy is often run with
--all-featureswhich meansmetrics would be on in the node, and then required in the integration
configuration.
Closes: #5787
Motivation and Context
Mostly the metrics library has a chance of failure (panics) and it's generally better (and more private) if we just have metrics off by default.
How Has This Been Tested?
CI
Breaking Changes