Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: suppress error #6137

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Suppress error in size of lmdb if it gets a db to small error. This makes the user see the following log:

18:10 WARN  Check for updates has been called but auto update has been disabled in the config
18:10 WARN  0.0% of this node's 8 connections are using TCPv4. This node requires at least 10.0% of nodes to be TCP nodes.
18:10 v1.0.0-rc.4 nextnet State: Syncing headers: (133e3da09fefeb6a) 30786/39718 (77%) 87.46 blks/s, latency: 11.43ms Tip: 0 (Tue, 12 Dec 2023 16:10:00 +0000) Mempool: 0tx (0g, +/- 0blks) Connections: 8|0 Banned: 0 Messages (last 60s): 23 Rpc: 0/100 RandomX: #0 with flags FLAG_HARD_AES | FLAG_JIT | FLAG_SECURE
18:10 ERROR Could not insert 797 bytes with key '7e76000000000000' into 'headers_db' (Err(Error::Code(-30792, 'MDB_MAP_FULL: Environment mapsize limit reached')))
18:10 v1.0.0-rc.4 nextnet State: Syncing headers: (133e3da09fefeb6a) 31085/39718 (78%) 50.26 blks/s, latency: 19.90ms Tip: 0 (Tue, 12 Dec 2023 16:10:00 +0000) Mempool: 0tx (0g, +/- 0blks) Connections: 8|0 Banned: 0 Messages (last 60s): 22 Rpc: 0/100
18:10 v1.0.0-rc.4 nextnet State: Syncing headers: (133e3da09fefeb6a) 31396/39718 (79%) 54.31 blks/s, latency: 18.41ms Tip: 0 (Tue, 12 Dec 2023 16:10:00 +0000) Mempool: 0tx (0g, +/- 0blks) Connections: 8|0 Banned: 0 Messages (last 60s): 23 Rpc: 0/100

There is no actual error. The transaction wrapper correctly handles this and increases the db size and then reapplies the transaction

@SWvheerden SWvheerden requested a review from a team as a code owner February 7, 2024 16:28
Copy link

github-actions bot commented Feb 7, 2024

Test Results (CI)

1 270 tests   1 270 ✅  12m 46s ⏱️
   39 suites      0 💤
    1 files        0 ❌

Results for commit ae73d15.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

Test Results (Integration tests)

29 tests  +29   29 ✅ +29   12m 12s ⏱️ + 12m 12s
11 suites +11    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 

Results for commit ae73d15. ± Comparison against base commit 9a7fcd6.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Feb 8, 2024
@SWvheerden SWvheerden merged commit 0e9877e into tari-project:development Feb 8, 2024
13 of 14 checks passed
sdbondi added a commit to sdbondi/tari that referenced this pull request Feb 15, 2024
* development: (120 commits)
  chore: use log4rs 1.3 (tari-project#6148)
  fix: balanced binary merkle tree merged proof (tari-project#6144)
  chore(deps): bump libgit2-sys from 0.16.1+1.7.1 to 0.16.2+1.7.2 (tari-project#6145)
  feat: allow ffi to see lock height (tari-project#6140)
  chore(ci): add metrics targeted build, remove miner artifacts, misc clean ups (tari-project#6141)
  chore: suppress error (tari-project#6137)
  chore: fix versions to correct version (tari-project#6135)
  chore: add stringhandler gpg (tari-project#6134)
  chore: add pgp public key (tari-project#6139)
  feat: turn off node metrics by default (tari-project#6073)
  feat: add import tx method (tari-project#6132)
  chore: update pgp public key (tari-project#6129)
  chore: new testnet release (tari-project#6127)
  chore: update pgp key (tari-project#6128)
  fix(libtor): prevent metrics port conflict (tari-project#6125)
  fix(comms): correctly initialize hidden service (tari-project#6124)
  chore: make MAC equality check more idiomatic (tari-project#6123)
  chore: new release (tari-project#6120)
  fix: restart tx fix (tari-project#6119)
  chore: suppress warn log (tari-project#6118)
  ...
@SWvheerden SWvheerden deleted the sw_supress_error branch February 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants