feat: add import tx method #6132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)1 270 tests 1 270 ✅ 16m 57s ⏱️ Results for commit 915f54e. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 11 suites 12m 27s ⏱️ For more details on these failures, see this check. Results for commit 915f54e. |
ghpbot-tari-project
removed
the
P-reviews_required
brianp
approved these changes
Feb 7, 2024
| @@ -501,6 +502,8 @@ mod test { | |||
|
|
|||
| export-tx 123456789 --output-file pie.txt | |||
|
|
|||
| import-tx --input-file pie_this_message.txt | |||
There was a problem hiding this comment.
What's the significance of pie
There was a problem hiding this comment.
No idea...
Its a random word I use
|
So the export code only currently supports exporting a single tx. |
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Feb 15, 2024
* development: (120 commits) chore: use log4rs 1.3 (tari-project#6148) fix: balanced binary merkle tree merged proof (tari-project#6144) chore(deps): bump libgit2-sys from 0.16.1+1.7.1 to 0.16.2+1.7.2 (tari-project#6145) feat: allow ffi to see lock height (tari-project#6140) chore(ci): add metrics targeted build, remove miner artifacts, misc clean ups (tari-project#6141) chore: suppress error (tari-project#6137) chore: fix versions to correct version (tari-project#6135) chore: add stringhandler gpg (tari-project#6134) chore: add pgp public key (tari-project#6139) feat: turn off node metrics by default (tari-project#6073) feat: add import tx method (tari-project#6132) chore: update pgp public key (tari-project#6129) chore: new testnet release (tari-project#6127) chore: update pgp key (tari-project#6128) fix(libtor): prevent metrics port conflict (tari-project#6125) fix(comms): correctly initialize hidden service (tari-project#6124) chore: make MAC equality check more idiomatic (tari-project#6123) chore: new release (tari-project#6120) fix: restart tx fix (tari-project#6119) chore: suppress warn log (tari-project#6118) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows users to import an exported transaction to their wallet.
Motivation and Context
This allows true cold mining. A wallet can export any transaction, and it can then be imported to any transaction which will monitor and ensure the transaction is broadcasted to the network.
How Has This Been Tested?
unit tests and manual