Added timeout configs and variables to aws_eks_cluster resource #149

RGPosadas · 2018-10-02T17:05:04Z

PR o'clock

Description

Added timeout configs to the aws_eks_cluster resource.

Test Result

I set the timeouts to 1m to test for failure (could not test timeout for more than default time since it is unpredictable when it would happen). Here are the results:

1 error(s) occurred:
TestEKS 2018-10-02T12:32:30-04:00 command.go:100: 
TestEKS 2018-10-02T12:32:30-04:00 command.go:100: * module.test_eks_module.module.eks.aws_eks_cluster.this: 1 error(s) occurred:
TestEKS 2018-10-02T12:32:30-04:00 command.go:100: 
TestEKS 2018-10-02T12:32:30-04:00 command.go:100: * aws_eks_cluster.this: timeout while waiting for state to become 'ACTIVE' (last state: 'CREATING', timeout: 1m0s)

`README.md` Changes

I tried to update README.md using terraform-docs and the given lines of code, but that ended up erasing the whole file for me. So I added in the new variables manually.

Checklist

terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
Tests for the changes have been added and passing (for bug fixes/features)
Test results are pasted in this PR (in lieu of CI)
Docs have been updated using terraform-docs per README.md instructions
I've added my change to CHANGELOG.md
Any breaking changes are highlighted above

laverya · 2018-10-02T22:07:54Z

I think it might be best if you merge master into this branch before going much farther - it looks like your branch is off of b6f6a82, and there have been a number of changelog additions since then. (which is causing the merge conflict)

I like the change though! I've certainly run into the create timeout before.

Re: README.md, what version of terraform-docs (and go, and the os...) are you running? I just tried generating the docs again with this set of commands:

go get -u github.com/segmentio/terraform-docs
terraform-docs md ./ | cat -s | tail -r | tail -n +2 | tail -r > README.md

and had no differences.

mmcaya

👍 to having this capability, small note on variable naming inline

mmcaya · 2018-10-03T12:37:26Z

variables.tf

@@ -123,3 +123,13 @@ variable "kubeconfig_name" {
  description = "Override the default name used for items kubeconfig."
  default     = ""
 }
+
+variable "aws_eks_cluster_create_timeout" {


For consistency with other cluster_* related variables and readability (e.g. cluster_version, should these be named cluster_create_timeout and cluster_delete_timeout?

Sure, I'll change it

RGPosadas · 2018-10-03T12:50:44Z

Hey @laverya !
I synced up my fork with master and resolved the merge conflict.

mmcaya · 2018-10-03T12:56:07Z

Thanks @RGPosadas, README.md should also be updated to reflect the new var names.

RGPosadas · 2018-10-03T13:38:13Z

I updated README.md!

Also re: README.md, had to change tail -r to tac in

go get -u github.com/segmentio/terraform-docs
terraform-docs md ./ | cat -s | tac | tail -n +2 | tac > README.md

and it worked.

max-rocket-internet · 2018-10-04T12:48:34Z

Thanks for your first contribution @RGPosadas!

I just fixed the travis error in master, could you rebase so we can get it to pass? Thanks!

…raform-aws-eks into Expose-Timeout-Configs

RGPosadas · 2018-10-04T13:21:06Z

@max-rocket-internet done!
And it was a pleasure to contribute! 😄

* upstream/master: (25 commits) Update documentation for removed `configure_kubectl_session` (terraform-aws-modules#171) remove the checksum step Add target_group_arns to worker ASG (terraform-aws-modules#167) Removing 2 providers from the module (terraform-aws-modules#168) Removing aws_iam_service_linked_role from module (terraform-aws-modules#160) Adjust the order and correct/update the info (terraform-aws-modules#163) Ruby ver `2.4.2` -> `2.4.4` Move env vars into env section Remove `v` in `v0.11.8` Better version control Add suspended_processes attributes to autoscaling_group (terraform-aws-modules#159) Updating changelog for v1.7.0 (terraform-aws-modules#158) Revert "Add suspended_processes attributes to autoscaling_group (terraform-aws-modules#153)" (terraform-aws-modules#157) Add suspended_processes attributes to autoscaling_group (terraform-aws-modules#153) Add option to change worker placement_tenancy. (terraform-aws-modules#142) Allowing 443 to nodes from EKS service (terraform-aws-modules#148) Fixed issue with 'workers_group_defaults_defaults.iam_role_id' and added explicit depends_on for 'update_config_map_aws_auth' (terraform-aws-modules#147) Added timeout configs and variables to aws_eks_cluster resource (terraform-aws-modules#149) Fixing travis config (terraform-aws-modules#151) Fix for ERROR: 'aws_iam_instance_profile.workers' not found (terraform-aws-modules#141) ...

…aform-aws-modules#149) * Added timeout configs and variables * Updated CHANGELOG and README * Added timeout configs and variables * Updated CHANGELOG and README * Changed variable names for consistency * Updated README.md * Did terraform fmt

github-actions · 2022-11-24T02:20:59Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Ritchelle Posadas added 2 commits October 2, 2018 12:09

Added timeout configs and variables

609f246

Updated CHANGELOG and README

726a17b

Ritchelle Posadas added 3 commits October 3, 2018 08:17

Added timeout configs and variables

04091cb

Updated CHANGELOG and README

735788b

Fix merge conflict

156edbd

mmcaya reviewed Oct 3, 2018

View reviewed changes

Changed variable names for consistency

b6f26cf

Updated README.md

0eca8cb

Ritchelle Posadas added 2 commits October 4, 2018 08:57

Merge branch 'master' of https://github.com/terraform-aws-modules/ter…

1be45ee

…raform-aws-eks into Expose-Timeout-Configs

Did terraform fmt

a0bccc7

max-rocket-internet approved these changes Oct 4, 2018

View reviewed changes

max-rocket-internet merged commit 0ee9d63 into terraform-aws-modules:master Oct 4, 2018

github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added timeout configs and variables to aws_eks_cluster resource #149

Added timeout configs and variables to aws_eks_cluster resource #149

RGPosadas commented Oct 2, 2018 •

edited

Loading

laverya commented Oct 2, 2018

mmcaya left a comment

mmcaya Oct 3, 2018

RGPosadas Oct 3, 2018

RGPosadas commented Oct 3, 2018

mmcaya commented Oct 3, 2018

RGPosadas commented Oct 3, 2018 •

edited

Loading

max-rocket-internet commented Oct 4, 2018

RGPosadas commented Oct 4, 2018

github-actions bot commented Nov 24, 2022

Added timeout configs and variables to aws_eks_cluster resource #149

Added timeout configs and variables to aws_eks_cluster resource #149

Conversation

RGPosadas commented Oct 2, 2018 • edited Loading

PR o'clock

Description

Test Result

README.md Changes

Checklist

laverya commented Oct 2, 2018

mmcaya left a comment

Choose a reason for hiding this comment

mmcaya Oct 3, 2018

Choose a reason for hiding this comment

RGPosadas Oct 3, 2018

Choose a reason for hiding this comment

RGPosadas commented Oct 3, 2018

mmcaya commented Oct 3, 2018

RGPosadas commented Oct 3, 2018 • edited Loading

max-rocket-internet commented Oct 4, 2018

RGPosadas commented Oct 4, 2018

github-actions bot commented Nov 24, 2022

RGPosadas commented Oct 2, 2018 •

edited

Loading

`README.md` Changes

RGPosadas commented Oct 3, 2018 •

edited

Loading