Removing aws_iam_service_linked_role from module

[max-rocket-internet]

PR o'clock

Description

Removing this resource. I think it's not required and seems to be the source of various errors anyway.

It was added here: #91

And issues here:
#132
#144

If anyone gets an error about removing the aws_iam_service_linked_role.elasticloadbalancing resource, I think you can just remove it from the state: terraform state rm aws_iam_service_linked_role.elasticloadbalancing

Checklist

• terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
• Tests for the changes have been added and passing (for bug fixes/features)
• Test results are pasted in this PR (in lieu of CI)
• Docs have been updated using terraform-docs per README.md instructions
• I've added my change to CHANGELOG.md
• Any breaking changes are highlighted above

[tonyxiao]

@max-rocket-internet this used to be required to fix the issue of EKS not being able to create ELB. Is that no longer an issue? How do you know we didn’t introduce a regression here?

[max-rocket-internet]

Is that no longer an issue? How do you know we didn’t introduce a regression here?

Because I tested it. Also, the default AWS IAM policy arn:aws:iam::aws:policy/AmazonEKSClusterPolicy includes this now:

        {
            "Effect": "Allow",
            "Action": "iam:CreateServiceLinkedRole",
            "Resource": "*",
            "Condition": {
                "StringLike": {
                    "iam:AWSServiceName": "elasticloadbalancing.amazonaws.com"
                }
            }
        }

I would be curious if you still have that error when your cluster is using the default AWS IAM policy.

[tonyxiao]

Ah ok. Got it thank you.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.