feat: Strip https:// from OIDC provider URL if present #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-rocket-internet
approved these changes
Feb 11, 2020
|
I'd also like to vote for this change. The variable name |
|
@chancez can you rebase @antonbabenko can you review |
|
Rebased |
chancez
force-pushed
the
oidc_remove_https_scheme
branch
from
40aaf35 to
2f80cb3
Compare
antonbabenko
requested changes
Jul 20, 2020
antonbabenko
changed the title
chancez
force-pushed
the
oidc_remove_https_scheme
branch
2 times, most recently
from
ac857c4 to
e17d37e
Compare
The OIDC URL returned from the AWS API and https://github.com/terraform-aws-modules/terraform-aws-eks contains the https:// scheme in the URL, this handles removing it automatically, as required for correctly creating IAM policies.
chancez
force-pushed
the
oidc_remove_https_scheme
branch
from
e17d37e to
e74a299
Compare
hoylemd
added a commit
to pixlee/terraform-aws-iam
that referenced
this pull request
Oct 14, 2020
* upstream/master: (26 commits) Updated CHANGELOG fix: Fixed ses_smtp_password_v4 output name Updated CHANGELOG fix: simplify count statements (terraform-aws-modules#93) Updated CHANGELOG fix: Allow running on custom AWS partition (incl. govcloud) (terraform-aws-modules#94) Updated CHANGELOG feat: modules/iam-assumable-role-with-oidc: Support multiple provider URLs (terraform-aws-modules#91) Updated CHANGELOG feat: Strip https:// from OIDC provider URL if present (terraform-aws-modules#50) Updated CHANGELOG fix: Allow modules/iam-assumable-role-with-oidc to work in govcloud (terraform-aws-modules#83) Updated CHANGELOG feat: Added support for sts:ExternalId in modules/iam-assumable-role (terraform-aws-modules#90) Updated CHANGELOG fix: Delete DEPRECATED ses_smtp_password in iam-user. (terraform-aws-modules#88) Updated CHANGELOG feat: Support for Terraform v0.13 and AWS provider v3 (terraform-aws-modules#87) docs: Updated example in README (terraform-aws-modules#52) Updated CHANGELOG ...
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OIDC URL returned from the AWS API and https://github.com/terraform-aws-modules/terraform-aws-eks
contains the https:// scheme in the URL, this handles removing it
automatically, as required for correctly creating IAM policies.