Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow modules/iam-assumable-role-with-oidc to work in govcloud #83

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

bsmedberg-xometry
Copy link
Contributor

by using the current partition instead of hardcoding "aws"

Description

Currently this module does not work in govcloud because it hardcodes "arn:aws:...", while govcloud uses ARNs of the form "arn:aws-gov". This changes to use the documented technique for getting the current partition.

Breaking Changes

None.

How Has This Been Tested?

I have verified in a local Xometry environment that this produces correct and working IAM role definitions for both govcloud and non-govcloud environments.

by using the current partition instead of hardcoding "aws"
@bsmedberg-xometry bsmedberg-xometry changed the title Allow terraform-aws-iam to work in govcloud fix: Allow terraform-aws-iam to work in govcloud Jul 24, 2020
@antonbabenko antonbabenko changed the title fix: Allow terraform-aws-iam to work in govcloud fix: Allow modules/iam-assumable-role-with-oidc to work in govcloud Aug 17, 2020
@antonbabenko antonbabenko merged commit 7a1edae into terraform-aws-modules:master Aug 17, 2020
@antonbabenko
Copy link
Member

Thanks, @bsmedberg-xometry !

v2.16.0 has been just released.

hoylemd added a commit to pixlee/terraform-aws-iam that referenced this pull request Oct 14, 2020
* upstream/master: (26 commits)
  Updated CHANGELOG
  fix: Fixed ses_smtp_password_v4 output name
  Updated CHANGELOG
  fix: simplify count statements (terraform-aws-modules#93)
  Updated CHANGELOG
  fix: Allow running on custom AWS partition (incl. govcloud) (terraform-aws-modules#94)
  Updated CHANGELOG
  feat: modules/iam-assumable-role-with-oidc: Support multiple provider URLs (terraform-aws-modules#91)
  Updated CHANGELOG
  feat: Strip https:// from OIDC provider URL if present (terraform-aws-modules#50)
  Updated CHANGELOG
  fix: Allow modules/iam-assumable-role-with-oidc to work in govcloud (terraform-aws-modules#83)
  Updated CHANGELOG
  feat: Added support for sts:ExternalId in modules/iam-assumable-role (terraform-aws-modules#90)
  Updated CHANGELOG
  fix: Delete DEPRECATED ses_smtp_password in iam-user. (terraform-aws-modules#88)
  Updated CHANGELOG
  feat: Support for Terraform v0.13 and AWS provider v3 (terraform-aws-modules#87)
  docs: Updated example in README (terraform-aws-modules#52)
  Updated CHANGELOG
  ...
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants