Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modules/iam-assumable-role-with-oidc: Support multiple provider URLs #91

Merged
merged 2 commits into from
Aug 18, 2020

Conversation

antonbabenko
Copy link
Member

@antonbabenko antonbabenko commented Aug 18, 2020

Based on #81
Closes #81

chancez and others added 2 commits August 17, 2020 14:21
… URLs

This allows using one role with multiple OIDC providers, for example
when you want to use a single role across multiple EKS clusters.

Deprecates provider_url in favor of provider_urls which allows
specifying more than 1 provider URL. Existing behavior is retained, and
both options can be specified.
@antonbabenko antonbabenko changed the title feat: modules/iam-assumable-role-with-oidc: Support multiple provider URLs Based on #81 Closes #81 feat: modules/iam-assumable-role-with-oidc: Support multiple provider URLs Aug 18, 2020
@antonbabenko antonbabenko merged commit 283a514 into master Aug 18, 2020
@antonbabenko antonbabenko deleted the pr/81 branch August 18, 2020 08:30
hoylemd added a commit to pixlee/terraform-aws-iam that referenced this pull request Oct 14, 2020
* upstream/master: (26 commits)
  Updated CHANGELOG
  fix: Fixed ses_smtp_password_v4 output name
  Updated CHANGELOG
  fix: simplify count statements (terraform-aws-modules#93)
  Updated CHANGELOG
  fix: Allow running on custom AWS partition (incl. govcloud) (terraform-aws-modules#94)
  Updated CHANGELOG
  feat: modules/iam-assumable-role-with-oidc: Support multiple provider URLs (terraform-aws-modules#91)
  Updated CHANGELOG
  feat: Strip https:// from OIDC provider URL if present (terraform-aws-modules#50)
  Updated CHANGELOG
  fix: Allow modules/iam-assumable-role-with-oidc to work in govcloud (terraform-aws-modules#83)
  Updated CHANGELOG
  feat: Added support for sts:ExternalId in modules/iam-assumable-role (terraform-aws-modules#90)
  Updated CHANGELOG
  fix: Delete DEPRECATED ses_smtp_password in iam-user. (terraform-aws-modules#88)
  Updated CHANGELOG
  feat: Support for Terraform v0.13 and AWS provider v3 (terraform-aws-modules#87)
  docs: Updated example in README (terraform-aws-modules#52)
  Updated CHANGELOG
  ...
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants