Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mongodb): Make the replica set name configurable #2538

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

shubhamrajvanshi
Copy link
Contributor

What does this PR do?

This PR makes the replica set name configurable, instead of using a predefined name rs.

Why is it important?

A MongoDB replicaset name is a configurable option so I wanted to align test containers with that.

Related issues

None

@shubhamrajvanshi shubhamrajvanshi requested a review from a team as a code owner May 13, 2024 19:21
Copy link

netlify bot commented May 13, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit adad66c
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/666bf87ad3e89000085f4a60
😎 Deploy Preview https://deploy-preview-2538--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya
Copy link
Member

Hi @shubhamrajvanshi could you take a look at this comment #2469 (comment)?

We discussed about it when adding the replica set option. I'm not blocking this, but giving you more context. WDYT?

@mdelapenya mdelapenya self-assigned this Jun 13, 2024
@mdelapenya mdelapenya added the enhancement New feature or request label Jun 13, 2024
@mdelapenya mdelapenya changed the title Make the replica set name configurable feat(mongodb): Make the replica set name configurable Jun 14, 2024
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit 5d68a52 into testcontainers:main Jun 14, 2024
106 checks passed
mdelapenya added a commit that referenced this pull request Jun 14, 2024
* Make replicaset name configurable

* Updated test

* fix: quote replica set name

---------

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
@shubhamrajvanshi
Copy link
Contributor Author

Thanks @mdelapenya for pushing the relevant changes and getting this merged

mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jun 24, 2024
* main:
  docs: document disabling ryuk with properties (testcontainers#2603)
  fix: allow compose files and readers to be used together (testcontainers#2598)
  chore(deps): bump urllib3 from 2.2.1 to 2.2.2 (testcontainers#2590)
  docs: example for NATS cluster (testcontainers#2591)
  docs: fix deprecation for material extensions emoji (testcontainers#2592)
  gha: update golangci-lint to v1.59.1 (testcontainers#2588)
  network: WithCheckDuplicate: don't set CheckDuplicate value (testcontainers#2589)
  fix: proper synchronisation for start/stop log production (testcontainers#2576)
  chore(deps): bump github.com/docker/docker from v25.0.5 to v26.1.4 (testcontainers#2584)
  docs: update contributing guide (testcontainers#2586)
  feat: add testcontainers labels to the built images (testcontainers#2579)
  feat(mongodb): Make the replica set name configurable (testcontainers#2538)
  chore: skip reaper tests if ryuk is disabled (testcontainers#2582)
  chore: increase check time to 60 secs instead of 20 (testcontainers#2581)
  fix: prepend substitutors for built images (testcontainers#2577)
  docs: update colima docs (testcontainers#2578)
  fix(cockroachdb): Fixes cockroachdb wait strategy handling (testcontainers#2456)
  Fix race condition when looking up reaper (ryuk) container (testcontainers#2508)
  chore: bring golangci-lint back (testcontainers#2571)
  docs(compose): Fix typo docker compose docs (testcontainers#2565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants