Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: WithCheckDuplicate: don't set CheckDuplicate value #2589

Merged

Conversation

thaJeztah
Copy link
Contributor

What does this PR do?

Setting this value is a no-opt, as it's automatically set by the client, and the field will be removed in the next release of the docker module, so let's already remove it.

updates 6e086e8, which deprecated this function.

Why is it important?

Related issues

Setting this value is a no-opt, as it's automatically set by the client,
and the field will be removed in the next release of the docker module,
so let's already remove it.

updates 6e086e8, which deprecated this
function.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah requested a review from a team as a code owner June 15, 2024 09:55
Copy link

netlify bot commented Jun 15, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit e63b075
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/666d652226692a000834a298
😎 Deploy Preview https://deploy-preview-2589--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya self-assigned this Jun 17, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Jun 17, 2024
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit 31788a7 into testcontainers:main Jun 17, 2024
105 of 106 checks passed
mdelapenya pushed a commit that referenced this pull request Jun 17, 2024
Setting this value is a no-opt, as it's automatically set by the client,
and the field will be removed in the next release of the docker module,
so let's already remove it.

updates 6e086e8, which deprecated this
function.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah deleted the WithCheckDuplicate_remove_field branch June 17, 2024 12:31
mdelapenya pushed a commit that referenced this pull request Jun 18, 2024
Setting this value is a no-opt, as it's automatically set by the client,
and the field will be removed in the next release of the docker module,
so let's already remove it.

updates 6e086e8, which deprecated this
function.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
mdelapenya pushed a commit that referenced this pull request Jun 18, 2024
Setting this value is a no-opt, as it's automatically set by the client,
and the field will be removed in the next release of the docker module,
so let's already remove it.

updates 6e086e8, which deprecated this
function.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jun 24, 2024
* main:
  docs: document disabling ryuk with properties (testcontainers#2603)
  fix: allow compose files and readers to be used together (testcontainers#2598)
  chore(deps): bump urllib3 from 2.2.1 to 2.2.2 (testcontainers#2590)
  docs: example for NATS cluster (testcontainers#2591)
  docs: fix deprecation for material extensions emoji (testcontainers#2592)
  gha: update golangci-lint to v1.59.1 (testcontainers#2588)
  network: WithCheckDuplicate: don't set CheckDuplicate value (testcontainers#2589)
  fix: proper synchronisation for start/stop log production (testcontainers#2576)
  chore(deps): bump github.com/docker/docker from v25.0.5 to v26.1.4 (testcontainers#2584)
  docs: update contributing guide (testcontainers#2586)
  feat: add testcontainers labels to the built images (testcontainers#2579)
  feat(mongodb): Make the replica set name configurable (testcontainers#2538)
  chore: skip reaper tests if ryuk is disabled (testcontainers#2582)
  chore: increase check time to 60 secs instead of 20 (testcontainers#2581)
  fix: prepend substitutors for built images (testcontainers#2577)
  docs: update colima docs (testcontainers#2578)
  fix(cockroachdb): Fixes cockroachdb wait strategy handling (testcontainers#2456)
  Fix race condition when looking up reaper (ryuk) container (testcontainers#2508)
  chore: bring golangci-lint back (testcontainers#2571)
  docs(compose): Fix typo docker compose docs (testcontainers#2565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants