Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bring golangci-lint back #2571

Merged
merged 14 commits into from
Jun 10, 2024

Conversation

mdelapenya
Copy link
Member

  • fix: enable golangci-lint again
  • fix: lint

What does this PR do?

It enabls golangci-lint again, as it was removed when the Go version was bumped from 1.20 to 1.21

Why is it important?

Static analyse the code for PRs

Related issues

It was accidentally dropped when bumping the Go version
@mdelapenya mdelapenya requested a review from a team as a code owner June 10, 2024 10:08
@mdelapenya mdelapenya added the compose Docker Compose. label Jun 10, 2024
@mdelapenya mdelapenya self-assigned this Jun 10, 2024
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit ddaf9d9
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6666e2999e047400083e3d59
😎 Deploy Preview https://deploy-preview-2571--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya added chore Changes that do not impact the existing functionality and removed compose Docker Compose. labels Jun 10, 2024
@mdelapenya mdelapenya merged commit b856769 into testcontainers:main Jun 10, 2024
106 checks passed
mdelapenya added a commit that referenced this pull request Jun 10, 2024
* fix: enable golangci-lint again

It was accidentally dropped when bumping the Go version

* fix: lint

* fix: lint

* fix: lint

* fix: dolt module must raise errors with options

* fix: lint

* fix: return error in compose module

* fix: influxdb module must return error on customise

* chore: use assert

* fix: no named returns in k3s module

* chore: fix lint

* chore: lint

* fix: registry module must return error on customise

* fi: use same types
mdelapenya added a commit to bearrito/testcontainers-go that referenced this pull request Jun 11, 2024
* main: (48 commits)
  Fix race condition when looking up reaper (ryuk) container (testcontainers#2508)
  chore: bring golangci-lint back (testcontainers#2571)
  docs(compose): Fix typo docker compose docs (testcontainers#2565)
  Handle error properly during port forwarding initialization. (testcontainers#2550)
  chore: pin vearch version (testcontainers#2568)
  feat: add vearch module (testcontainers#2560)
  chore: run tests against latest Docker engine, nightly (testcontainers#2566)
  chore(deps): bump mkdocs-include-markdown-plugin from 6.0.4 to 6.0.7 (testcontainers#2562)
  Fix network accessor for port-forwarding feature (testcontainers#2551)
  --- (testcontainers#2549)
  fix: update search bar eval in mkdocs (testcontainers#2547)
  docs: improve contributing docs for code snippets (testcontainers#2546)
  chore: use a virtualenv for working with the docs site (testcontainers#2545)
  docs: document test session semantics (testcontainers#2544)
  feat(ryuk): allow to configure ryuk timeouts using env variables (testcontainers#2541)
  docs: fix CircleCI docs (testcontainers#2539)
  fix: add import to module generation (testcontainers#2537)
  chore: prepare for next minor development cycle (0.32.0)
  chore: use new version (v0.31.0) in modules and examples
  feat(mongodb): add replica set support via opts (testcontainers#2469)
  ...
@mdelapenya mdelapenya deleted the golangci-lint branch June 13, 2024 11:46
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jun 24, 2024
* main:
  docs: document disabling ryuk with properties (testcontainers#2603)
  fix: allow compose files and readers to be used together (testcontainers#2598)
  chore(deps): bump urllib3 from 2.2.1 to 2.2.2 (testcontainers#2590)
  docs: example for NATS cluster (testcontainers#2591)
  docs: fix deprecation for material extensions emoji (testcontainers#2592)
  gha: update golangci-lint to v1.59.1 (testcontainers#2588)
  network: WithCheckDuplicate: don't set CheckDuplicate value (testcontainers#2589)
  fix: proper synchronisation for start/stop log production (testcontainers#2576)
  chore(deps): bump github.com/docker/docker from v25.0.5 to v26.1.4 (testcontainers#2584)
  docs: update contributing guide (testcontainers#2586)
  feat: add testcontainers labels to the built images (testcontainers#2579)
  feat(mongodb): Make the replica set name configurable (testcontainers#2538)
  chore: skip reaper tests if ryuk is disabled (testcontainers#2582)
  chore: increase check time to 60 secs instead of 20 (testcontainers#2581)
  fix: prepend substitutors for built images (testcontainers#2577)
  docs: update colima docs (testcontainers#2578)
  fix(cockroachdb): Fixes cockroachdb wait strategy handling (testcontainers#2456)
  Fix race condition when looking up reaper (ryuk) container (testcontainers#2508)
  chore: bring golangci-lint back (testcontainers#2571)
  docs(compose): Fix typo docker compose docs (testcontainers#2565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant